Commit Graph

4354 Commits

Author SHA1 Message Date
Jeremy Kemper
88bd86e8bc Run validations in the order they were declared. Closes #6657.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-20 10:12:38 +00:00
Jeremy Kemper
d41f380a2c Extract template_changed_since? from compile_template? so plugins may override its behavior for non-file-based templates. Closes #6651.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-20 09:04:26 +00:00
Jeremy Kemper
19c99acfbc MySQL: detect when a NOT NULL column without a default value is misreported as default ''. Can't detect for string, text, and binary columns since '' is a legitimate default. Closes #6156.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5586 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-20 08:54:42 +00:00
Jeremy Kemper
3fc4771996 Test session table pluralization. Closes #6459.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-20 04:17:48 +00:00
Thomas Fuchs
de6ffba806 Update trunk w/ latest Prototype and script.aculo.us
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 23:01:32 +00:00
David Heinemeier Hansson
44de099efe Restore windows compatibility
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 22:17:26 +00:00
David Heinemeier Hansson
f24ed3bf6d Starting, not started yet
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 21:54:48 +00:00
David Heinemeier Hansson
ee8121fc76 Make script/server work with -d and -e on Mongrel
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5575 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 21:52:14 +00:00
Rick Olson
5999fdd3f3 Use custom mime file for script/server mongrel if config/mime.yml exists. Pass --mime=other/path for a custom mime file. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 21:12:22 +00:00
Rick Olson
ca2d704c75 Add custom mime type file for mongrel. config/mime.yml is added with generated apps from the rails command. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 21:01:25 +00:00
David Heinemeier Hansson
bc6f0d2f30 Scaffold resource should have both a layout and a stylesheet [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5565 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 16:57:33 +00:00
Jeremy Kemper
02adc49d72 Simplify association proxy implementation by factoring construct_scope out of method_missing. Closes #6643.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 11:16:12 +00:00
Jeremy Kemper
ae8171ddc5 Migration benchmark wrappers use alias_method_chain. Closes #6456.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 11:09:31 +00:00
Jeremy Kemper
229ea65374 simple_format helper doesn't choke on nil. Closes #6644.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-19 09:57:16 +00:00
Thomas Fuchs
bc76044fde Update Prototype in trunk to [5550]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 23:52:54 +00:00
Nicholas Seckar
f92d6a07d0 Reuse named route helper module between Routing reloads to prevent memory leaks.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5548 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 22:29:02 +00:00
Jeremy Kemper
44e6aa7e19 Improve readability.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 14:09:46 +00:00
Jeremy Kemper
38136d615e Grep slightly faster than select =~
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 14:09:04 +00:00
Jeremy Kemper
96cca7db6d ActionView::Base.erb_variable accessor names the buffer variable used to render templates. Defaults to _erbout; use _buf for erubis.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 13:10:23 +00:00
Jeremy Kemper
495f113e57 Template errors: fix strange deprecation warnings on e.g. @flash.inspect, remove deprecated @assigns, handle sources without a discernable line number, clean up code.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 12:47:08 +00:00
Jeremy Kemper
615d05f5de Test autoloading nested subclass of parent.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 22:50:46 +00:00
Marcel Molina
1d31a043e0 Use attr_accessor_with_default to dry up attribute initialization. References #6538. [Stuart Halloway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 19:36:50 +00:00
Marcel Molina
309a6bd550 Add Module#attr_accessor_with_default to initialize value of attribute before setting it. Closes #6538. [Stuart Halloway, Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 19:35:13 +00:00
Jeremy Kemper
0100a79913 Deprecate standalone components.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 06:40:37 +00:00
Jeremy Kemper
072985bc28 Handle failed caller parsing, factor out deprecation caller message.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 06:40:05 +00:00
Jeremy Kemper
be3a4c3daa Mysql::Result#all_hashes compatibility with Mysql C driver 2.6.x. Closes #6601.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 01:41:22 +00:00
Jeremy Kemper
65ca37b7b7 ARStore needs a data reader method. Closes #4795.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-15 20:08:43 +00:00
Jeremy Kemper
9339db70c6 Remove dead abort_tests method.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-15 12:50:51 +00:00
Jeremy Kemper
c9e0002d36 assert_select_rjs :remove
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-15 12:45:52 +00:00
Jeremy Kemper
079d684a37 Fix failing test fallback when neither SQLite 2 or 3 is available.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-15 12:43:34 +00:00
David Heinemeier Hansson
6c271a98dc Fix end of day
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-14 17:39:00 +00:00
Jeremy Kemper
b97ffa2a4f Hash#to_xml handles keys with the same name as Kernel methods. Closes #6613.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-14 09:08:40 +00:00
Jeremy Kemper
50ee332c4a Cleanup SQLite AUTOINCREMENT: exclude sqlite_sequence table, factor out feature availability check.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-14 03:32:16 +00:00
Jeremy Kemper
fda4330ce9 Update Oracle performance credits.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-14 02:49:33 +00:00
Tobias Lütke
a64c6af57c Make sure that exceptions which are thrown outside of the user code try their best to be handeled in ApplicationController#rescue_action.
This allos handling of ActionController::RoutingError which were previously always handeled by ActionController#Base


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 20:23:00 +00:00
Jeremy Kemper
4978d1dce7 Oracle: automatically detect the primary key. Closes #6594.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5514 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 19:23:32 +00:00
Jeremy Kemper
56e3e2fde5 Always clear model associations from session. Closes #4795.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5512 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 18:59:01 +00:00
Jeremy Kemper
a303a168ac Oracle: to increase performance, prefetch 100 rows and enable similar cursor sharing. Both are configurable in database.yml. Closes #6607.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 07:36:52 +00:00
Jeremy Kemper
45fd631e5e Rails::VERSION::STRING on trunk is 1.2.0
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 07:13:41 +00:00
Jeremy Kemper
277c1a803e Rails::VERSION::STRING should always be available. Closes #6244.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 06:23:58 +00:00
Jeremy Kemper
c3ff04b05d Allow mailer actions named send by using __send__ internally. Closes #6467.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 05:03:48 +00:00
Jeremy Kemper
f0753992ab test controller rescues
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 02:03:50 +00:00
Jeremy Kemper
f8486e8f10 silence const_set warning
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 01:17:10 +00:00
Jeremy Kemper
afe49dcf5b update_element_function is deprecated
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5501 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-13 00:53:20 +00:00
Sam Stephenson
c192bdfc74 Update to Prototype 1.5.0_rc2
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-12 03:44:35 +00:00
David Heinemeier Hansson
79c309e43b Added Time#end_of_day to get 23:59:59 of that day [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5495 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-12 03:05:18 +00:00
Jamis Buck
da3eae4922 Add grep-based fallback to reaper, so it can work in pidless setups (again)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5488 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-11 22:46:00 +00:00
Sam Stephenson
4c7dcb5dbf Remove JavaScriptLiteral in favor of ActiveSupport::JSON::Variable.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-11 18:29:11 +00:00
Sam Stephenson
2516063f61 Don't quote hash keys in Hash#to_json if they're valid JavaScript identifiers.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5486 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-11 18:25:26 +00:00
Jeremy Kemper
2a92995d2a Only wrap request processing with our USR1 signal handler so FastCGI can trap it and raise an exception while waiting for connections. Idle processes exit immediately rather than waiting for another request; active processes gracefully exit when the request is finished.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-11 08:08:53 +00:00