Xavier Noria
8f57bf207f
tests predicates according to the boolean interpretation of their return value, not expecting specifically true or false
...
Respecting Genuine assert_equal false Edition
2011-11-21 14:22:16 -08:00
José Valim
401393b656
Deprecate InstanceMethods namespace handling in ActiveSupport::Concern.
...
This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions.
2011-11-21 22:17:35 +00:00
Xavier Noria
f312e2142b
Revert "tests predicates according to the boolean interpretation of their return value, not expecting specifically true or false"
...
Reason: there were some genuine tests for false when
reading values, going to revise those ones.
This reverts commit a539a5e3f3
2011-11-21 14:14:11 -08:00
Xavier Noria
a539a5e3f3
tests predicates according to the boolean interpretation of their return value, not expecting specifically true or false
2011-11-21 14:11:40 -08:00
Xavier Noria
f3554777b2
cache entry: options[:compressed] is a regular flag, no need for !!
2011-11-21 14:01:53 -08:00
Xavier Noria
91678a5b29
adds a comment to clarify an edge case
2011-11-21 13:53:40 -08:00
Xavier Noria
60e3e218c2
a couple of spurious spaces I saw in passing
2011-11-21 22:11:31 +01:00
Vijay Dev
4c872c017b
Remove the -h option to dbconsole which is the shorter form of --header
...
This is done since the -h option to dbconsole hides the conventional
-h for help and forces users to use --help to see the usage options for
dbconsole.
2011-11-22 00:05:46 +05:30
Aaron Patterson
5d704fa152
oops! I suck! 💣
2011-11-20 15:11:11 -08:00
Aaron Patterson
008abd17dc
fixing tests on ruby 1.8
2011-11-20 15:09:03 -08:00
Aaron Patterson
26c542ba2c
Merge pull request #3701 from arunagw/arel_bump
...
Bump Arel
2011-11-19 23:17:26 -08:00
Arun Agrawal
be9d3a2008
Bump Arel
2011-11-20 12:27:25 +05:30
Aaron Patterson
599d7c40a4
removing deprecated methods
2011-11-19 20:43:04 -08:00
Aaron Patterson
3d2bd69385
Revert "copy options keys to the right place so that undo will work correctly"
...
This reverts commit 3178cc9a80
2011-11-19 20:35:54 -08:00
Aaron Patterson
24fa524cef
adding visitors to the respective adapters
2011-11-19 20:28:41 -08:00
Aaron Patterson
bd2f5c062d
pushing caching and visitors down to the connection
2011-11-19 20:19:53 -08:00
Santiago Pastorino
4cdd44e3e0
Merge pull request #3668 from gregolsen/api_docstring_fix
...
updating API docstring so that user can infer default value
2011-11-19 11:52:44 -08:00
José Valim
43158e58b2
Merge pull request #3696 from lest/fix-plugin-generator
...
fix rails plugin new CamelCasedName bug
2011-11-19 11:04:39 -08:00
lest
c220b4d833
fix warning about instance variable in plugin generator
2011-11-19 21:58:30 +03:00
lest
39d2251d8a
fix rails plugin new CamelCasedName bug
...
refs #3684
2011-11-19 19:09:09 +02:00
Yehuda Katz
bc04455f10
Merge pull request #3695 from tobiassvn/partial_path_error
...
Meaningful errors for unexpected partial arguments. Fixes #3573
2011-11-19 07:38:22 -08:00
Jon Leighton
fec85cf10d
Perf fix
...
If we're deleting all records in an association, don't add a IN(..)
clause to the query.
Fixes #3672 .
2011-11-19 14:11:29 +00:00
Jon Leighton
2ef4947ab0
Add missing CHANGELOG entry for #3678 . Closes #3678 .
2011-11-19 13:34:50 +00:00
Jon Leighton
603a679e87
Don't html-escape the :count option to translate if it's a Numeric. Fixes #3685 .
2011-11-19 13:28:07 +00:00
Jon Leighton
86b5e81e8a
Bump sprockets to 2.1.1
2011-11-19 13:08:34 +00:00
Tobias Svensson
771635e858
Meaningful errors for unexpected partial arguments. Fixes #3573
2011-11-19 13:05:57 +00:00
Jon Leighton
11afb74089
Merge pull request #3687 from kennyj/fix_3678-2
...
Use `show index from`. We could fix `pk_and_sequence_for` method's performance problem (GH #3678 )
2011-11-19 05:00:37 -08:00
Jon Leighton
9c37416a3e
Verify that #3690 has been closed by previous changes to the mysql
...
adapters.
These tests fail on the v3.1.2 tag.
Closes #3690 .
2011-11-19 12:34:15 +00:00
Yehuda Katz
89bbb6ce21
Merge pull request #3689 from arunagw/warning_removed_actionpack
...
Warning removed for shadowing variable
2011-11-18 22:42:14 -08:00
Arun Agrawal
d806ea2050
Warning removed for shadowing variable
2011-11-19 11:29:29 +05:30
kennyj
f9b9179016
Use show index from. We could fix pk_and_sequence_for method's performance problem (GH #3678 )
2011-11-19 04:19:31 +09:00
Aaron Patterson
396ef44be4
Revert "make sure to require the right deprecation warning file"
...
This reverts commit 9d725e3df502a07222f35576108eb2df2bd88259.
2011-11-18 10:51:12 -08:00
Aaron Patterson
99d94f126d
Refactoring the redirect method for the router api.
2011-11-18 10:51:12 -08:00
Aaron Patterson
d34efdd260
moving redirection to objects
2011-11-18 10:51:12 -08:00
Aaron Patterson
0809c675ef
remove the :path feature to redirects, since it cannot work
2011-11-18 10:51:11 -08:00
Aaron Patterson
a8a4264858
make sure to require the right deprecation warning file
2011-11-18 10:51:11 -08:00
Aaron Patterson
163b645472
arity check has been pushed up, so no need for proc wrapping
2011-11-18 10:51:11 -08:00
Aaron Patterson
4589b2419b
require that all blocks have arity of 2
2011-11-18 10:51:11 -08:00
Aaron Patterson
3178cc9a80
copy options keys to the right place so that undo will work correctly
2011-11-18 10:51:11 -08:00
Aaron Patterson
ecbae99478
no need for type checking
2011-11-18 10:51:11 -08:00
Aaron Patterson
636405d2a6
cleaning up variable names to match method parameter names
2011-11-18 10:51:10 -08:00
Aaron Patterson
33543ac871
stop doing is_a? checks on the resource type
2011-11-18 10:51:10 -08:00
Aaron Patterson
648f6113d1
move constants to methods since nothing else is using them
2011-11-18 10:51:10 -08:00
Aaron Patterson
7459ba4f6c
pushing hash validation up
2011-11-18 10:51:10 -08:00
Aaron Patterson
494ab25772
breaking match down to smaller methods
2011-11-18 10:51:10 -08:00
Aaron Patterson
76780c34f5
some refactoring of the match method
2011-11-18 10:51:09 -08:00
Vijay Dev
dda6787f44
mailer guide - update info about using default host. Fixes #3642
2011-11-19 00:07:50 +05:30
Vijay Dev
48b580a03b
Merge branch 'master' of github.com:lifo/docrails
2011-11-18 23:11:46 +05:30
Vijay Dev
9d035292ba
remove unneeded params from issue tracker url
2011-11-18 23:10:12 +05:30
Vijay Dev
5a2db4c7c3
put back the removed eg
2011-11-18 23:09:30 +05:30
