github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
26,940 Commits 34 Branches 105 Tags
90aae070ed13f2d82fa4ecfc8d229d4ae0c34d7d
Commit Graph

26940 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Piotr Sarnacki
90aae070ed Apparently asssert_empty is not available in 1.8.7 2012-01-16 18:28:01 +01:00
Vijay Dev
48f9835bf5 minor edits in getting started guide 2012-01-16 22:07:49 +05:30
Vijay Dev
39d4878a71 copy editing asset pipeline changes 2012-01-16 22:07:44 +05:30
Richard Hulse
96e5d10fd7 [docs] Update pipeline asset organization section. 
* Calified how assets are included.
* Added information about using index manifests.
 2012-01-16 22:07:40 +05:30
Dan Pickett
951d70dbe0 change class to id per scaffold change 
#4472
 2012-01-16 22:07:36 +05:30
Carlos Antonio da Silva
7b8e6d52a8 Improve description of :allow_destroy option for nested attributes in getting started guide 2012-01-16 22:07:31 +05:30
Guillermo Iguaran
30782e443e Getting Started Guide: Update reference about JavaScript runtimes 2012-01-16 22:07:27 +05:30
Piotr Sarnacki
3430647434 Add ActiveModel::Errors#delete, which was not available after move to use delegation 2012-01-16 17:24:08 +01:00
José Valim
42159354b4 Merge pull request #4474 from guilleiguaran/fix-route-inspector-3-2-stable 
Don't hardcode assets route skipped in route inspector (3-2-stable)
 2012-01-15 08:04:09 -08:00
Guillermo Iguaran
666f9316eb Don't hardcode assets route skipped in route inspector 
Conflicts:

	railties/lib/rails/application/route_inspector.rb
 2012-01-15 10:52:25 -05:00
Piotr Sarnacki
dee595ce04 Fix stack level too deep when model does not have attributes method. 
Without that patch when using ActiveModel::AttributeMethods
in a class that does not respond to `attributes` method,
stack level too deep error will be raised on non existing
method. While documentation is clear that you need to define
`attributes` method in order to use AttributeMethods module,
`stack level too deep` is rather obscure and hard to debug,
therefore we should try to not break `method_missing` if
someone forgets about defining `attributes`.
 2012-01-15 16:01:05 +01:00
Mikel Lindsaar
95027d2240 Upgrade mail dependency to 2.4.0 2012-01-15 22:16:16 +10:30
Aaron Patterson
fce3afa9b2 Merge pull request #4471 from semaperepelitsa/enum_sum 
Pass a symbol instead of a block in Enumerable#sum
 2012-01-14 20:42:52 -08:00
Semyon Perepelitsa
d696f8de92 Pass a symbol instead of a block. This is faster and more concise. 
At least Ruby 1.8.7 is required which is ok since 3.2.

Benchmark:

```ruby
require "benchmark"

enum = 1..10_000
N = 100
Benchmark.bm do |x|
  x.report "inject block" do
    N.times do
      enum.inject { |sum, n| sum + n }
    end
  end

  x.report "inject symbol" do
    N.times do
      enum.inject(:+)
    end
  end
end
```

Result:

```
       user     system      total        real
inject block   0.160000   0.000000   0.160000 (  0.179723)
inject symbol  0.090000   0.000000   0.090000 (  0.095667)
```
 2012-01-15 11:42:31 +08:00
José Valim
78ef738313 Add begin/ensure block since we are returning. 2012-01-14 09:18:57 +01:00
Jon Leighton
70b762d1a7 Fix race condition 💣 2012-01-13 22:58:26 +00:00
Santiago Pastorino
c159b01b85 Use a BodyProxy instead of including a Module that responds to close. 
Closes #4441 if Active Record is disabled assets are delivered correctly
 2012-01-13 19:44:44 -02:00
José Valim
4ca3592f86 No AS::TestCase here. 2012-01-13 20:57:51 +01:00
José Valim
b745fe1e83 config.force_ssl should mark the session as secure. 2012-01-13 19:55:34 +01:00
José Valim
70631e723c Merge pull request #4451 from guilleiguaran/add-therubyracer-commented 2012-01-13 12:40:10 -02:00
Guillermo Iguaran
05367e656f Update Railties section of 3.2 release notes 2012-01-13 12:40:43 +05:30
Xavier Noria
01c1127461 warns against using temporary subscribers 2012-01-12 14:59:07 -08:00
Vijay Dev
700f778814 fix rails binary path when using --dev [ci skip] 2012-01-13 01:57:06 +05:30
Piotr Sarnacki
a6dce45f42 Added note about [ci skip] tag to contributing guide 2012-01-12 21:19:35 +01:00
Vijay Dev
e4c7ebef87 add info about kindle guides in the release guide [ci skip] 2012-01-13 01:31:59 +05:30
Piotr Sarnacki
0d1df723c7 Fix table_name in ActiveRecord with more than one abstract ancestors 
When subclassing abstract_class table_name should be always computed
based on class name, no matter if superclass is subclassing base
or another abstract_class. So:

class FirstAbstract < ActiveRecord::Base
  self.abstract_class = true
end
class SecondAbstract < FirstAbstract
  self.abstract_class = true
end

class Post < SecondAbstract
  self.table_name #=> 'posts' (not 'second_abstracts')
end
 2012-01-12 20:53:01 +01:00
Vijay Dev
ac153fe485 prepare for 3.2 guides release :) 2012-01-13 01:20:10 +05:30
Vijay Dev
ddfd2cf1c2 remove hidden link in guides layout 2012-01-13 01:19:58 +05:30
Aaron Patterson
1d74af6688 moving to arel 3.0.0 2012-01-12 11:39:35 -08:00
Aaron Patterson
6dac17f04d depend on journey 1.0.0 2012-01-12 11:34:15 -08:00
Vijay Dev
040c9e491c add 3.2 release notes to the guides index 2012-01-13 00:42:48 +05:30
Vijay Dev
03a719843e minor edits 2012-01-13 00:42:40 +05:30
Vijay Dev
e6b59432ea fixes in api docs 2012-01-13 00:42:33 +05:30
Vijay Dev
8ff8ca7a82 minor revision in 3.2 release guide 2012-01-13 00:16:23 +05:30
Santiago Pastorino
3f16f5b7a0 Add CHANGELOG entry 2012-01-11 23:52:41 -02:00
Santiago Pastorino
fc74a51c3f on and ON are type casted to a true boolean column 2012-01-11 23:26:32 -02:00
Vijay Dev
ffc8e59e8b add some missing formats in the release guide 2012-01-11 23:22:29 +05:30
Santiago Pastorino
9e94e26d6b Merge pull request #4412 from kennyj/fix_3743 
Fix GH #3743. We must specify an encoding in rdoc_option explicitly.
 2012-01-11 15:08:13 -02:00
Vijay Dev
260999067e Some revisions to the release notes guide 
Conflicts:

	railties/guides/source/3_2_release_notes.textile
 2012-01-11 20:46:32 +05:30
Matt Jones
d0915ac2f9 add documentation explaining reorder behavior 2012-01-11 20:24:22 +05:30
codesnik
96d4da1719 Made an example a little more realistic 2012-01-11 20:24:17 +05:30
Santiago Pastorino
bb78804a5e Merge pull request #4408 from tomstuart/read-and-write-attribute-aliases 
#[] and #[]= are no longer interchangeable with #read_attribute and #write_attribute
 2012-01-11 12:10:59 -02:00
Santiago Pastorino
9c88005d97 Merge pull request #4404 from rizwanreza/edits-to-spastorino-upgrade-notes 
Edits to spastorino's upgrade notes
 2012-01-11 05:44:18 -08:00
Rizwan Reza
7be7710f52 Edits to spastorino's additions in 3.2 Release Notes 2012-01-11 17:09:37 +03:30
Aaron Patterson
77785c7806 FFFFFFFFUUUUUUUUUUUUUUUUUUUUUUUUU 💣 2012-01-10 13:24:15 -08:00
Aaron Patterson
5e04884bce deprecate the subdirectories parameter to migrations 
Conflicts:

	activerecord/lib/active_record/migration.rb
 2012-01-10 13:19:11 -08:00
Santiago Pastorino
03f62755e3 Add "What to update in your apps" section to the release notes guide 
We should keep this up to date and the current version is probably wrong
and/or incomplete. HELP!!!
 2012-01-10 18:22:33 -02:00
José Valim
ae14b71b70 Remove duplicated test line which was causing Ci failures on 1.8.7. 2012-01-10 20:51:45 +01:00
Santiago Pastorino
bda0ae76a8 Remove dead code 2012-01-10 16:46:26 -02:00
Santiago Pastorino
6f48fb3ad3 Add CHANGELOG entry 2012-01-10 16:36:18 -02:00