github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
16,798 Commits 34 Branches 105 Tags
94de5b8cb58a5b0e1b0493932ec8b6bdf2b8f6dc
Commit Graph

83 Commits

Author SHA1 Message Date
Pratik Naik
4b91daff13 Special treatement for Relation#select { with block } 2010-06-02 14:42:25 +01:00
Santiago Pastorino
0c37bf8f91 To allow proper fisting of stack trace 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-14 10:36:59 -07:00
Xavier Noria
7321a3a7d3 revises the rdoc of #average according to 5f3bd55, and realigns when clauses 2010-05-12 08:47:55 +02:00
Santiago Pastorino
5f3bd55726 type_cast_calculated_value refactor: value is never a Fixnum here. Fix test since SQLite returns Float. 
[#4514 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-11 22:29:26 -07:00
Pratik Naik
f75a6fec29 Improve code from 231d7676f7 2010-05-09 12:33:25 +01:00
Josh Kalderimis
231d7676f7 corrected AR find_each and find_in_batches to raise when the user uses select but does not specify the primary key 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-09 13:14:47 +03:00
Santiago Pastorino
0b4211c88b Here the intention was to assign to different objects 2010-05-08 23:29:51 +03:00
Santiago Pastorino
9aaef59356 Make find_or_create and find_or_initialize work mixing explicit parameters and a hash [#4457 state:committed] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-07 09:40:02 -07:00
Ernie Miller
902861a43a Fix unintuitive behavior with multiple order and group clauses 
[#4545 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-06 16:00:39 -07:00
Brian Lopez
7aad851c2e Allow pre-casted values (other than nil) to pass through from calculations un-touched 
[#4514 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-04 11:57:52 -07:00
Ernie Miller
e33d304975 Fix eager loading of associations causing table name collisions 
[#4463 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-28 20:28:51 -07:00
Santiago Pastorino
961aa70e4a Some require indifferent_access added 
Signed-off-by: Xavier Noria <fxn@ubuntu.(none)>
 2010-04-21 07:45:29 -07:00
Pratik Naik
2ff73039bd Build PredicateBuilder object only when needed 2010-04-21 02:43:52 +01:00
Jeremy Kemper
6d29f9789e Fix evals missing context 2010-04-10 22:39:10 -07:00
Jeremy Kemper
86dda361e2 Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...) 2010-04-10 22:37:36 -07:00
Carl Lerche
6e18fa0375 Raise a StatementInvalid error when trying to build a condition with hash keys that do not correspond to columns. 2010-04-03 09:22:00 -07:00
Pratik Naik
cfa283201e Goodbye ActiveRecord::NamedScope::Scope 2010-04-02 18:57:46 +01:00
Pratik Naik
62fe16932c Make Relation#first and Relation#last behave like named scope's 2010-04-02 18:57:46 +01:00
Pratik Naik
b77dd218ce Add Relation extensions 2010-04-02 17:38:02 +01:00
Pratik Naik
bc7da9b77d Consistency when using Relation constants 2010-04-02 17:38:02 +01:00
Emilio Tagua
7006aa1a85 Arel now handles ranges with excluded end. 2010-03-29 12:30:13 -03:00
Emilio Tagua
53ddbfc460 Warn scoped order and limit are ignored. [#4123 state:resolved] 2010-03-29 11:30:06 -03:00
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Emilio Tagua
fc2e25734a Move methods from association to relation finder methods. 2010-03-25 15:47:06 -03:00
Emilio Tagua
90a4709601 Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects. 2010-03-25 13:03:30 -03:00
Emilio Tagua
d289e15af9 From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that. 
[#4253 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-22 11:48:39 -07:00
Aaron Patterson
587f468282 kill where / having method redefine warnings. [#4225 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 13:30:59 -07:00
Emilio Tagua
e08c153a08 Arel now fallback to using Arel::Attribute if the table/column doesn't exists. 
[#4142 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-10 13:49:11 -08:00
Aaron Patterson
aad432a9e9 removing spawn from SpawnMethods 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-10 13:29:00 -08:00
Pratik Naik
181c414baa Fix scope loading issue when the table doesn't exist 2010-03-10 11:28:04 +00:00
Aaron Patterson
45c36ea096 refactoring build_where 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 13:25:12 -08:00
Santiago Pastorino
ee541049fd avoid @lock_value not initialized warning 2010-02-22 14:08:07 -08:00
Pratik Naik
dc3cc6c608 Move batch finders to Relation 2010-02-12 22:31:03 +00:00
Pratik Naik
ec057ada07 Rely on arel to generate the correct sql when an empty array is supplied to IN predicate 2010-01-30 19:34:05 +00:00
Jeremy Kemper
fd0eb3d904 Clear up some ivar warnings 2010-01-27 19:33:03 -08:00
Pratik Naik
a68a3e9af6 Simplify finder method definitions 2010-01-21 22:29:21 +05:30
Pratik Naik
da142cd865 Supplying Arel::SqlLiteral is much faster 2010-01-21 17:52:09 +05:30
Pratik Naik
fa9f000246 Use quoted_table_name with arel.from() if no from values explicitly supplied. Arel seems to be spending a lot of time figuring out the FROM value otherwise. 2010-01-21 01:37:02 +05:30
Pratik Naik
24cc9e5b4f Relation#spawn is basically clone + reset 2010-01-21 00:41:15 +05:30
Pratik Naik
8bdcb6f072 Always use table.* in the finder query unless specified 2010-01-21 00:40:38 +05:30
Pratik Naik
459e9b29d4 Use @limit_value and @offset_value instead of calling arel 2010-01-20 22:20:56 +05:30
Pratik Naik
1fb78e3ed8 Base.merge_conditions is no longer needed 2010-01-20 20:37:17 +05:30
Pratik Naik
2493229674 Delegate exists? to Relation 2010-01-20 18:17:37 +05:30
Pratik Naik
5502780c69 Move array_of_strings? to Relation 2010-01-20 14:01:42 +05:30
Pratik Naik
52ec4311f5 Delegate all finders to Relation 2010-01-20 03:35:25 +05:30
Pratik Naik
74e3539cda Ignore order for simple calculations to make postgresql happy 2010-01-20 02:17:49 +05:30
Pratik Naik
9acf0af544 Remove Relation#where_clause 2010-01-19 23:11:54 +05:30
Pratik Naik
9465b84b54 Rename CalculationMethods to Calculations and get rid of the old Calculations module 2010-01-19 22:17:33 +05:30
Pratik Naik
8f63dcb648 Move the only remaining calculation method calculate() to Relation 2010-01-19 22:17:33 +05:30
Pratik Naik
ec63fdcff3 Get rid of construct_count_options_from_args 2010-01-19 20:43:03 +05:30