github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-29 08:18:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,038 Commits 34 Branches 105 Tags
952ec79bec313e0001adfc8c86f7970448d32db9
Commit Graph

7038 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Cheah Chu Yeow
952ec79bec Faster Hash#slice that doesn't use Enumerable#include?. 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2008-06-02 11:47:15 -07:00
Joshua Peek
714d42d1a6 Fixed initializer tests by stubbing out gems dependencies check. 2008-06-02 10:40:01 -05:00
Joshua Peek
185fe2e9cc In 9c4f003, gem installation quotes versions. Do the same for unpack and update tests to reflect the change. 2008-06-02 09:54:36 -05:00
Marcos Tapajos
14a65cd982 Fixed changelog merge. 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-06-02 09:47:53 -05:00
Jonathan Viney
4210d85a3f Ensure Associations#sum returns 0 when no rows are returned. [#295 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-02 12:50:44 +01:00
Joshua Peek
a980eb8c77 Added Rack middleware to handle static files. 2008-06-01 13:18:31 -07:00
Ezra Zygmuntowicz
06cb20708b Added Rack processor 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-06-01 11:25:11 -07:00
David Heinemeier Hansson
3282bf3b50 Added SQL escaping for :limit and :offset in MySQL [Jonathan Wiess] 2008-06-01 09:15:11 -07:00
rick
71528b1825 Previously we only added the "lib" subdirectory to the load path when 
setting up gem dependencies for frozen gems. Now we add the "ext"
subdirectory as well for those gems which have compiled C extensions
as well. [Wincent Colaiuta]

[#268 state:resolved]
v2.1.0 		2008-05-31 17:22:16 -07:00
rick
6a975d6ca2 fix changelog conflict 2008-05-31 17:15:24 -07:00
rick
72483c0d4c Add ActiveRecord::Base.sti_name that checks ActiveRecord::Base#store_full_sti_class? and returns either the full or demodulized name. [rick] [#114 state:resolved] 2008-05-31 17:13:11 -07:00
Jeremy Kemper
ea03b0885c revert mysql test credential change 2008-05-31 17:07:44 -07:00
David Heinemeier Hansson
cb59c93de0 Merge branch 'master' of git@github.com:rails/rails 2008-05-31 17:03:40 -07:00
David Heinemeier Hansson
f9db7695fe Making ready for release of 2.1 2008-05-31 17:03:03 -07:00
Michael Koziarski
ef21e01333 Remove dead code, and the tests for it. 2008-05-31 16:59:03 -07:00
John D. Hume
f6e921f956 Substitute value into validates_format_of message 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-05-31 16:59:03 -07:00
David Heinemeier Hansson
ef0ea782b1 Added SQL escaping for :limit and :offset [#288 state:closed] (Aaron Bedra, Steven Bristol, Jonathan Wiess) 2008-05-31 16:57:46 -07:00
rick
a6e7908327 fix doc typos 2008-05-31 16:46:47 -07:00
Dmitriy Timokhin
224c8e6afb Expose GemPlugin load_paths so they can be added to Dependencies.load_paths. Also use full_gem_path as root of GemPlugin to make things compatible. [#213 state:resolved] 2008-05-31 16:46:13 -07:00
rick
d5bcff172b Consolidate error messages for missing gems, and skip them when running rake gems:* tasks. [rick] 2008-05-31 16:36:34 -07:00
rick
2506e5c9a7 Merge branch 'master' of git@github.com:rails/rails 2008-05-31 15:59:01 -07:00
rick
9c4f00350a fix Gem installation command with versions 2008-05-31 15:58:08 -07:00
Tim Morgan
fb89d7fa6d Run gem install as external command. [#210 state:resolved] 2008-05-31 15:57:03 -07:00
David Heinemeier Hansson
f32bceeee1 Merge branch 'master' of git@github.com:rails/rails 2008-05-31 15:51:28 -07:00
David Heinemeier Hansson
9b75483bf3 Added better error message for when the class name is already used (and dont show suggestions if there are none) 2008-05-31 15:51:01 -07:00
Jeremy Kemper
7391f7728d Ruby 1.8.7 compat: work around broken DelegateClass#respond_to? 2008-05-31 15:36:32 -07:00
Joshua Peek
3a9775076f Removed suggestion for turning off partial updates. 2008-05-31 15:34:01 -07:00
Michael Koziarski
0abf0da001 Don't provide the password with dbconsole unless explicitly opted in. 
Some operating system configurations allow other users to view your process list
or environmental variables.  This option should not be used on shared hosts.

http://dev.mysql.com/doc/refman/5.0/en/password-security.html
http://www.postgresql.org/docs/8.3/static/libpq-envars.html
 2008-05-31 15:30:26 -07:00
Jeremy Kemper
4e4bcb4c6b Ruby 1.8.7 compat: TimeWithZone# and Chars#respond_to? pass along the include_private argument 2008-05-31 14:55:02 -07:00
rick
2243ffd1ff Merge branch 'master' of git@github.com:rails/rails 2008-05-31 13:39:58 -07:00
Tom Ward
77e45352e7 Fixed Dependencies so load errors are not masked behind a 'Expected x.rb to define X' message when mechanism is not set to :load [#87 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-05-31 13:33:38 -07:00
rick
fbd901e8d6 Merge branch 'master' of git@github.com:technoweenie/rails 2008-05-31 13:32:10 -07:00
Tim Harper
0580b31b36 belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not. 
fixes the following scenarios:
* I have validates_inclusion_of on the type field for a polymorphic belongs_to association.  I assign a new record to the model's polymorphic relationship of the proper type.  validation fails because the type field has not been updated.

* I replace the value for a ppolymorphic association to a new record of another class.  The type field still says its the previous class, and the id field points to the previous record as well.

[#191 state:closed]
 2008-05-31 13:27:25 -07:00
Tim Harper
aef47dcf93 belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not. 
fixes the following scenarios:
* I have validates_inclusion_of on the type field for a polymorphic belongs_to association.  I assign a new record to the model's polymorphic relationship of the proper type.  validation fails because the type field has not been updated.

* I replace the value for a ppolymorphic association to a new record of another class.  The type field still says its the previous class, and the id field points to the previous record as well.
 2008-05-31 13:23:00 -07:00
Ryan Bates
f7015336f6 Fix default nil tests for MySQL 5.0.51 [#192 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-05-31 12:36:07 -07:00
Jeremy Kemper
03ba5d7b51 Ensure query assertion counts are the same when partial updates are enabled 2008-05-30 04:36:00 -07:00
Jeremy Kemper
2ce1be3ac4 Enable partial updates by default 2008-05-30 04:16:57 -07:00
Jeremy Kemper
946f51449a Require ruby-prof 0.6.1 or later. Use resume/pause to omit extraneous machinery from profile. 2008-05-30 02:39:00 -07:00
Jeremy Kemper
131dd0e912 git ignore rubinius .rbc files 2008-05-30 02:31:39 -07:00
Tekin Suleyman
1b0654ea41 Ensure script/plugin installs ssh/git plugins. [#277 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-29 20:21:49 +01:00
Andrew White
235d635708 Ensure :select passed in options overrides the one from the scope. [#239 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-29 14:10:24 +01:00
Adam
cf6299dbd7 Add ActionMailer#reply_to. [#245 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-29 10:38:00 +01:00
Pratik Naik
abb1bd2efa Ensure AssociationCollection#count works with empty condition. [#271 state:resolved] [Jan De Poorter] 2008-05-29 10:20:39 +01:00
Pratik Naik
4d24854342 Ensure correct db time is reported in production logs. 2008-05-28 22:58:45 +01:00
Ryan Bates
c2fbcba16d Ensure named_scope#empty? uses count query. [#262 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-28 11:02:07 +01:00
Jeremy Kemper
888a2927b6 Remove superfluous tests directive 2008-05-26 01:39:21 -07:00
Jeremy Kemper
7520770c82 Don't require AV::TestCases to have a helper class. Only include the helper class in setup if it hasn't been already. 2008-05-26 01:38:56 -07:00
Tarmo Tänav
c5d37c0662 Fix tests for postgres 8.3.x 
Made test_with_limiting_with_custom_select not dependent on database
default order. Fixed tests with non-US monetary locale. The monetary
type is fixed precision so it should not expect the database to
return a float.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-26 00:45:42 +01:00
gbuesing
f88267d532 TimeZone#to_s shows offset as GMT instead of UTC, because GMT will be more familiar to end users (see time zone selects used by Windows OS, google.com and yahoo.com.) Reverts [8370] 2008-05-25 11:56:29 -05:00
Pratik Naik
98dc582742 Merge docrails. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-25 12:29:00 +01:00