github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-28 07:48:00 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,770 Commits 34 Branches 105 Tags
985ee85f598b5a43543a566ef87738b96efab117
Commit Graph

5770 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Koziarski
985ee85f59 Remove broken require 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8023 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 02:58:24 +00:00
Michael Koziarski
2cc0cac3ef Introduce TestCase subclasses for testing rails applications allowing tests to be DRY'd up a bit and to provide a path toward tidying up our monkeypatching of test/unit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 02:21:21 +00:00
Jeremy Kemper
2bfd6772a4 Use instead of STDERR in boot.rb. Closes #9988 [thewoolleyman] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 01:45:31 +00:00
Marcel Molina
423788371a Fix typo in test_helper. Closes #9925 [viktor tron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 01:07:41 +00:00
Marcel Molina
65e18af03a Fix incorrect path in helper rdoc. Closes #9926 [viktor tron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 01:04:40 +00:00
Jeremy Kemper
4d2ae8a699 Partials also set 'object' to the default partial variable. Closes #8823. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 21:32:01 +00:00
Jeremy Kemper
cb1aab0552 / default uri, -b shortcut 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8017 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 20:46:50 +00:00
Jeremy Kemper
d69be7df6d Request profiler 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 20:33:28 +00:00
Michael Koziarski
96557eb35b Remove superfluous code and quote table name. References #9971 [jkit, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 18:53:07 +00:00
Michael Koziarski
11d2a309c5 Make clear_reloadable_connections! take account of @@allow_concurrency. Closes #7579 [wilson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 08:09:41 +00:00
Michael Koziarski
192e463d05 Add an ignored options parameter to ActiveSupport::JSON::Variable#to_json to make sure it duck-types nicely with the other JSON types. [Pascal Belloncle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 07:09:09 +00:00
Michael Koziarski
2d208eb3a0 Make sure that the Schema Dumper supports non-standard primary keys with MySQL. Closes #9971 [RubyRedRick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 06:42:05 +00:00
Michael Koziarski
12d8d48b71 Refactor the default rendering out to a method called default_render to provide a hook for plugin authors. Closes #9953 [cjheath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 06:38:01 +00:00
Jeremy Kemper
7c3581cba2 Document Enumerable and Hash #to_json. Add test for hash with integer key. Closes #9970. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-24 16:21:46 +00:00
Jeremy Kemper
4c2920e89c Remove unnecessary returns from builtin filters since render/return is now sufficient. Closes #9952 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-24 04:47:40 +00:00
Jeremy Kemper
a2c9c92b72 rake test aborts if tests failed. Closes #9962 [Jason Roelofs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 20:08:51 +00:00
Jeremy Kemper
8091ed5420 Disabled checkboxes don't submit a form value. Closes #9301. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 19:25:28 +00:00
Marcel Molina
c8b6b4821f Limited eager loading no longer ignores scoped :order. Closes #9561 [danger, josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 18:34:01 +00:00
Marcel Molina
6f559f871e Added tests for options to ActiveRecordHelper#form. Closes #7213 [richcollins, mikong, mislav] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 17:57:47 +00:00
Jeremy Kemper
7b42a1d0ac Assigning an instance of a foreign class to a composed_of aggregate calls an optional conversion block. Refactor and simplify composed_of implementation. Closes #6322. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 17:39:35 +00:00
Jeremy Kemper
c220e558be Assigning nil to a composed_of aggregate also sets its immediate value to nil. Closes #9843. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 17:29:42 +00:00
Jeremy Kemper
562b398fd7 Some mime type refactoring. Closes #9957 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 06:33:28 +00:00
Jeremy Kemper
28729a4829 validates_uniqueness_of behaves well with abstract superclasses. References #3833, closes #9886. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 06:18:42 +00:00
Jeremy Kemper
6a35ed16c2 Remove duplicate rjs layout check. Closes #9956 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 05:54:19 +00:00
Jeremy Kemper
2559feb539 Refactor and test boot.rb. Include tests from and closes #9834. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 05:36:52 +00:00
Jeremy Kemper
24077a1ffc Hash#to_xml handles symbol values. Closes #9954. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 00:42:16 +00:00
Jeremy Kemper
902533e6f0 Reinstate test_change_column_nullability for all adapters. Closes #9945 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 23:52:04 +00:00
Jeremy Kemper
e829e12e16 test_select_rows shouldn't depend on implicit result ordering. Closes #9898 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 23:50:12 +00:00
Jeremy Kemper
3334609ecb Expand form helper test coverage. Closes #9950 [robinjfisher] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 21:17:20 +00:00
Jeremy Kemper
79670fb975 request.parameters doesn't overwrite request.request_parameters. Closes #9949 [nullstyle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 21:10:56 +00:00
David Heinemeier Hansson
f777ff72f9 Changed before_filter halting to happen automatically on render or redirect but no longer on simply returning false [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-21 18:58:17 +00:00
Rick Olson
7042163d76 Ensure that mysql quotes table names with database names correctly. Closes #9911 [crayz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-20 21:17:31 +00:00
Rick Olson
c9fecf20ff Ensure that cookies handle array values correctly. Closes #9937 [queso] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-20 17:30:01 +00:00
Michael Koziarski
17ac677a2d typo in test name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:51:44 +00:00
Michael Koziarski
62fd6532e5 Remove more potential clashes with asset methods and resource routes. Closes #9928 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:46:41 +00:00
Michael Koziarski
3facc8578b Few more tests for Sexy Migrations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:25:23 +00:00
Michael Koziarski
637c685a42 Forgotten changelog entry 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:25:09 +00:00
Michael Koziarski
6ddde027c4 Add t.belongs_to and t.references to sexy migrations [arthurgeek] 
Test harness for Sexy Migrations. [Koz]
Closes #9775


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:09:06 +00:00
Michael Koziarski
210f7e29e2 Move all Schema creation into schema.rb for Mysql. Closes #9899 [mikong, lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 01:52:50 +00:00
Michael Koziarski
b1c3fc22c9 Rename image_path path_to_image to avoid conflicting with named routes. Closes #9924 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 00:52:55 +00:00
Jeremy Kemper
2fac5d1a8b SQL Server: test for affected row count. References #9558 [lawrence, ryepup] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 23:47:59 +00:00
Jeremy Kemper
a9f790a748 Use SecureRandom to generate unique ids, if available. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 18:25:31 +00:00
Jeremy Kemper
b98dcdec07 Merge [7832] from 1-2-stable: Correct RAILS_GEM_VERSION regexp. Use =version gem requirement instead of ~>version so you don't get surprised by a beta gem in production. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 17:28:55 +00:00
David Heinemeier Hansson
d6f49e4af1 Fixed incorrect migration number if script/generate executed outside of Rails root (closes #7080) [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 15:54:01 +00:00
David Heinemeier Hansson
34df379467 Docfix (cloases #9832) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 15:49:11 +00:00
Michael Koziarski
2833706699 Read in binary mode to make sure windows support keeps working. [lawrence] Closes #9912 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 22:50:34 +00:00
Michael Koziarski
8ed1e885b7 Use a smaller binary fixture so we don't overflow column size limitations in some commercial / legacy databases. Closes #7987 [roderickvd, lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 21:35:46 +00:00
Michael Koziarski
ac3cf43182 Raise an intelligible error message when migration aren't named correctly [bronson] Closes #9909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7957 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 21:35:19 +00:00
Jeremy Kemper
011a209174 caches_page uses a single after_filter instead of one per action. Closes #9891. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 22:24:55 +00:00
Sam Stephenson
45107ecaf8 Update Prototype to 1.6.0_rc1 and script.aculo.us to 1.8.0 preview 0. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 21:08:29 +00:00