Commit Graph

5149 Commits

Author SHA1 Message Date
Rick Olson
9d4225f129 Fixed that dispatcher preparation callbacks only run once in production mode. Mock Routes.reload so that dispatcher preparation callback tests run. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-15 23:28:51 +00:00
Jeremy Kemper
1ddaec1e68 Only change date to beginning of month if it isn't nil.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7027 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-15 01:58:32 +00:00
Jeremy Kemper
594581685e Oh please. References #8646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-14 01:59:27 +00:00
Jeremy Kemper
164a9ea4c7 Maybe passing an explicit offset mollifies CIA. References #8646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-14 01:28:00 +00:00
Jeremy Kemper
50861013c2 Improve Time and Date test coverage. Closes #8646.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-14 01:17:42 +00:00
Jeremy Kemper
17927cbddc Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, #7208, #7212.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-13 01:34:16 +00:00
Jeremy Kemper
71b77a3d6a Improve helper test coverage. Closes #7215, #7233, #7234, #7235, #7236, #7237, #7238.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-13 01:20:55 +00:00
Jeremy Kemper
c0c001839c Take advantage of Mocha support for sequenced returns. Closes #8639 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-13 00:55:11 +00:00
Jeremy Kemper
c5f00580d3 Fix precedence error in failsafe rescue. Closes #8625.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-12 16:46:25 +00:00
Jeremy Kemper
979c22444d Tolerate missing content type on multipart file uploads. Fix for Safari 3.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-12 07:44:23 +00:00
Jeremy Kemper
e4e275dde3 Fix syntax error in dispatcher than wrecked failsafe responses. Closes #8625.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 18:05:02 +00:00
Jeremy Kemper
b94f8e1d29 Remove deprecated quote methods, replaced by quote_value so quote can be used as an attribute name.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 08:06:07 +00:00
Jeremy Kemper
7858a32e1b Remove deprecated find_first and find_all.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 07:45:56 +00:00
Jeremy Kemper
800b899f96 Remove deprecated push_with_attributes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 07:15:59 +00:00
Jeremy Kemper
813e8ba93b Fix Base#inspect when not every attribute is present. Closes #8623.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 05:02:42 +00:00
Jeremy Kemper
de7a626878 Manfred had already patched the same issue. References #6946.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 01:06:04 +00:00
Jeremy Kemper
43c6d7ee95 Deprecation: remove pagination. Install the classic_pagination plugin for forward compatibility, or move to the superior will_paginate plugin. Closes #8157.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-11 00:51:11 +00:00
Jeremy Kemper
4e23e65964 Get picky about weird Ruby style.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6991 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-10 23:06:47 +00:00
Jeremy Kemper
5179b351c7 Scaffolded validation errors set the appropriate HTTP status for XML responses. Closes #8622.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6990 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-10 23:04:19 +00:00
Jeremy Kemper
fde3d9d8e4 Remove ActiveResource::Struct because it hasn't proven very useful. Creating a new ActiveResource::Base subclass is often less code and always clearer. Closes #8612.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-09 04:42:32 +00:00
Jeremy Kemper
160af194e4 Routing: improve static segment test coverage. #7117 [Kevin Clark]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-09 04:39:01 +00:00
Jeremy Kemper
a308ff0cdd Test javascript_tag. Closes #7239.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 22:20:18 +00:00
Jeremy Kemper
29ce2eb9d1 Clean up junk test. Closes #7973 [Rob Sanheim]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 22:19:15 +00:00
Tobias Lütke
bfda4cdc5a Fixed query methods on resources. [Cody Fauser]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 19:32:15 +00:00
Jeremy Kemper
7de21cc1c5 Fix typo in resources documentation. Closes #8607 [yon]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 18:00:11 +00:00
Jeremy Kemper
c9397e684c Action caching is limited to GET requests returning 200 OK status. Closes #3335.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 05:01:35 +00:00
Jeremy Kemper
cd9d1711da Missed svn adds. References #7534.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:40:12 +00:00
Jeremy Kemper
b195ed61c8 Improve Text Helper test coverage. Closes #7274.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:05:35 +00:00
Jeremy Kemper
34b94de8b8 Improve Action View test coverage. Closes #7241, #7243, #7244.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 04:00:15 +00:00
Jeremy Kemper
9b444fe73b Rollback [6961] which breaks SQLite tests. Reference #7345.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:40:05 +00:00
Jeremy Kemper
72401dcbd6 Quote db path so SQLite AR tests work on Windows. Closes #5278 [mislav@nippur.irb.hr]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:37:13 +00:00
Jeremy Kemper
bab8966064 Test periodically_call_remote with frequency. Closes #7244 [Rich Collins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-08 01:30:47 +00:00
Jeremy Kemper
271404e8b9 Register alternative template engines using ActionMailer::Base.register_template_extension('haml'). Closes #7534.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 23:42:47 +00:00
Jeremy Kemper
869a172a8a Migrations: raise if a column is duplicated. Closes #7345.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 23:25:50 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 21:35:01 +00:00
Jeremy Kemper
5600776e30 Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-06 16:52:37 +00:00
Jeremy Kemper
5dd3db8615 Resources: url_for([parent, child]) generates /parents/1/children/2 for the nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 19:10:59 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 16:51:49 +00:00
Rick Olson
ed1ed9ed97 revert [6924]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 14:09:15 +00:00
Jeremy Kemper
319107ae40 Migrations: report the number of rows affected when calling insert, update, delete, etc.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 08:21:55 +00:00
Jeremy Kemper
8d6d450303 Fixtures: correctly delete and insert fixtures in a single transaction. Closes #8553.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:37:05 +00:00
Jeremy Kemper
255b913637 Fix typo. Closes #7504 [aurelianito]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:32:08 +00:00
Jeremy Kemper
7709df5f17 Don't double-escape url_for in views. Closes #8144.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:29:19 +00:00
Jeremy Kemper
f80468c3c3 Remove junk form helper test. Closes #8416 [eric_oconnell]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:09:39 +00:00
Jeremy Kemper
673daeabca Fixtures: people(:technomancy, :josh) returns both fixtures. Closes #7880.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 03:47:02 +00:00
Jeremy Kemper
d6785e9674 Fix indentation in model generator migration template. Closes #8577 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 03:34:56 +00:00
Jeremy Kemper
6204a52fac Sexy migrations for the session_migration generator. Closes #8561.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 02:42:57 +00:00
Jeremy Kemper
1b32a305df Add Date#since, ago, beginning_of_day, and end_of_day. Date + seconds works now. Closes #8575.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-04 22:00:53 +00:00
Jeremy Kemper
4685fa0c20 String#to_time overflows to DateTime. Add String#to_datetime. Closes #8572.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-04 19:49:13 +00:00
Jeremy Kemper
601778e38a Date.yesterday and .tomorrow. Closes #8571.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-04 18:14:42 +00:00