github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
10,789 Commits 34 Branches 105 Tags
a8a336cbfc55f91dc8befaad2425ff42085a1a4f
Commit Graph

10789 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yehuda Katz
a8a336cbfc Revert "ruby 1.9 friendly secure_compare" because it breaks CI and Sam Ruby's suite 
This reverts commit 5de75398c4.
 2009-09-12 14:35:03 -05:00
Yehuda Katz
7152a4e9a6 Add per-controller middleware 2009-09-12 13:51:15 -05:00
sdsykes
3180619c0d Fix habtm associations when using multiple databases 
[#3128]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-12 02:57:29 -07:00
Jeremy Kemper
8682d76cc9 Revert "Allow frameworks to be required by their gem name" 
This has just been confusing. Better to educate than band-aid.

This reverts commit 18a24274ec.
Originally from http://dev.rubyonrails.org/ticket/8845 [drnic]
 2009-09-12 02:41:01 -07:00
Akira Matsuda
3ce16b4c5f Ruby 1.9 compat: Avoid using the return value of FileUtils.mkdir_p, as it does not return a String but an Array in Ruby 1.9 
[#2018 state:committed milestone:2.3.5]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-11 19:20:57 -07:00
Akira Matsuda
0990a13500 Ensure validation errors to be ordered in declared order 
[#2301 state:committed milestone:2.3.5]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-11 18:52:22 -07:00
Akira Matsuda
68b2b730e4 Fix default_error_messages back to the original message 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-11 18:34:12 -07:00
Jakub Kuźma
b22c951e7a ruby 1.9 friendly secure_compare 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-09-12 12:48:34 +12:00
Shugo Maeda
ff2eb2d808 Removed the copyright notice not to show it in the result of 'ri ActiveRecord'. 2009-09-11 15:33:20 -07:00
Joshua Peek
72721c6725 Add gem load paths after loading environment 2009-09-11 10:31:31 -05:00
Nathaniel Talbott
f024aabee3 Fix filtering parameters when there are Fixnum or other un-dupable values. 
[#3184 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-10 18:53:50 -07:00
Beau Harrington
38d65b03d6 Remove redundant checks for valid character regexp in ActiveSupport::Multibyte#clean and #verify. 
[#3181 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-10 17:36:54 -07:00
José Valim
af5b12c64c Fix callbacks on ActionPack. 
Signed-off-by: Yehuda Katz <wycats@gmail.com>
 2009-09-08 10:28:28 -07:00
José Valim
2ea1d684d9 Refactor new callbacks and AR implementation. 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-08 10:26:39 -05:00
José Valim
4f37b97033 Changed ActiveRecord to use new callbacks and speed up observers by only notifying events that are actually being consumed. 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-08 10:26:39 -05:00
Jeremy Kemper
aeab739bd5 Ruby 1.9: fix MessageVerifier#secure_compare 2009-09-08 14:05:33 +09:00
Joshua Peek
47aebacd51 Please 1.8.6 CI 2009-09-07 21:56:53 -05:00
Joshua Peek
b7c1fbc050 Start running AS isolated tests on CI 2009-09-07 21:13:25 -05:00
Joshua Peek
1a0f822037 Use draw/connect mapper api instead of directly using add_named_route 2009-09-06 23:21:04 -05:00
Joshua Peek
314e18aba2 Need to reset session for AR session tests after altering the route set 2009-09-06 23:09:47 -05:00
Joshua Peek
2ae84e04aa Add fake controllers for url rewriter tests 2009-09-06 23:02:55 -05:00
Joshua Peek
c531bd6665 Cleanup hacky routing with controller_path in url helper tests. This doesn't work in real life anyway. 2009-09-06 22:29:29 -05:00
Joshua Peek
ab8aac09d6 Need to reset session in internal integration tests after altering the route set 2009-09-06 22:01:58 -05:00
Joshua Peek
9f47f8d892 Fix isolated running of AddressesTest 2009-09-06 21:42:05 -05:00
Joshua Peek
1c02fc295d Fix isolated running of ActionPackAssertionTest 2009-09-06 21:19:29 -05:00
Joshua Peek
c3accd7ded Fix failing isolated routing test 2009-09-05 19:39:33 -05:00
Joshua Peek
59d1b23ea1 Fix failing ARes isolated tests 2009-09-05 19:24:43 -05:00
Joshua Peek
6dc9ad80e6 Fix warnings in AMo 2009-09-05 19:10:21 -05:00
Joshua Peek
c6e0923245 Fix failing AMo isolated tests 2009-09-05 18:54:19 -05:00
Joshua Peek
fe68cf2784 Fix failing AS isolated tests 2009-09-05 18:31:10 -05:00
Joshua Peek
ca2f2d1800 Turn warnings on for AS isolated tests 2009-09-05 18:24:58 -05:00
Michael Koziarski
87c93da440 Fix a messed up merge commit 2009-09-04 14:28:32 +12:00
Michael Koziarski
b16e0c9223 Clean tag attributes before passing through the escape_once logic. 
Addresses CVE-2009-3009
 2009-09-04 09:25:38 +12:00
Michael Koziarski
9a73630d93 Add verify and clean methods to ActiveSupport::Multibyte. 
When accepting character input from outside of your application you can't
blindly trust that all strings are properly encoded. With these methods
you can check incoming strings and clean them up if necessary.

Signed-off-by: Michael Koziarski <michael@koziarski.com>

Conflicts:

	activesupport/lib/active_support/multibyte.rb
 2009-09-04 09:25:38 +12:00
Coda Hale
5e6dab8b34 Fix timing attack vulnerability in ActiveSupport::MessageVerifier. 
Use a constant-time comparison algorithm to compare the candidate HMAC with the calculated HMAC to prevent leaking information about the calculated HMAC.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-09-04 09:25:38 +12:00
Jay Pignata
bd97c3044a CookieStore should not be derived from Hash - reverting [#2268 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-03 15:15:15 -05:00
Yehuda Katz + Carl Lerche
487ee41d2f Test for previous commit (we wrote it first, I swear) 2009-09-03 12:58:43 -07:00
Yehuda Katz + Carl Lerche
119793a4c1 Replace :formats => ["*/*"] with the default formats set 2009-09-03 12:52:53 -07:00
Yehuda Katz + Carl Lerche
e3744166ec Refactor ActionController to use find_template and template_exists? 2009-09-03 12:52:53 -07:00
Sam Pohlenz
4b6321efa9 Don't raise exceptions for missing javascript_include_tag or stylesheet_link_tag sources unless the :cache or :concat options are given. [#2738 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-03 14:01:01 -05:00
Yehuda Katz + Carl Lerche
f61dc0ef65 Remove a useless method in the fixture template class 2009-09-03 11:40:03 -07:00
Yehuda Katz + Carl Lerche
f3fc5c4b5f Refactor ActionView::Resolver 2009-09-03 11:18:57 -07:00
Yehuda Katz + Carl Lerche
dd34691b8d Extract finding the template in AC to it's own method 2009-09-03 11:18:56 -07:00
Jay Pignata
e0f1a7dc19 If session_options[:id] is requested when using CookieStore, unmarshal the session to access it [#2268 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-03 11:50:01 -05:00
Carl Lerche
f416f9f0ae Vendor the latest version of the bundler 2009-09-03 09:31:04 -07:00
Carl Lerche
e3f5fd536e Add ActiveModel's ./pkg and ./doc to .gitignore 2009-09-03 08:59:26 -07:00
Jeremy Kemper
3b6a9a020e Revert "Assert primary key does not exist in habtm when the association is defined, instead of doing that everytime a record is inserted." 
Test failures on PostgreSQL.

[#3128 state:open]

This reverts commit da636809da.
 2009-09-02 13:55:47 -07:00
Joshua Peek
723a47bfb3 Kill AMo observing wrap_with_notifications since ARes was only using it 2009-09-02 11:44:36 -05:00
Jeffrey Hardy
e870e24887 Don't try to log protected attribute removal if there's no logger defined [#3135 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-02 11:21:20 -05:00
Jeffrey Hardy
41b3c912b7 Remove ClassInheritableAttributes test case, already covered by ActiveSupport [#3114 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-09-02 11:21:20 -05:00