github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,613 Commits 34 Branches 105 Tags
a8ca7c051de7ae18d8e7091c1517700e933e8dfd
Commit Graph

9613 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Frederick Cheung
a8ca7c051d exorcise we/us/ours 2008-12-31 18:06:23 +00:00
Frederick Cheung
1f3db5a0b0 clarify option value 2008-12-31 17:55:57 +00:00
Frederick Cheung
8f9f3e6e29 fix mistakes from merge 2008-12-31 17:18:12 +00:00
Frederick Cheung
66b88129cc Tidy up discussion of second hash passed to form_tag/html options for form_for 2008-12-31 17:13:12 +00:00
Frederick Cheung
6c8974e5db Waffle about the difference between text_field and f.text_field 2008-12-31 17:13:11 +00:00
Frederick Cheung
7156d58381 Add warning 2008-12-31 17:13:11 +00:00
Frederick Cheung
092b1d8433 Stylistic tweak 2008-12-31 17:13:11 +00:00
Frederick Cheung
73ebb26ece describe foo_tag versus foo 2008-12-31 17:13:11 +00:00
Frederick Cheung
d6c38f15d2 Describe options_from_collection_for_select 2008-12-31 17:13:11 +00:00
Frederick Cheung
b3f265ac2e fix typo 2008-12-31 17:06:00 +00:00
Pratik Naik
2a37726958 Add validations guide to index 2008-12-31 15:28:16 +00:00
Xavier Noria
6260dee015 This example seems unnecessary. Note that the examples of form helpers depict just their traditional usage. The documentation of form_for is the one that makes the link with form builders. On the other hand, people are expected to know what's a hidden field in HTML forms. 2008-12-31 01:19:59 +01:00
bparanj
3dae667d8f Simple example added for using hidden_field tag used in a form 2008-12-30 15:00:35 -08:00
Xavier Noria
9c3c88a894 document edge cases in AR calculations, and wrap some comments 2008-12-30 02:45:23 +01:00
Chris Kampmeier
477d37a0fb Rewrite ActiveRecord::Base#delete docs to remove false information about callbacks, mention return value, and improve clarity 2008-12-29 03:05:05 -05:00
Ryan Bigg
377e72c700 James B. Byrne's suggestions 2008-12-29 14:19:09 +10:30
Daniel Schierbeck
bf95e5a802 Made code segments and method names have fixed-width fonts 2008-12-29 03:00:22 +01:00
CassioMarques
a1f22f520b Added missing images for the AR validations and callbacks guide 2008-12-28 22:56:51 -02:00
CassioMarques
006a640fc4 Fixed error message that was written in portuguese instead of english... 2008-12-28 21:49:33 -02:00
CassioMarques
495c7109fe New content for the AR Validations and Callbacks guide: Added a section about using error messages in view templates, added text about custom validation helpers 2008-12-28 21:27:31 -02:00
Pratik Naik
d6c2285e31 Merge commit 'mainstream/master' 2008-12-28 20:00:29 +00:00
Xavier Noria
a2270ef259 Inline code comments for class_eval/module_eval [#1657 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-28 19:49:28 +00:00
Mike Gunderloy
1fb275541a Ensure template runner tests don't depend on hash ordering [#1654 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-28 17:49:58 +00:00
Pratik Naik
fec0ea9d6d Request#env['SERVER_NAME'] does not contain port number 2008-12-28 17:07:13 +00:00
Aaron Quint
c0c79f779c Use SimpleLogger for Rails::TemplateRunner outside of the Generator context [#1618 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-28 16:49:19 +00:00
Pratik Naik
aaea12c497 Revert inline docs 2008-12-28 16:01:38 +00:00
Andrew Timberlake
297276b99c Added documentation to gsub_file method 2008-12-28 01:25:23 -05:00
Chris Kampmeier
1ea13fce1a Rewrite ActiveRecord::Base.delete docs for clarity, and mention return value 2008-12-27 18:03:19 -05:00
Mike Gunderloy
fa6218c923 Regenerate Guides HTML 2008-12-27 16:16:49 -06:00
Aaron Quint
9fd35fc2d8 Adding test coverage and better logging to Rails::TemplateRunner [#1618 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-27 21:03:44 +00:00
Xavier Noria
8b1d69d197 adds more inline docs for dynamically created methods in Active Support 2008-12-27 20:49:28 +01:00
Xavier Noria
6adfbf2844 adds inline docs for dynamically created methods in Active Record 2008-12-27 20:25:41 +01:00
Xavier Noria
0ba8dcb444 adds inline docs for dynamically created methods in Action Pack 2008-12-27 20:06:45 +01:00
Xavier Noria
8cabcbd272 adds inline docs for dynamically created methods in Active Support 2008-12-27 19:28:32 +01:00
Yaroslav Markin
fdaa9ed033 Fix ActionPack build on Windows: we really should not test anything regarding symlinks on Windows. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-27 17:33:13 +00:00
Mike Gunderloy
711512a42b More formatting cleanup for testing guide 2008-12-27 09:34:56 -06:00
Mike Gunderloy
930b20678e Fix typo in layout and rendering guide 2008-12-27 09:07:55 -06:00
Mike Gunderloy
6d0639c95e Merge patch on subtemplates into layouts & rendering guide 2008-12-27 09:05:37 -06:00
Mike Gunderloy
e51b8e2036 Add information on new rendering syntax to layouts + rendering guide 2008-12-27 08:52:32 -06:00
Yaroslav Markin
28347d889b Refactor ActiveRecord::Base#new_record? [#1647 state:committed] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2008-12-27 15:25:39 +01:00
Mike Gunderloy
d65a24c49e Formatting changes on index and testing guide 2008-12-27 08:23:33 -06:00
Mike Gunderloy
8584922705 Add version links to index 2008-12-27 08:03:36 -06:00
Yaroslav Markin
6e98adfc8e ActiveRecord::Base#new_record? now returns false for existing records (was nil) [#1219 state:committed] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2008-12-27 14:36:11 +01:00
Yaroslav Markin
fa0502494e It is better to have this commented out to let locale-checking scripts perform better (rails-i18n) 2008-12-27 13:27:54 +03:00
Yehuda Katz
4f043a4838 More optimizations on respond_to after a profile and benching: 
App with simple respond_to:
  def index
    respond_to do |format|
      format.html
      format.xml
      format.json
    end
  end

On JRuby (after complete hotspot warmup) -- 8% improvement:
  550 requests per second after this commit
  510 requests per second with old method_missing technique

On MRI (8% improvement):
  430 requests per second after this commit
  400 requests per second with old method_missing technique
 2008-12-27 00:06:57 -08:00
Aditya Chadha
dce642f22a Fixed typo 2008-12-27 02:50:30 -05:00
Pratik Naik
f4f8923cf0 Merge commit 'fred/pullable' 2008-12-26 21:56:21 +00:00
Yehuda Katz
6dc1288111 Remove method missing use in respond_to 2008-12-26 13:41:02 -08:00
Chris Kampmeier
d49fa21a03 ActionController::Request docs: fix reference to nonexistent ACCEPTED_HTTP_METHODS constant, clean up #request_method and #method 2008-12-26 16:32:14 -05:00
Frederick Cheung
5cebe69e74 Preload uses exclusive scope [#643 state:resolved] 
With self referential associations, the scope for the the top level should not affect fetching of associations, for example
when doing

Person.male.find :all, :include => :friends

we should load all of the friends for each male, not just the male friends.
 2008-12-26 18:25:55 +00:00