lest
a985309abc
fix warning in tests when using render_erb helper
2011-11-30 18:05:23 +03:00
lest
e975fe710a
test helpers in erb using erb
2011-11-30 17:38:09 +03:00
Jon Leighton
271308cb96
Merge pull request #1915 from bogdan/active_record_map
...
ActiveRecord::Base.map method for direct select by single column
2011-11-30 01:41:09 -08:00
Bogdan Gusiev
a382d60f6a
ActiveRecord::Relation#pluck method
2011-11-30 11:03:00 +02:00
José Valim
38ab982cff
Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time a before callback halts.
2011-11-30 09:53:09 +01:00
José Valim
a6ee246e5c
Update sprockets which theoretically fixes the regression we have seen.
2011-11-30 09:53:09 +01:00
José Valim
6093d88ed8
Fixes for using action view template in isolation.
2011-11-30 09:53:09 +01:00
Aaron Patterson
d9c2882077
Module#synchronize is deprecated with no replacement. Please use monitor from ruby's standard library.
2011-11-29 15:40:46 -08:00
Aaron Patterson
c606fe2c6f
push synchronization in to each method. Reduces method calls and makes
...
it clear which methods are synchronized.
2011-11-29 15:30:04 -08:00
Aaron Patterson
0e2477b602
Automatic closure of connections in threads is deprecated. For example
...
the following code is deprecated:
Thread.new { Post.find(1) }.join
It should be changed to close the database connection at the end of
the thread:
Thread.new {
Post.find(1)
Post.connection.close
}.join
Only people who spawn threads in their application code need to worry
about this change.
2011-11-29 15:04:41 -08:00
Aaron Patterson
29d2040b29
AbstractAdapter#close can be called to add the connection back to the
...
pool.
2011-11-29 14:40:37 -08:00
Aaron Patterson
ce3d8d646a
Start implementing @reserved_connections in terms of connection leases.
2011-11-29 14:02:59 -08:00
Aaron Patterson
5725e397fe
Rename checked_out to more descriptive active_connections
2011-11-29 14:02:59 -08:00
Aaron Patterson
b72b477c37
Use connection lease to determine "checked_out" connections
2011-11-29 14:02:59 -08:00
Aaron Patterson
f866f66b30
expire will set in_use to false
2011-11-29 14:02:58 -08:00
Aaron Patterson
79306de791
last_use is set on connection lease
2011-11-29 14:02:58 -08:00
Aaron Patterson
134cc8f939
Leased connections return false on second lease
2011-11-29 14:02:58 -08:00
Aaron Patterson
9bf8bf82b9
Adapters keep in_use flag when leased
2011-11-29 14:02:58 -08:00
Aaron Patterson
7837574e5b
namespace the adapter test
2011-11-29 14:02:58 -08:00
Jon Leighton
3da5fba56a
Fix ruby 1.8 compat. const_defined? only takes a second arg on 1.9.
2011-11-29 20:43:05 +00:00
Jon Leighton
8df787d428
Deprecated define_attr_method in ActiveModel::AttributeMethods
...
This only existed to support methods like `set_table_name` in Active
Record, which are themselves being deprecated.
2011-11-29 20:13:37 +00:00
Jon Leighton
f3c84dc316
Deprecate set_locking_column in favour of self.locking_column=
2011-11-29 20:13:37 +00:00
Jon Leighton
1a474cc8e4
Deprecate set_primary_key in favour of self.primary_key=
2011-11-29 20:13:37 +00:00
Jon Leighton
4aad289428
Make sure the original_foo accessor still works (but deprecated) if we are using self.foo=
2011-11-29 20:13:37 +00:00
Jon Leighton
e51ecfaaa3
extract method
2011-11-29 20:13:37 +00:00
Jon Leighton
7af719e81c
Deprecate set_sequence_name in favour of self.sequence_name=
2011-11-29 20:13:37 +00:00
Jon Leighton
fd7ca98bb6
Add tests for set_sequence_name etc
2011-11-29 20:13:36 +00:00
Jon Leighton
34609d67b4
Deprecate set_inheritance_column in favour of self.inheritance_column=
2011-11-29 20:13:36 +00:00
Jon Leighton
0b72a04d0c
Deprecate set_table_name in favour of self.table_name= or defining your own method.
2011-11-29 20:13:36 +00:00
Aaron Patterson
f73f53455a
respond_to? information of AR is not the responsibility of the spec
...
resolver.
2011-11-29 11:48:55 -08:00
Jon Leighton
2169603385
Merge pull request #3636 from joshsusser/master
...
association methods are now generated in modules
2011-11-29 10:09:42 -08:00
Josh Susser
c347b3c06c
don't change class definition in test case
2011-11-29 09:14:21 -08:00
Jon Leighton
d534c8fbe2
Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the connection adapter)
2011-11-29 12:47:54 +00:00
Jon Leighton
1defb6adb8
Fix schema_cache_test.rb for sqlite3_mem
2011-11-29 12:29:42 +00:00
Vijay Dev
6e399acaa8
Merge pull request #3797 from HeeL/test
...
splited a long line to shorter ones
2011-11-29 02:23:06 -08:00
Sergey Parizhskiy
69d56cb933
splited a long line to shorter ones
2011-11-29 11:50:02 +02:00
Vijay Dev
42d70d9852
Merge pull request #3790 from masterkain/patch-1
...
Fix typo in AS::TaggedLogging
2011-11-29 00:30:00 -08:00
José Valim
913c42a6a9
Merge pull request #3793 from marcandre/asset_host
...
Handle correctly optional parameters for callable asset_host.
2011-11-28 23:56:42 -08:00
Marc-Andre Lafortune
d3bc12b27f
Handle correctly optional parameters for callable asset_host.
2011-11-29 02:01:18 -05:00
Claudio Poli
2a76f33b51
Fix typo in AS::TaggedLogging
2011-11-29 00:26:58 +01:00
Aaron Patterson
52a9884ce4
remove unused instance variable
2011-11-28 15:23:26 -08:00
Aaron Patterson
beff819a4d
just check in all connections
2011-11-28 15:23:26 -08:00
Aaron Patterson
884a04007f
remove useless class_eval
2011-11-28 15:23:25 -08:00
Aaron Patterson
dde2113867
Move connection resoluion logic to it's own testable class.
2011-11-28 15:23:25 -08:00
Aaron Patterson
30f7c59e90
clean up string => hash conversion for connection pool
2011-11-28 15:23:25 -08:00
Aaron Patterson
ffb218c750
pools are 1:1 with spec now rather than 1:1 with class
2011-11-28 15:23:25 -08:00
Aaron Patterson
2a9a8ad4df
break establish_connection to smaller methods
2011-11-28 15:23:24 -08:00
Jakub Kuźma
d1afd98746
added information about callbacks created by autosave association ( #3639 )
2011-11-28 19:37:00 +01:00
Aaron Patterson
ba0b3eee14
Merge pull request #3768 from janv/master
...
Test and fix for Issue 3450
2011-11-28 09:35:43 -08:00
José Valim
a0c61c81d7
Merge pull request #3785 from lest/backtrace-cleaner-env
...
Put backtrace_cleaner to env
2011-11-28 08:43:14 -08:00
