Craig Demyanovich
aa17716688
Callbacks fire before notifying observers [ #230 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-06-03 13:38:00 -05:00
Joshua Peek
a977f3e88e
Fixed ambiguous first argument warning in ArrayExtTest.
2008-06-03 13:35:03 -05:00
Joshua Peek
c08547d226
Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ActiveSupport [ #238 state:resolved]
2008-06-03 13:32:53 -05:00
David Heinemeier Hansson
da91450e68
Added tests [ #279 state:resolved] (Nicholas Schlueter)
2008-06-02 22:05:27 -05:00
David Heinemeier Hansson
64fea9c45c
Fixed Date#end_of_quarter to not blow up on May 31st [ #289 state:resolved] (Danger)
2008-06-02 22:02:43 -05:00
David Heinemeier Hansson
e7a305f08d
Fixed Base#exists? to check status code as integer [ #299 state:resolved] (Wes Oldenbeuving)
2008-06-02 21:58:42 -05:00
David Heinemeier Hansson
442d2f1032
Fixed that RailsInfoController wasnt considering all requests local in development mode (Edgard Castro) [ #310 state:resolved]
2008-06-02 21:55:42 -05:00
Joshua Peek
92050f6c6f
Ensure Rack processor reads CGI output_cookies for the session cookie.
2008-06-02 21:02:51 -05:00
David Heinemeier Hansson
29641ff05a
Fixed the brokeness from 952ec79bec
2008-06-02 19:00:25 -05:00
David Heinemeier Hansson
4b4aa8f6e0
AR can be disabled, new_rails_defaults.rb should check [ #303 state:resolved] (Jesper Hvirring Henriksen)
2008-06-02 18:43:08 -05:00
David Heinemeier Hansson
a855ab89b7
Added a test for Gzip
2008-06-02 17:42:10 -05:00
Pratik Naik
bd75a722a2
Ensure AR#sum result is typecasted properly
2008-06-02 20:41:11 +01:00
Cheah Chu Yeow
952ec79bec
Faster Hash#slice that doesn't use Enumerable#include?.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2008-06-02 11:47:15 -07:00
Joshua Peek
714d42d1a6
Fixed initializer tests by stubbing out gems dependencies check.
2008-06-02 10:40:01 -05:00
Joshua Peek
185fe2e9cc
In 9c4f003, gem installation quotes versions. Do the same for unpack and update tests to reflect the change.
2008-06-02 09:54:36 -05:00
Marcos Tapajos
14a65cd982
Fixed changelog merge.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-06-02 09:47:53 -05:00
Jonathan Viney
4210d85a3f
Ensure Associations#sum returns 0 when no rows are returned. [ #295 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-06-02 12:50:44 +01:00
Joshua Peek
a980eb8c77
Added Rack middleware to handle static files.
2008-06-01 13:18:31 -07:00
Ezra Zygmuntowicz
06cb20708b
Added Rack processor
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-06-01 11:25:11 -07:00
David Heinemeier Hansson
3282bf3b50
Added SQL escaping for :limit and :offset in MySQL [Jonathan Wiess]
2008-06-01 09:15:11 -07:00
rick
71528b1825
Previously we only added the "lib" subdirectory to the load path when
...
setting up gem dependencies for frozen gems. Now we add the "ext"
subdirectory as well for those gems which have compiled C extensions
as well. [Wincent Colaiuta]
[#268 state:resolved]
2008-05-31 17:22:16 -07:00
rick
6a975d6ca2
fix changelog conflict
2008-05-31 17:15:24 -07:00
rick
72483c0d4c
Add ActiveRecord::Base.sti_name that checks ActiveRecord::Base#store_full_sti_class? and returns either the full or demodulized name. [rick] [ #114 state:resolved]
2008-05-31 17:13:11 -07:00
Jeremy Kemper
ea03b0885c
revert mysql test credential change
2008-05-31 17:07:44 -07:00
David Heinemeier Hansson
cb59c93de0
Merge branch 'master' of git@github.com:rails/rails
2008-05-31 17:03:40 -07:00
David Heinemeier Hansson
f9db7695fe
Making ready for release of 2.1
2008-05-31 17:03:03 -07:00
Michael Koziarski
ef21e01333
Remove dead code, and the tests for it.
2008-05-31 16:59:03 -07:00
John D. Hume
f6e921f956
Substitute value into validates_format_of message
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2008-05-31 16:59:03 -07:00
David Heinemeier Hansson
ef0ea782b1
Added SQL escaping for :limit and :offset [ #288 state:closed] (Aaron Bedra, Steven Bristol, Jonathan Wiess)
2008-05-31 16:57:46 -07:00
rick
a6e7908327
fix doc typos
2008-05-31 16:46:47 -07:00
Dmitriy Timokhin
224c8e6afb
Expose GemPlugin load_paths so they can be added to Dependencies.load_paths. Also use full_gem_path as root of GemPlugin to make things compatible. [ #213 state:resolved]
2008-05-31 16:46:13 -07:00
rick
d5bcff172b
Consolidate error messages for missing gems, and skip them when running rake gems:* tasks. [rick]
2008-05-31 16:36:34 -07:00
rick
2506e5c9a7
Merge branch 'master' of git@github.com:rails/rails
2008-05-31 15:59:01 -07:00
rick
9c4f00350a
fix Gem installation command with versions
2008-05-31 15:58:08 -07:00
Tim Morgan
fb89d7fa6d
Run gem install as external command. [ #210 state:resolved]
2008-05-31 15:57:03 -07:00
David Heinemeier Hansson
f32bceeee1
Merge branch 'master' of git@github.com:rails/rails
2008-05-31 15:51:28 -07:00
David Heinemeier Hansson
9b75483bf3
Added better error message for when the class name is already used (and dont show suggestions if there are none)
2008-05-31 15:51:01 -07:00
Jeremy Kemper
7391f7728d
Ruby 1.8.7 compat: work around broken DelegateClass#respond_to?
2008-05-31 15:36:32 -07:00
Joshua Peek
3a9775076f
Removed suggestion for turning off partial updates.
2008-05-31 15:34:01 -07:00
Michael Koziarski
0abf0da001
Don't provide the password with dbconsole unless explicitly opted in.
...
Some operating system configurations allow other users to view your process list
or environmental variables. This option should not be used on shared hosts.
http://dev.mysql.com/doc/refman/5.0/en/password-security.html
http://www.postgresql.org/docs/8.3/static/libpq-envars.html
2008-05-31 15:30:26 -07:00
Jeremy Kemper
4e4bcb4c6b
Ruby 1.8.7 compat: TimeWithZone# and Chars#respond_to? pass along the include_private argument
2008-05-31 14:55:02 -07:00
rick
2243ffd1ff
Merge branch 'master' of git@github.com:rails/rails
2008-05-31 13:39:58 -07:00
Tom Ward
77e45352e7
Fixed Dependencies so load errors are not masked behind a 'Expected x.rb to define X' message when mechanism is not set to :load [ #87 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-05-31 13:33:38 -07:00
rick
fbd901e8d6
Merge branch 'master' of git@github.com:technoweenie/rails
2008-05-31 13:32:10 -07:00
Tim Harper
0580b31b36
belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not.
...
fixes the following scenarios:
* I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated.
* I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well.
[#191 state:closed]
2008-05-31 13:27:25 -07:00
Tim Harper
aef47dcf93
belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not.
...
fixes the following scenarios:
* I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated.
* I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well.
2008-05-31 13:23:00 -07:00
Ryan Bates
f7015336f6
Fix default nil tests for MySQL 5.0.51 [ #192 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-05-31 12:36:07 -07:00
Jeremy Kemper
03ba5d7b51
Ensure query assertion counts are the same when partial updates are enabled
2008-05-30 04:36:00 -07:00
Jeremy Kemper
2ce1be3ac4
Enable partial updates by default
2008-05-30 04:16:57 -07:00
Jeremy Kemper
946f51449a
Require ruby-prof 0.6.1 or later. Use resume/pause to omit extraneous machinery from profile.
2008-05-30 02:39:00 -07:00
