17377 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Aaron Patterson	ad4ef4226f	avoid const lookup. we know what these constants are in advance	2010-07-19 10:31:24 -07:00
Aaron Patterson	dd4e81df86	avoid call to Array#first	2010-07-19 10:21:45 -07:00
Łukasz Strzałkowski	bd4b3d8b2f	Added missing require of remove_method	2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski	661fd98aad	Make use of redefine_method, removed some more redefining warnings	2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski	7637b7184a	Test for behaviour of befeore_type_cast when operating on datetime colmun	2010-07-19 23:44:49 +08:00
Łukasz Strzałkowski	010eda2eb5	Removed warnings about method redefining	2010-07-19 23:44:48 +08:00
Łukasz Strzałkowski	fc71d59219	Introduced redefine_method	2010-07-19 23:44:46 +08:00
Łukasz Strzałkowski	247886e1b4	Removed warnings when a variable is shadowed	2010-07-19 23:44:45 +08:00
José Valim	b22c11fa53	Add missing entries and tidy up CHANGELOG.	2010-07-19 15:14:26 +02:00
José Valim	70f7ba3e3b	There is absolutely no need to use __send__ here.	2010-07-19 14:56:09 +02:00
José Valim	ab6ff85906	No need to create a new module in the previous commit.	2010-07-19 14:50:38 +02:00
Neeraj Singh	33c5689e2d	Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError ... [#2034 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-19 14:50:38 +02:00
Aaron Patterson	ad8f4dfc50	avoid proc activation every time a log message is made	2010-07-18 17:37:39 -07:00
Aaron Patterson	8cbb89c0bf	subscriber does not need to be a block, but an object that responds to #call	2010-07-18 17:20:20 -07:00
Aaron Patterson	b2c8a5fd3e	Notifier API == Fanout API, so replace Notifier with Fanout as they quack the same	2010-07-18 16:49:29 -07:00
Aaron Patterson	234b969946	tap the subscriber for easier return value	2010-07-18 15:39:32 -07:00
Aaron Patterson	2cbef6996c	bind method is not needed, so goodbye! <3 <3 <3	2010-07-18 15:37:23 -07:00
Santiago Pastorino	3870366092	Float comparison adjustment ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 19:28:46 +02:00
Neeraj Singh	0fce4ae57f	expected value should come first in assert_equal ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 15:13:38 +02:00
Neeraj Singh	6caf943ace	primary_keys_test reads better than pk_test ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 15:13:29 +02:00
Neeraj Singh	b58e1c52f7	fixing typo ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 15:13:21 +02:00
Neeraj Singh	df6aa8e246	removing extra whitespaces ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 15:13:14 +02:00
José Valim	291adcd588	Set session options id to nil is respected and cancels lazy loading.	2010-07-18 12:51:03 +02:00
Ivan Torres	cdfa11409c	select :include_blank or :prompt should return escaped string [#5099 state:resolved] ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 11:32:00 +02:00
Neeraj Singh	1f499e6d4c	fixing the ternary operation where the logic is very confusing. ... [#5136 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 11:31:54 +02:00
Subba Rao Pasupuleti	4a0d7c1a43	save on parent should not cascade to child unless child changed [#3353 state:resolved] ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-07-18 11:31:29 +02:00
José Valim	e210895ba9	Avoid uneeded queries in session stores if sid is not given.	2010-07-18 11:02:08 +02:00
José Valim	fa98eca75b	Add console hook to force ActiveRecord::Base to be loaded when console starts avoiding reference loops.	2010-07-18 11:02:07 +02:00
Aaron Patterson	cfca55949f	convert duration to an attr_reader	2010-07-17 16:03:56 -07:00
Santiago Pastorino	cebe5c2fac	It's not needed to initialize the attr when calling mattr_writer	2010-07-18 06:06:58 +08:00
Nick Quaranto	7aec9f9c02	Removing ActionDispatch::Http::FilterParameters#fitered_parameters alias	2010-07-18 06:04:55 +08:00
Aaron Patterson	606d8fdfc8	drained? is never called	2010-07-17 14:45:59 -07:00
Aaron Patterson	fa73e777a1	private method is not needed	2010-07-17 14:44:29 -07:00
Aaron Patterson	4226c93779	removing Binding class	2010-07-17 14:35:44 -07:00
Aaron Patterson	9c80f5b391	use === to avoid regular expression creation, and speed up string comparison	2010-07-17 13:14:38 -07:00
Xavier Noria	631b9564d2	Merge remote branch 'docrails/master'	2010-07-17 20:00:48 +02:00
Xavier Noria	caddee253c	new guide: API Documentation Guidelines, ported and revised from the docrails github wiki	2010-07-17 19:42:44 +02:00
José Valim	c6e2058637	Add skip_eager_load!, skip_autoload! and friends to path objects.	2010-07-17 09:55:11 +02:00
Santiago Pastorino	38f1ea8fe2	Makes test use the new config.action_view.javascript_expansions[:defaults] initialization syntax	2010-07-17 05:53:18 +08:00
Aaron Patterson	42be67e8d4	unfactoring clear_stale_cached_connections!	2010-07-16 14:48:50 -07:00
Aaron Patterson	8d17f53318	adding a test for clearing stale connections	2010-07-16 14:39:40 -07:00
Aaron Patterson	7ba54ff711	fixing test file name	2010-07-16 13:54:14 -07:00
Aaron Patterson	2244bb0013	fixing whitespace errors	2010-07-16 13:50:58 -07:00
Xavier Noria	ef165b355d	minor pass to generated code in application.rb related to :defaults	2010-07-16 21:54:13 +02:00
Aaron Patterson	04ef434b21	only test for existence of +pool+ once	2010-07-16 11:44:29 -07:00
Aaron Patterson	b952470cc2	use an attr_reader for performance	2010-07-16 11:44:29 -07:00
Santiago Pastorino	79d9e0f155	Makes this test don't trust on the speed of execution	2010-07-17 02:39:26 +08:00
Santiago Pastorino	114fa4d431	Adds application.js when app is generated with -J and clear javascript_expansions[:defaults]	2010-07-17 01:59:51 +08:00
Nick Sieger	ea7f1fb026	Don't rely on implementation-specific order-dependence of array comparisons in unit tests ... Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>	2010-07-17 01:59:51 +08:00
Santiago Pastorino	041e47b326	Explain how to change javascript default files	2010-07-17 01:59:50 +08:00