github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,377 Commits 34 Branches 105 Tags
ad4ef4226fd5d47252d30effa41a3ab2f55dbc8d
Commit Graph

1626 Commits

Author SHA1 Message Date
Neeraj Singh
33c5689e2d Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError 
[#2034 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-19 14:50:38 +02:00
Jeremy Kemper
81f398b804 Fix setting helpers_path to a string or pathname 2010-07-07 12:03:08 -07:00
Patrik Stenmark
7f7480f6fc Adds tests for content negotiation change introduced in dc5300adb6 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-04 11:17:16 -07:00
Piotr Sarnacki
f7ba614c2d Unify routes naming by renaming router to routes 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-02 01:51:03 +02:00
Santiago Pastorino
824da60ae8 Move Rails module to abstract_unit to make test in isolation work 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-28 01:26:07 +02:00
Andrew White
bba19603c2 URL fragments should not have safe characters escaped. Ref: Appendix A, http://tools.ietf.org/rfc/rfc3986.txt 
[#4762 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-25 18:05:40 -07:00
José Valim
a12b76b09e Just reading flash messages should not create a session if one does not exist yet. 2010-06-25 09:36:26 +02:00
José Valim
6788db824a Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] 2010-06-24 13:23:43 +02:00
knapo
995b1a243c Fix controller_name for non default controller paths [#4901 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 01:37:52 +02:00
Jan De Poorter
96f5e59a26 Make sure a namespaced <%= render form %> still renders the _form partial [#4784 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-20 00:58:10 +02:00
Andrew White
ed3f042e99 Make polymorphic_url and scaffolding work with uncountable resources [#3930 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-20 00:15:41 +02:00
Xavier Noria
f17159b029 edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord" 2010-06-14 23:22:04 +02:00
Jeremy Kemper
acad3ba848 Ruby 1.9.1 compat: constant lookup 2010-06-11 11:00:56 -07:00
Rizwan Reza
132730d5db Moved test/controller/cookie_test.rb to test/dispatch/cookies_test.rb 2010-06-11 16:34:53 +02:00
Alan Harper
566967eaf3 Missing method error doesn't specify which controller it is missing from [#4436 state:resolved] 
The error page shown when the method you are requesting on a controller
doesn't specify which controller the method is missing from

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-10 20:04:37 +02:00
Neeraj Singh
f48aa14bf4 Better test for ticket [#3914 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-09 09:51:05 +02:00
Neeraj Singh
db23a95a61 cache_sweeper yields blank output 
[#3914 state:open]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-08 23:20:04 +02:00
David Heinemeier Hansson
585f8f27b1 Fixed double output from cache in no caching mode 2010-06-08 14:47:02 -04:00
José Valim
981f81275b Fix case when rendering a partial inside RJS with inherited layout [#4786 state:resolved] 2010-06-07 22:22:54 +02:00
José Valim
9a93844aba Add :only and :except to controllers MiddlewareStack. This allows 
you to do the following:

  class PostsController < ApplicationController
    use AutheMiddleware, :except => [:index, :show]
  end
 2010-05-30 15:53:14 +02:00
José Valim
59d1c418be Fix a bug where responders were not working properly on method override. 2010-05-24 13:12:40 +02:00
Neeraj Singh
b462952886 Use better assertion methods for testing 
[#4645 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-19 10:18:36 +02:00
Neeraj Singh
73f0e1a842 Use assert_respond_to because it has better error messaging 
[#4628 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-18 02:12:06 +02:00
José Valim
25f7c030e4 Simplify cookie_store by simply relying on cookies.signed. 2010-05-18 02:05:20 +02:00
wycats
80b60671f7 Revert "Moved encoding work in progress to a feature branch." 
This reverts commit ade756fe42.
 2010-05-17 19:41:54 +04:00
Jeremy Kemper
ade756fe42 Moved encoding work in progress to a feature branch. 
This reverts commits af0d1a8815 and 64d109e353.
 2010-05-16 13:55:29 -07:00
wycats
64d109e353 Significantly improved internal encoding heuristics and support. 
* Default Encoding.default_internal to UTF-8
* Eliminated the use of file-wide magic comments to coerce code evaluated inside the file
* Read templates as BINARY, use default_external or template-wide magic comments
  inside the Template to set the initial encoding
  * This means that template handlers in Ruby 1.9 will receive Strings encoded
    in default_internal (UTF-8 by default)
* Create a better Exception for encoding issues, and use it when the template
  source has bytes that are not compatible with the specified encoding
* Allow template handlers to opt-into handling BINARY. If they do so, they
  need to do some of their own manual encoding work
* Added a "Configuration Gotchas" section to the intro Rails Guide instructing
  users to use UTF-8 for everything
* Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid
  $KCODE value is used

Also:
* Fixed a few tests that were assert() rather than assert_equal() and
  were caught by Minitest requiring a String for the message
* Fixed a test where an assert_select was misformed, also caught by
  Minitest being more restrictive
* Fixed a test where a Rack response was returning a String rather
  than an Enumerable
 2010-05-16 22:44:43 +04:00
Simon Jefford
f58bdae1f7 Check blocks are not incorrectly detected when compiling erubis templates [#4575 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-16 15:05:07 +02:00
rohit
fc2480a277 Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-16 14:32:53 +02:00
Jeff Kreeftmeijer
fa99de0bd0 partial counters with :as [#2804 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-15 10:32:23 -07:00
Anil Wadghule
2d84f24af5 Add tests for convenience methods #notice and #alert to flash.now [#4369 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-15 16:52:23 +02:00
Paco Guzman
cdf700147c fix assert_select messages to its declaration behaviour 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-15 16:31:36 +02:00
David Chelimsky
b3dcbedc67 move assert_template tests to their own test case [#4501 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-03 13:46:34 +02:00
David Chelimsky
849ab92942 Eliminate false positives when passing symbols to assert_template 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-03 13:46:12 +02:00
David Chelimsky
91125f9927 move FixtureResolver to a file that is accessible outside Rails' own tests 
[#4522 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-02 22:45:54 +02:00
Carl Lerche
6c280f3398 RouteSet does not raise ActionController::RoutingError when no routes match anymore. Instead, it follows the X-Cascade convention. ShowExceptions checks for X-Cascade so that the routing error page can still be displayed. 2010-04-30 16:40:42 -07:00
rick
8d236ccb84 add HTTP Token Authorization support to complement Basic and Digest Authorization. 2010-04-30 07:46:30 -07:00
Neeraj Singh
d793d30776 ActionCachingTestController rescues from all exceptions. Making sure that all the tests check for valid response. [#4468 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-29 12:48:34 +02:00
Anil Wadghule
53c13f1aca Use Config::CONFIG['host_os'] instead of RUBY_PLATFORM [#4477 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-26 11:12:52 -07:00
Cezary Baginski
490a3335d5 Action Pack: fix tests with -K*, work around Ruby 1.9.1 constant lookup. 
[#4473 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-25 17:00:20 -07:00
Jeremy Kemper
df886c4c89 Missed commit: explicit source encoding 2010-04-24 18:52:51 -07:00
José Valim
aaaa1782b4 Fix render :xml test (ht Simo Niemelä) 2010-04-24 11:48:47 +02:00
Santiago Pastorino
920df0a475 Make ActionDispatch url_for use HWIA symbolize_keys 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-22 09:06:55 -07:00
J Smith
275e839b8d Ensure that url_for uses symbolized keys in the controller. [#4391] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-22 16:47:36 +02:00
José Valim
81fb742488 Always downstream given options in :json, :xml and :js renderers and add tests for it. 2010-04-22 12:12:38 +02:00
David Chelimsky
4327ad51ab access assigns as a method or hash, with strings or symbols [#4431 state:resolved] 2010-04-17 15:59:10 -04:00
Santiago Pastorino
e85100da0a Added missing require 2010-04-16 23:44:39 -03:00
Santiago Pastorino
5699de1d15 Added test get to js should have a header with content-type text/javascript 2010-04-16 11:03:16 -03:00
Santiago Pastorino
8a8da68d1f Tidy up a bit this test file 2010-04-16 11:03:16 -03:00
Santiago Pastorino
462a7b45f6 Revert "Add test case which check content type when rendering rjs" partial in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag 
This reverts commit dc251389d1.
 2010-04-16 11:03:16 -03:00