github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
16,065 Commits 34 Branches 105 Tags
afcd252205d84ebf5ffd0659301c604a7beba2bb
Commit Graph

16065 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Noria
afcd252205 removes code written for Ruby < 1.8.7 2010-04-17 15:16:38 -07:00
David Chelimsky
4327ad51ab access assigns as a method or hash, with strings or symbols [#4431 state:resolved] 2010-04-17 15:59:10 -04:00
Aaron Patterson
d4d352bf94 fisting codes so it will parse [#4430 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 15:57:36 -04:00
Sven Fuchs
9a3a4d6aef Make i18n fallbacks configurable and fallback to the default locale by default in production [#4428 state:resolved] 
Allows to configure locale fallbacks through config.i18n.fallbacks. The default setting
config.i18n.fallbacks = true in production.rb will make I18n.t lookup fallback to the
I18n.default_locale if a translation could not be found for the current or given locale.

config.fallbacks = true

config.fallbacks.map = { :ca => :es }
config.fallbacks.defaults = [:'es-ES', :es]

config.fallbacks = [:'es-ES', :es]

config.fallbacks = { :ca => :es }

config.fallbacks = [:'es-ES', :es, { :ca => :es }]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2010-04-17 19:26:46 +01:00
Aaron Patterson
b7693dc028 working around syck defects by optionally matching a space [#4426 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 00:50:59 -04:00
Aaron Patterson
d92e3111fe making yaml tests less specific to emitter. [#4425 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 00:41:10 -04:00
Aaron Patterson
cd6578f6a1 fixing invalid yaml [#4424 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 00:14:23 -04:00
Santiago Pastorino
e85100da0a Added missing require 2010-04-16 23:44:39 -03:00
Santiago Pastorino
dadf35b2a9 avoid warning: ambiguous first argument; put parentheses or even spaces 2010-04-16 23:07:55 -03:00
wycats
457f7709e9 Missing requires 2010-04-16 21:59:09 -04:00
Carl Lerche
ac015b1d07 Revert "Avoid deprecation warnings and potential TypeErrors [#4404 state:resolved]" 
Revert "protected instance variables added to the deprecated config accessor

This reverts commit 4bce5ba600 and 0ee2d3c89a.
 2010-04-16 15:39:00 -07:00
Xavier Noria
09b9add8c5 Merge commit 'docrails/master' 2010-04-16 15:08:16 -07:00
Kieran Pilkington
001ca893c6 Mark the result of grouped_options_for_select as HTML safe [#4322 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-04-16 15:05:41 -07:00
Santiago Pastorino
66b55dbfea Add missing require 2010-04-16 18:44:54 -03:00
Jeremy Kemper
7bd3a105fd Bump rack-mount dependency to ~> 0.6.3 for CRITICAL FIX 2010-04-16 14:40:24 -07:00
Aaron Patterson
dc94d813e2 fixing invalid yaml [#4418 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 14:19:31 -07:00
Jeremy Kemper
9f26f95d4a Revert "Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled" 
They can be bundled. Just the git repos can't. Use rails/rack-mount for that.

This reverts commit ef6cdc974f.
 2010-04-16 13:55:21 -07:00
Jeremy Kemper
1924cff934 Fix Active Model observer tests 2010-04-16 13:14:52 -07:00
Mislav Marohnić
2161b8745a improve how ActiveRecord::Observer defines callbacks on observed models 
Instead of using a single `notify_observers` call for every callback type,
each observer now registers a unique callback for itself. Example:

  before_save :_notify_user_observer_for_before_save

  def _notify_user_observer_for_before_save
    observer.update(:before_save, self)
  end

Benefit: "before" callbacks halt when `observer.update` returns false.
This way, ActiveRecord observers can prevent records from saving.

[#4087 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:12:53 -07:00
Mislav Marohnić
c2ca73c9ee ActiveModel::Observing: stop using Observable Ruby module, re-implement notify_observers 
`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
callback chains) and has extra features (like `changed`) that were never used.

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:09:07 -07:00
Mislav Marohnić
cf616e4876 merge callbacks_observers_test.rb into lifecycle_test.rb where other observers test reside 
Benefits: test able to run independently, subclassing instead of changing the original Comment model

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:09:07 -07:00
Aaron Patterson
779723a0b4 fix a failure and some warnings on 1.9.2 [#4417 state:resolved] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-04-16 09:03:42 -07:00
Mikel Lindsaar
f7e9c93141 Fixing up some errors and changing the observer pattern to a much more simple and direct controller pattern 2010-04-17 00:57:40 +10:00
Santiago Pastorino
9c08ccd889 page_cache_extension is delegating to config so no need to deprecate 2010-04-16 11:03:16 -03:00
Santiago Pastorino
5699de1d15 Added test get to js should have a header with content-type text/javascript 2010-04-16 11:03:16 -03:00
Santiago Pastorino
8a8da68d1f Tidy up a bit this test file 2010-04-16 11:03:16 -03:00
Santiago Pastorino
462a7b45f6 Revert "Add test case which check content type when rendering rjs" partial in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag 
This reverts commit dc251389d1.
 2010-04-16 11:03:16 -03:00
Mislav Marohnić
8a91ccf976 add missing requires to Rescuable and RouteSet [#4415 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-04-16 06:11:38 -07:00
Jared Giles
9cf65af881 Added a note in the section on complex forms regarding nested attributes in 2.3 2010-04-15 17:04:00 -05:00
Michael Koziarski
5aa58cc03f Split the observer railtie into two phases. 
Observers observing models with scopes defined will require the connection to be established.
 2010-04-16 09:49:06 +12:00
Santiago Pastorino and Carl Lerche
0ea434e2f4 Make perform_caching work again, with the tests passing and backward compatible 2010-04-15 18:25:08 -03:00
Santiago Pastorino and Carl Lerche
005c2bac46 Revert "logger added to the deprecated config accessor" we need a major refactor to get this working 
This reverts commit 68f4e046a7.
 2010-04-15 16:58:31 -03:00
Nicolas Sanguinetti
4bce5ba600 Avoid deprecation warnings and potential TypeErrors [#4404 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2010-04-15 14:51:25 +01:00
eparreno
43d03c3a1c fix ActionController font and replace extract_locale_from_uri with extract_locale_from_tld 2010-04-15 11:05:34 +02:00
Xavier Noria
19fa272b52 Revert "I18n guide: change ActionController by Action Controller in some places and fix code example in 2.4 section" 
This reverts commit 002da9b6ea.
 2010-04-15 10:37:43 +02:00
Santiago Pastorino
68f4e046a7 logger added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
0ee2d3c89a protected instance variables added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
ab808a9d71 asset and helper path added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
eb8c7b4639 page_cache added to the deprecated config accessor 2010-04-14 22:49:53 -07:00
Santiago Pastorino
a618ad358a Make use of config.perform_caching 2010-04-14 22:35:13 -07:00
Matthew Rudy Jacobs
fc22552e5f action_dispatch/routing/deprecated_mapper needs with_options 
[#4398 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-14 21:43:35 -07:00
Santiago Pastorino
a0cc94b32e utc_offset returns nil for unknown zones 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-14 21:15:15 -07:00
Santiago Pastorino
e79193f852 Test for unknown zone with nil utc_offset 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-14 20:27:24 -07:00
Jeremy Kemper
8539e4ee73 Merge branch 'master' of github.com:rails/rails 2010-04-14 17:16:36 -07:00
wycats
14f8e17563 Merge branch 'master' of github.com:rails/rails 2010-04-14 17:15:20 -07:00
wycats
8c3bfa4ce9 Rely specifically on 0.6.0 and add a missing require 2010-04-14 17:15:13 -07:00
Santiago Pastorino
399d5338ac Fix missing dependency on Hash#to_query 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-14 17:14:50 -07:00
Jeremy Kemper
ef6cdc974f Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled 2010-04-14 17:04:33 -07:00
eparreno
002da9b6ea I18n guide: change ActionController by Action Controller in some places and fix code example in 2.4 section 2010-04-14 22:44:40 +02:00
Ryan Bigg
a77b86d57c Begun documenting YourApp::Application and how it ties in with the backend. 2010-04-14 20:29:15 +10:00