github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
26,971 Commits 34 Branches 105 Tags
b259bf91aed3d751da6d63442ec39d29fb040f5b
Commit Graph

26971 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vijay Dev
b259bf91ae fix duplicate ids for the headers [ci skip] 2012-01-19 23:36:45 +05:30
Vijay Dev
a0e439f2f8 document AR::Base#with_lock in release notes [ci skip] 2012-01-19 23:22:01 +05:30
Vijay Dev
6e311b93ad update the getting_started guide code [ci skip] 2012-01-19 23:13:19 +05:30
Aaron Patterson
4c5b73fef8 Merge pull request #4531 from exviva/pessimistic_with_lock 
Add ActiveRecord::Base#with_lock
 2012-01-19 09:39:20 -08:00
Simon Baird
00554568e0 Fix small typo in mail_to docs in url_helper.rb 2012-01-19 22:13:42 +05:30
Vijay Dev
c4508332c9 revising release notes [ci skip] 2012-01-19 22:12:22 +05:30
Fujimura Daisuke
ead04eeabd update release note: timestamps is non-null as default 2012-01-19 22:12:22 +05:30
Vijay Dev
c8b584f576 select doesn't take multiple arguments - fixes #4539 [ci skip] 
Didn't cherry pick the master commit because this one already had some
of the fixes made in master.
 2012-01-19 21:58:19 +05:30
Vijay Dev
2e6ca53da3 revise wording [ci skip] 2012-01-19 02:53:59 +05:30
Guillermo Iguaran
3bfbc455ff Adding Action Mailer section to 3.2 release notes 2012-01-19 02:53:57 +05:30
Guillermo Iguaran
683854918f Update Release Notes: sprockets-rails section should be inside of ActionPack section 2012-01-19 02:53:54 +05:30
Vijay Dev
f2af2acac7 Merge pull request #4525 from guilleiguaran/am-changelog-3-2-stable 
Update AM CHANGELOG
 2012-01-18 10:54:01 -08:00
Makoto Inoue
619731f2bb ActionController::UrlEncodedPairParser is deprecated. Replaced the url parsing example with Rack::Utils.parse_query 
- https://webrat.lighthouseapp.com/projects/10503/tickets/161-urlencodedpairparser-removed-in-edge-rails
 2012-01-19 00:14:52 +05:30
Guillermo Iguaran
939a84a40a Update AM CHANGELOG 2012-01-18 13:41:11 -05:00
Vijay Dev
0960eb97d9 updates to 3.2 release notes 2012-01-18 23:51:23 +05:30
José Valim
f74afd973d Merge pull request #4518 from guilleiguaran/silent-sprockets-logger-3-2-stable 
Silent Sprockets logger when config.assets.logger is set to false (3-2-stable)
 2012-01-18 05:20:20 -08:00
Guillermo Iguaran
ae7037eba0 Update CHANGELOG and docs for config.assets.logger 2012-01-18 08:06:48 -05:00
Guillermo Iguaran
02e4d7ffd4 Silent Sprockets logger when config.assets.logger is set to false 2012-01-18 07:55:49 -05:00
José Valim
2f52bd3082 Merge pull request #4498 from carlosantoniodasilva/action-controller-refactor-3-2 
Action controller refactor - deprecate Compatibility module
 2012-01-17 12:10:39 -08:00
Carlos Antonio da Silva
ed0f0ad35c Update changelog 2012-01-17 18:07:48 -02:00
Carlos Antonio da Silva
786a0b7475 Remove duplicated constant definition 
ActionController::ActionControllerError is already defined in
action_controller/metal/exceptions.
 2012-01-17 18:07:08 -02:00
Carlos Antonio da Silva
e5e87041ce Deprecate AC::UnknownError and AC::DoubleRenderError 
Use the constants AbstractController::ActionNotFound and
AbstractController::DoubleRenderError respectively instead.
 2012-01-17 18:07:08 -02:00
Carlos Antonio da Silva
9d4fd613a6 Add default charset config to ActionDispatch 2012-01-17 18:07:08 -02:00
Carlos Antonio da Silva
57be2cfa1e Deprecate default_charset= at controller level 2012-01-17 18:07:08 -02:00
Carlos Antonio da Silva
20baeece91 Add some deprecations for logic being removed in 4.0 2012-01-17 18:07:08 -02:00
Aaron Patterson
57f73a6bcf Merge pull request #4487 from sarenji/fix-reset-counters 
Fix bug where reset_counters resets the wrong counter cache.
 2012-01-17 10:23:56 -08:00
José Valim
5812c35b88 Merge pull request #4501 from rafaelfranca/assets-logger-3-2 
Add option to configure Sprockets logger [3-2-stable]
 2012-01-17 09:40:06 -08:00
Rafael Mendonça França
c4c6bebecf Add option to configure Sprockets logger 2012-01-17 14:36:23 -03:00
Piotr Sarnacki
ed35f3747c Merge pull request #4492 from pkondzior/3-2-stable 
Wrong behavior of ActiveModel::Errors#dup is causing regressions on applications using Rails 3-2-stable
 2012-01-17 00:45:24 -08:00
Paweł Kondzior
7021184f9c Fix ActiveModel::Errors#dup 
Since ActiveModel::Errors instance keeps all error messages as hash
we should duplicate this object as well.

Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash,
which results in different behavior on dup, this may result in regression for
people relying on it.

Because Rails 3.2 stills supports Ruby 1.8.7 in order to properly fix this
regression we need to backport #initialize_dup.
 2012-01-16 23:56:55 -08:00
Aaron Patterson
f9275e54e0 Merge pull request #4462 from spohlenz/fix-routing-tests 
Stub ip method of alternative request class in router tests
 2012-01-16 09:42:07 -08:00
Piotr Sarnacki
90aae070ed Apparently asssert_empty is not available in 1.8.7 2012-01-16 18:28:01 +01:00
Vijay Dev
48f9835bf5 minor edits in getting started guide 2012-01-16 22:07:49 +05:30
Vijay Dev
39d4878a71 copy editing asset pipeline changes 2012-01-16 22:07:44 +05:30
Richard Hulse
96e5d10fd7 [docs] Update pipeline asset organization section. 
* Calified how assets are included.
* Added information about using index manifests.
 2012-01-16 22:07:40 +05:30
Dan Pickett
951d70dbe0 change class to id per scaffold change 
#4472
 2012-01-16 22:07:36 +05:30
Carlos Antonio da Silva
7b8e6d52a8 Improve description of :allow_destroy option for nested attributes in getting started guide 2012-01-16 22:07:31 +05:30
Guillermo Iguaran
30782e443e Getting Started Guide: Update reference about JavaScript runtimes 2012-01-16 22:07:27 +05:30
Piotr Sarnacki
3430647434 Add ActiveModel::Errors#delete, which was not available after move to use delegation 2012-01-16 17:24:08 +01:00
José Valim
42159354b4 Merge pull request #4474 from guilleiguaran/fix-route-inspector-3-2-stable 
Don't hardcode assets route skipped in route inspector (3-2-stable)
 2012-01-15 08:04:09 -08:00
Guillermo Iguaran
666f9316eb Don't hardcode assets route skipped in route inspector 
Conflicts:

	railties/lib/rails/application/route_inspector.rb
 2012-01-15 10:52:25 -05:00
Piotr Sarnacki
dee595ce04 Fix stack level too deep when model does not have attributes method. 
Without that patch when using ActiveModel::AttributeMethods
in a class that does not respond to `attributes` method,
stack level too deep error will be raised on non existing
method. While documentation is clear that you need to define
`attributes` method in order to use AttributeMethods module,
`stack level too deep` is rather obscure and hard to debug,
therefore we should try to not break `method_missing` if
someone forgets about defining `attributes`.
 2012-01-15 16:01:05 +01:00
Mikel Lindsaar
95027d2240 Upgrade mail dependency to 2.4.0 2012-01-15 22:16:16 +10:30
Aaron Patterson
fce3afa9b2 Merge pull request #4471 from semaperepelitsa/enum_sum 
Pass a symbol instead of a block in Enumerable#sum
 2012-01-14 20:42:52 -08:00
Semyon Perepelitsa
d696f8de92 Pass a symbol instead of a block. This is faster and more concise. 
At least Ruby 1.8.7 is required which is ok since 3.2.

Benchmark:

```ruby
require "benchmark"

enum = 1..10_000
N = 100
Benchmark.bm do |x|
  x.report "inject block" do
    N.times do
      enum.inject { |sum, n| sum + n }
    end
  end

  x.report "inject symbol" do
    N.times do
      enum.inject(:+)
    end
  end
end
```

Result:

```
       user     system      total        real
inject block   0.160000   0.000000   0.160000 (  0.179723)
inject symbol  0.090000   0.000000   0.090000 (  0.095667)
```
 2012-01-15 11:42:31 +08:00
José Valim
78ef738313 Add begin/ensure block since we are returning. 2012-01-14 09:18:57 +01:00
Jon Leighton
70b762d1a7 Fix race condition 💣 2012-01-13 22:58:26 +00:00
Santiago Pastorino
c159b01b85 Use a BodyProxy instead of including a Module that responds to close. 
Closes #4441 if Active Record is disabled assets are delivered correctly
 2012-01-13 19:44:44 -02:00
José Valim
4ca3592f86 No AS::TestCase here. 2012-01-13 20:57:51 +01:00
José Valim
b745fe1e83 config.force_ssl should mark the session as secure. 2012-01-13 19:55:34 +01:00