github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,687 Commits 34 Branches 105 Tags
b5419cd66ea160d1ee94f3ca521bb44adf3a21ca
Commit Graph

4687 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tobias Lütke
b5419cd66e You can now use cache in instance hierachies. This allows ActiveRecord::Base.cache { } usage to cache everything 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-20 23:42:04 +00:00
David Heinemeier Hansson
e105653066 Added .erb and .builder as preferred aliases to the now deprecated .rhtml and .rxml extensions [Chad Fowler]. This is done to separate the renderer from the mime type. .erb templates are often used to render emails, atom, csv, whatever. So labeling them .rhtml doesn't make too much sense. The same goes for .rxml, which can be used to build everything from HTML to Atom to whatever. .rhtml and .rxml will continue to work until Rails 3.0, though. So this is a slow phasing out. All generators and examples will start using the new aliases, though. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-20 22:09:12 +00:00
Michael Koziarski
89cb34c9cf Stop swallowing errors during rake test [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-20 03:15:26 +00:00
Jeremy Kemper
772e02dd62 Factor out unique id generator. Expose cgi to session store. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 23:51:25 +00:00
David Heinemeier Hansson
9e4c8b8858 Fix tests depending too deep 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 02:25:01 +00:00
David Heinemeier Hansson
94fa0ed053 Its ETag not Etag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 02:10:19 +00:00
David Heinemeier Hansson
bd0cd04374 Set cache-control to private if theres an etag available (and the cache-control hasnt been overwritten already) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 02:04:26 +00:00
David Heinemeier Hansson
372db1cd9e Dont ask for no caching if we have a etag to base that decision on 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 01:33:35 +00:00
David Heinemeier Hansson
7ec0204ecd Move etagging down to response, so renders with layouts dont screw it up [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 00:27:19 +00:00
David Heinemeier Hansson
aad7fbde68 Added caching option to AssetTagHelper#stylesheet_link_tag and AssetTagHelper#javascript_include_tag [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 23:54:20 +00:00
David Heinemeier Hansson
109d4ac954 Allow people to set their own etags, if they want more control over the process (closes #7580) [] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 16:32:05 +00:00
Jeremy Kemper
c9260c556c Add request protocol to asset host if not given. Prefer setting asset host as hostname only, no request protocol. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 07:23:57 +00:00
Jeremy Kemper
90c1207c38 Work around the two connection per host browser limit: use asset%d.myapp.com to distribute asset requests among asset[0123].myapp.com. Use a DNS wildcard or CNAMEs to map these hosts to your asset server. See http://www.die.net/musings/page_load_time/ for background. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 06:44:20 +00:00
Jeremy Kemper
4fd84aae90 Etagging ignores appended and block responses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 00:47:18 +00:00
David Heinemeier Hansson
392c7f7314 Added default mime type for CSS (Mime::CSS) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 00:00:14 +00:00
David Heinemeier Hansson
2e55095f6f Added that rendering will automatically insert the etag header on 200 OK responses. The etag is calculated using MD5 of the response body. If a request comes in that has a matching etag, the response will be changed to a 304 Not Modified and the response body will be set to an empty string. [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-17 18:16:44 +00:00
David Heinemeier Hansson
cfa7df3fbb Added X-Runtime to all responses with the request run time [DHH] (rename from X-Benchmark) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-17 05:11:55 +00:00
David Heinemeier Hansson
c74c78c88d Added X-Benchmark to all responses with the same benchmark data as goes into the log [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-16 21:13:02 +00:00
David Heinemeier Hansson
06669f8b13 In tests, content_type can be nil, which would disturb accepts/format 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-15 18:52:08 +00:00
Rick Olson
e312cc3215 remove Mime::PLAIN from tests so its not confused with the default Mime::TEXT mime type 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-15 16:40:38 +00:00
Rick Olson
5d54b8f07c Add Mime::Type convenience methods to check the current mime type. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-15 16:25:46 +00:00
Jeremy Kemper
5b7630e174 MySQL disallows TEXT defaults so don't test for them. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-11 09:17:10 +00:00
Jeremy Kemper
002c0aeef3 Hash#to_query CGI-escapes its keys. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-11 06:29:04 +00:00
Jeremy Kemper
39ae7025e8 Don't test for hash sort order. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-11 04:40:58 +00:00
Jeremy Kemper
eb2dad2fe5 Revert [6086] and [6087] since they caused a major regression with functional tests in 1.2.2. References #7372. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-10 03:55:12 +00:00
Jeremy Kemper
916f9e5143 Performance: patch cgi/session to require digest/md5 once rather than per #create_new_id. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-10 02:44:32 +00:00
Thomas Fuchs
c9108f3e39 Add a :url_based_filename => true option to ActionController::Streaming::send_file, which allows URL-based filenames. [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-09 11:25:37 +00:00
Jeremy Kemper
9daddf0116 Deprecation: warn on stderr if RAILS_DEFAULT_LOGGER isn't set yet. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-08 00:17:39 +00:00
Jamis Buck
83752373b9 Made increment_counter/decrement_counter play nicely with optimistic locking, and added a more general update_counters method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-07 16:10:40 +00:00
Tobias Lütke
f458b376c5 Introducing Model.cache { ... } for the occasional query caching needs. ( fantastic to reduce the 200 SELECT * from accounts WHERE id=1 queries in your views ) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 21:16:07 +00:00
David Heinemeier Hansson
23b2abe313 More Safari appeasement 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 20:29:15 +00:00
David Heinemeier Hansson
f57367c832 Safari requires an explicit submit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 19:30:52 +00:00
David Heinemeier Hansson
06b1198736 Fix that FormTagHelper#submit_tag using :disable_with should trigger the onsubmit handler of its form if available [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 17:48:38 +00:00
Rick Olson
9f31ecb4c9 rename #lookup_template_base_path_for to #find_base_path_for in ActionView::Base [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 03:58:48 +00:00
Rick Olson
2782c37bdf Fix #render_file so that TemplateError is called with the correct params and you don't get the WSOD. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-05 05:39:23 +00:00
Rick Olson
38e5d21bc4 Fix Rails::Initializer since #view_paths is never nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 22:56:36 +00:00
Rick Olson
f2f2686f97 Update Rails Initializer to use ActionController::Base#view_paths [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 22:41:37 +00:00
Rick Olson
92195e68a0 Fix issue with deprecation messing up #template_root= usage. Add #prepend_view_path and #append_view_path to allow modification of a copy of the 
superclass' view_paths.  [Rick]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 22:27:45 +00:00
Michael Koziarski
517bf0814e Fix for DateTime superclass mismatch errors seen on some linux distributions. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6121 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 21:17:49 +00:00
Rick Olson
69b0e5c44a Allow Controllers to have multiple view_paths instead of a single template_root. Closes #2754 [John Long] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:47:05 +00:00
David Heinemeier Hansson
8f614a80e7 Fix gem deprecation warnings, which also means depending on RubyGems 0.9.0+ [Chad Fowler] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:44:45 +00:00
Rick Olson
19fbb31464 Add much-needed html-scanner tests. Fixed CDATA parsing bug. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:04:40 +00:00
Rick Olson
4790228bc4 fix problem with EMPTY_INHERITABLE_ATTRIBUTES being redefined 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 19:23:27 +00:00
Rick Olson
7a49cb058f fix form_for example in ActionController::Resources documentation. Closes #7362 [gnarg], Added enhanced docs to routing assertions. Closes #7359 [Rob Sanheim], improve error message for Routing for named routes. Closes #7346 [Rob Sanheim] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 19:07:08 +00:00
Rick Olson
0a454cd73e fix #write_inheritable_attribute bug that crept in 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 18:33:54 +00:00
Rick Olson
3340261515 Optimize Class Inheritable Attributes so that unnecessary hashes are not created. Closes #7472 [Bruce Perens] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 18:20:04 +00:00
Jeremy Kemper
aa7859c976 Plugins may be symlinked in vendor/plugins. Closes #4245. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-01 20:12:36 +00:00
Jeremy Kemper
593b1b837d Ruby 1.8-cvs and 1.9 define a private Time#to_date that overrides Active Support. Make it public to preserve compatibility. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-01 18:06:16 +00:00
Michael Koziarski
416091d8b5 Fix missed smtp_session changes to base.rb. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6097 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-31 20:57:19 +00:00
David Heinemeier Hansson
5c0227edc9 Make sure that the string returned by TextHelper#truncate is actually a string, not a char proxy -- that should only be used internally while working on a multibyte-safe way of truncating [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-31 17:55:09 +00:00