github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
23,986 Commits 34 Branches 105 Tags
b744c8493bb29bf3e59164ff65ca22ff17611554
Commit Graph

23986 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
b744c8493b adding changelog entry for connection urls 2011-07-21 13:09:42 -07:00
Aaron Patterson
1a0b7ea3c9 adding more tests around database uri parsing 2011-07-21 12:57:05 -07:00
Aaron Patterson
f4ed975125 move around tests 2011-07-21 11:54:29 -07:00
Terence Lee
16921437a1 fix postgres connection url test 2011-07-20 16:23:31 -07:00
Glenn Gillen
1f427b5341 Add documentation for URL connection strings. 2011-07-20 16:23:31 -07:00
Glenn Gillen
16249feaab Added test for postgres connections as URL. Fixed query param parsing. 2011-07-20 16:23:31 -07:00
Glenn Gillen
89357c8f83 Provide database connection settings as a URL. 2011-07-20 16:23:31 -07:00
Aaron Patterson
22e47279bc no need to sort the values 2011-07-20 15:52:53 -07:00
Franck Verrot
8bc314b3b7 assign_nested_attributes_for_collection_association should work with Ruby 1.9 [Closes #2106] 
Children attributes can be either String's or Symbol's, so let's check if the object responds to to_i.
 2011-07-20 15:40:01 -07:00
Aaron Patterson
d8736b266b Revert "this fixes a brittle test in fixtures_test.rb which fails when you are in a timezone which is ahead of UTC but UTC is in the previous day still." 
This reverts commit f92cefa95f.
 2011-07-20 15:37:52 -07:00
Aaron Patterson
09a488456a bigdecimal should be typecast to a float on sqlite3. fixes #2162 2011-07-20 14:39:01 -07:00
Santiago Pastorino
993d0f6477 Merge pull request #2159 from ogeidix/master 
Fixed issue #2119: XHR without Accept and Content-Type header gets 500 error
 2011-07-20 10:29:28 -07:00
Xavier Noria
64268c5dd1 Merge pull request #2165 from joshk/fixtures_test_fix 
Timezone fixtures test correction
 2011-07-20 04:04:47 -07:00
Xavier Noria
4636638bb9 Merge pull request #2136 from judearasu/guides_branch 
notextile tag in rails guides generator has been placed with ascii quotes
 2011-07-20 04:04:07 -07:00
Xavier Noria
0e6f19cc9b documents the changes to String#blank? in the AS guide 2011-07-20 12:17:37 +02:00
Xavier Noria
e175117eaf registers the changes to String#blank? in the CHANGELOG 2011-07-20 12:17:37 +02:00
Xavier Noria
82b5ebb710 Merge pull request #2164 from dmathieu/missing_require 
missing require of string/encoding to have access to encoding_aware?
 2011-07-20 03:09:49 -07:00
Damien Mathieu
2a371368c9 missing require of string/encoding to have access to encoding_aware? 2011-07-20 11:45:59 +02:00
Xavier Noria
af561901a0 Merge pull request #2146 from dmathieu/blank_binary_encoding 
fix String#blank? on binary strings
 2011-07-20 02:38:26 -07:00
Damien Mathieu
0c58f39c2c fix String#blank? on binary strings. 2011-07-20 11:23:00 +02:00
Josh Kalderimis
f92cefa95f this fixes a brittle test in fixtures_test.rb which fails when you are in a timezone which is ahead of UTC but UTC is in the previous day still. 2011-07-20 01:00:35 +02:00
Jeremy Kemper
b8a4e9fc6d Merge pull request #2160 from joshk/patch-5 
Changed the year of a date used in a test which fails when using 1.8.7
 2011-07-19 14:11:03 -07:00
Josh Kalderimis
322393f8cb Changed the year of a date used in a test which fails when using 1.8.7 on a 32bit machine (ArgumentError: time out of range) 2011-07-19 13:52:32 -07:00
ogeidix
1ac802fe3c Check Accept and Content-Type headers before evaluating them in xhr requests. Closes #2119 
An xhr request must have an "Accept" or "Content-type" header in order to be considered a request with valid_accept_header.
 2011-07-19 22:05:16 +02:00
Santiago Pastorino
37418e5468 Merge pull request #2155 from vijaydev/changelogs 
Adding changelog entry for submit helper change which removed object_name_id generation
 2011-07-19 12:20:36 -07:00
Santiago Pastorino
ee6be604c6 Merge pull request #2154 from vijaydev/better_map 
Avoid Symbol#to_proc
 2011-07-19 12:18:46 -07:00
Vijay Dev
d275a98446 add entry for submit helper change removing object_name_id 2011-07-20 00:39:23 +05:30
Vijay Dev
02cbaf0593 avoid Symbol#to_proc 2011-07-20 00:28:51 +05:30
Santiago Pastorino
30289c7683 Merge pull request #2148 from norman/master 
Explicitly require Active Support dependencies (master)
 2011-07-19 06:38:20 -07:00
Norman Clarke
9db2d10b11 Explicitly require Active Support dependencies 
This fixes errors when using Active Record outside of Rails. In Rails,
these files are required by other classes that are always loaded, so
this error does not happen.

Without core_ext/module/delegation, a NoMethodError is raised because
`delegate` remains undefined.

Without core_ext/class/attribute_acessors, an ArgumentError is raised because
`delegate` does not receive a value for its :to option.
 2011-07-19 09:56:02 -03:00
Santiago Pastorino
73efb68dc9 Merge pull request #2139 from mcmire/issue_2078_master 
Fix for #2078 (against master)
 2011-07-18 17:27:21 -07:00
Xavier Noria
aaff90ac7f Merge pull request #2141 from joshk/master 
Config files to get Rails on Travis-CI
 2011-07-18 14:34:18 -07:00
Elliot Winkler
0e1d617b8b ActiveRecord: Fix eager loading so that giving a blank order clause generates valid SQL 2011-07-18 14:56:37 -06:00
JudeArasu
01040b5dc9 notextile tag has been placed with ascii quotes 2011-07-19 01:33:45 +05:30
José Valim
b475f74da5 Merge pull request #2133 from jstorimer/ensure-status-codes-are-logged-properly 
Ensure that status codes are logged properly
 2011-07-18 11:05:37 -07:00
Jesse Storimer
ac81af40c0 Ensure that status codes are logged properly 
Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue
so that status codes rendered from rescue_from blocks are logged
properly.
 2011-07-18 13:42:07 -04:00
Santiago Pastorino
8efc0f1f34 Merge pull request #2116 from guilleiguaran/fix-environment-generator-action 
Fix Rails::Generators::Actions#environment when env is passed
 2011-07-18 10:00:08 -07:00
Guillermo Iguaran
fcdcc87a08 Fix Rails::Generators::Actions#environment when env is passed. Closes #2110 2011-07-18 10:43:25 -05:00
José Valim
da144894e9 Merge pull request #195 from bigfix/active_model_include_serialization 
ActiveModel support for the :include serialization option
 2011-07-18 06:50:43 -07:00
José Valim
44e83ac341 Merge pull request #2075 from lawrencepit/match_attribute_method 
Optimization of ActiveModel's match_attribute_method?
 2011-07-18 06:46:31 -07:00
Jon Leighton
50941ec07c Merge pull request #2128 from sikachu/master-dynamic_finder 
Raise an ArgumentError if user passing less number of argument in the dynamic finder
 2011-07-18 01:24:33 -07:00
Aaron Patterson
1e452f1840 make tzinfo a development dependency 2011-07-18 14:28:14 +09:00
Prem Sichanugrist
4443905169 Refactor test case to use anonymous class - Thank you @tenderlove 2011-07-18 00:37:06 -04:00
Santiago Pastorino
adc7097dc0 Merge pull request #2124 from arunagw/render_partial_invalid_check_fix 
Checking with to_s. As regexp fail with 1.8.7
 2011-07-17 20:14:12 -07:00
Jon Leighton
fcbde454f6 Don't do remove_possible_method when delegate is used. Two reasons: 1) warnings should be shown, and fixed at the source and 2) the code is slow. Fixes #1937. 2011-07-18 00:22:26 +01:00
Prem Sichanugrist
1ccca1b9cb Refactor the code a bit to reduce the duplication 2011-07-17 18:53:15 -04:00
Prem Sichanugrist
6e6994994d Raise an ArgumentError if user passing less number of argument in the dynamic finder 
The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.)

So if you were doing this and expecting the second argument to be nil:

    User.find_by_username_and_group("sikachu")

You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this:

    User.find_by_username_and_group("sikachu", nil)
 2011-07-17 18:44:03 -04:00
Arun Agrawal
d4f4626940 Checking with to_s. As regexp fail with 1.8.7 2011-07-18 01:27:38 +05:30
Santiago Pastorino
e9bd83402e Merge pull request #2046 from sikachu/master-test_fix 
Fix a wrong assertion on url_helper_test, and add missing `#html_safe?` a
 2011-07-17 12:48:49 -07:00
Prem Sichanugrist
edfb81d668 Fix a wrong assertion on url_helper_test, and refactor html_safe test to be in its method 2011-07-17 15:34:01 -04:00