github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
21,726 Commits 34 Branches 105 Tags
bbe0a507f287c20ab4ae8a244fbfc810665deda5
Commit Graph

21726 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Leighton
bbe0a507f2 Remove unnecessary code from define_read_method and add assertion to make sure the underscored version is actually generated 2011-04-15 01:44:27 +01:00
David Heinemeier Hansson
3d44e45758 Use JS comments, please 2011-04-15 01:33:03 +02:00
Aaron Patterson
3e23752236 bcrypt will encrypt anything, so validate_presence_of would not catch nil / blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this 2011-04-14 14:54:25 -07:00
Aaron Patterson
9951af0289 sort insert columns for better cache hits 2011-04-14 14:26:57 -07:00
Aaron Patterson
199c0bb338 generated session ids should be encoded as UTF-8 2011-04-14 13:37:40 -07:00
Aaron Patterson
12ae92216b refactoring inserts to use the same method on the connection 2011-04-14 13:37:40 -07:00
Aaron Patterson
0268eac963 mimic prepared statements in the exec_insert for mysql2 2011-04-14 13:37:40 -07:00
Aaron Patterson
a22ceaeefa mysql type cast should return integers when typecasting true / false 2011-04-14 13:37:39 -07:00
Aaron Patterson
a0d4c8d1bf using the database adapter to typecast before executing prepared statement 2011-04-14 13:37:39 -07:00
Aaron Patterson
27f8c57f5f inserting big decimals as strings works consistently among dbs, so use string form 2011-04-14 13:37:39 -07:00
Aaron Patterson
8571facea3 insert statements are prepared, but values are not escaped properly 2011-04-14 13:37:39 -07:00
Aaron Patterson
4893170da2 adding a type cast method for prepared statements 2011-04-14 13:37:38 -07:00
Jon Leighton
6b6ecbefad Extract the constraint-building for joins in JoinAssociation into a separate method to make it easy to change/override (requested by Ernie Miller so that MetaWhere can add to it easily) 2011-04-14 19:34:19 +01:00
Jared McFarland
cd233dd87e Only rescue a thrown NoMethodError, don't preemptively check for #include?; added tests 2011-04-15 00:36:07 +08:00
Jared McFarland
2db9f8a41c added an exception to Object#in? to match the methods documentation 2011-04-15 00:36:05 +08:00
Prem Sichanugrist
89884c194a Update scaffold controller to generate scss file if Sass is available 2011-04-15 00:32:27 +08:00
Stian Grytøyr
93641ed6c8 Fixes performance issue introduced in 3.0.6 (issue #6695) 2011-04-14 08:56:02 -07:00
Sebastian Martinez
fb6fa1e425 change to use the Sass file extension .scss 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-04-14 10:14:57 -03:00
David Heinemeier Hansson
6c91b699bf The controller and resource generators will now automatically produce asset stubs (this can be turned off with --skip-assets). These stubs will use Coffee and Sass, if those libraries are available. [DHH] 2011-04-14 12:23:21 +02:00
Andre Arko
bd032fe97e files are a special case and need whitespace to be significant 2011-04-14 17:08:57 +08:00
Andre Arko
d01be122b8 gsub is not needed (thanks @fxn!) 2011-04-14 16:58:52 +08:00
David Heinemeier Hansson
90246acb6d Bring back tmp/cache for the default local cache to work 2011-04-14 10:57:14 +02:00
Brian Cardarella
a8365ab9ad Declaring the attr_accessor for password_confirmation is not necessary 
as the confirmation validation already adds that attr_accessor
 2011-04-14 16:43:51 +08:00
Andre Arko
7660e7cb4d attributes no longer disappear if a tag contains whitespace 
old:
Hash.from_xml("<tag foo='bar'>\n</tag>")
=> {"tag"=>"\n"}

new:
Hash.from_xml("<tag foo='bar'>\n</tag>")
=> {"tag"=>{"foo"=>"bar", "__content__"=>"\n"}
 2011-04-14 16:33:41 +08:00
Eric Hayes
ada550d908 Fixed a comment typo 2011-04-14 16:29:06 +08:00
Ben Orenstein
4db4f8c624 Add tests for InheritableOptions. 
[#6625 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-04-13 23:30:58 -03:00
David Heinemeier Hansson
443af58995 Its assets.enabled, not assets.enable 2011-04-14 00:45:25 +02:00
David Chelimsky
a26d407f63 ActionView::PathSet# accepts String or Array 
- Closes #6692

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-04-13 21:45:51 +02:00
David Heinemeier Hansson
bd3b2241a4 Cleanup the Gemfile and compute whats needed depending on whether we are on 1.8 or 1.9 2011-04-13 21:32:41 +02:00
Aaron Patterson
1f4dae9daa do not depend on to_yaml being called, but rather depend on YAML being dumped 2011-04-13 11:41:42 -07:00
Prem Sichanugrist
0f8a6ebba3 Fix missing requires in Action Mailer 
This made the isolated test failed on CI server.

Signed-off-by: Xavier Noria <fxn@hashref.com>
 2011-04-13 19:52:19 +02:00
Aaron Patterson
eebb19c954 use index based substitution for bind parameters 2011-04-13 09:42:51 -07:00
David Heinemeier Hansson
48fb6b3380 Generate scaffold.css to app/assets/stylesheets (next step, SCSSify it if SCSS is available) 2011-04-13 18:21:52 +02:00
David Heinemeier Hansson
023d4f9fc1 Includes have to be in the first comment 2011-04-13 18:09:04 +02:00
David Heinemeier Hansson
e7280cb1bd Use driver_ujs now that we no longer have to depend on a shared name and insert all prototype dependencies if thats specified 2011-04-13 18:08:40 +02:00
David Heinemeier Hansson
17c1b0f0d3 Use driver_ujs now that we no longer have to depend on a shared name and insert all prototype dependencies if thats specified 2011-04-13 18:08:02 +02:00
David Heinemeier Hansson
26528efb54 Blah, assets cant be turned on from initializers either 2011-04-13 18:02:49 +02:00
David Heinemeier Hansson
4eb3ee4818 Cleanup comments 2011-04-13 17:54:11 +02:00
David Heinemeier Hansson
5b49867a75 Not needed 2011-04-13 17:51:46 +02:00
David Heinemeier Hansson
65ffcecc6a Require asset pipeline targets by default 2011-04-13 17:50:55 +02:00
David Heinemeier Hansson
7e3b374312 Require everything by default 2011-04-13 17:50:37 +02:00
David Heinemeier Hansson
f3f28ee493 Dont need to make application.js into coffee since it will mostly be a manifest file anyway 2011-04-13 17:37:48 +02:00
David Heinemeier Hansson
cf5599d9fa Move json requirement to user Gemfile -- still need to do better than this, though 2011-04-13 17:31:32 +02:00
David Heinemeier Hansson
1652c55651 Use Sass from git until the final gem is out 2011-04-13 17:30:08 +02:00
David Heinemeier Hansson
e3273f5cce Move the asset template engines to the user-generated Gemfile 2011-04-13 17:14:14 +02:00
Joshua Peek
23aa7dacb5 Generate CoffeeScript stub by default 2011-04-13 10:03:47 -05:00
Joshua Peek
9f09aeb827 Include CoffeeScript in Gemfile 2011-04-13 09:57:22 -05:00
Joshua Peek
9333ca74b3 Add default require directives for jquery 2011-04-13 09:47:29 -05:00
David Heinemeier Hansson
5e7e81ab1a Blah, identity_map has to be setup in application.rb to work 2011-04-13 16:42:59 +02:00
David Heinemeier Hansson
6fa7c3e036 Fix triplets 2011-04-13 16:26:22 +02:00