github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
21,726 Commits 34 Branches 105 Tags
bbe0a507f287c20ab4ae8a244fbfc810665deda5
Commit Graph

6726 Commits

Author SHA1 Message Date
Aaron Patterson
199c0bb338 generated session ids should be encoded as UTF-8 2011-04-14 13:37:40 -07:00
Eric Hayes
ada550d908 Fixed a comment typo 2011-04-14 16:29:06 +08:00
David Chelimsky
a26d407f63 ActionView::PathSet# accepts String or Array 
- Closes #6692

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-04-13 21:45:51 +02:00
Prem Sichanugrist
0f8a6ebba3 Fix missing requires in Action Mailer 
This made the isolated test failed on CI server.

Signed-off-by: Xavier Noria <fxn@hashref.com>
 2011-04-13 19:52:19 +02:00
Prem Sichanugrist
733bfa63f5 Remove #among? from Active Support 
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.

It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
 2011-04-13 20:25:28 +08:00
Xavier Noria
1f869114f5 updates AP CHANGELOG 2011-04-13 13:41:26 +02:00
Xavier Noria
acdbc6ae41 renames response_from_page_or_rjs -> response_from_page, and extracts the RJS in it 2011-04-13 13:24:33 +02:00
Xavier Noria
86d6cdd7f7 fixes the name of a test 2011-04-13 13:24:33 +02:00
Xavier Noria
d76fbff8b4 removes reference to RJS from AC::RecordIdentifier docs 2011-04-13 13:24:32 +02:00
Xavier Noria
404ae77c40 removes a remaining reference to .rjs in template resolver's RDoc 2011-04-13 13:24:32 +02:00
Xavier Noria
16bccca361 removed references to RJS from the AP README 2011-04-13 13:24:32 +02:00
Xavier Noria
e06771f9d4 removes RJS documentation from AV::Base 2011-04-13 13:24:32 +02:00
Xavier Noria
d8f23ca627 removes debug_rjs from ActionView::Base 2011-04-13 13:24:32 +02:00
Xavier Noria
7c9d91f53e removes render :update from views 2011-04-13 13:24:32 +02:00
Xavier Noria
90de26703e removes ActionView::Helpers::PrototypeHelper 2011-04-13 13:24:32 +02:00
Xavier Noria
06bdaae071 removes ActionView::Helpers::ScriptaculousHelper 2011-04-13 13:24:31 +02:00
Xavier Noria
5850f16935 removes the RJS template handler 2011-04-13 13:23:18 +02:00
Xavier Noria
eea66892c8 removes support for render :update 2011-04-13 13:23:17 +02:00
Xavier Noria
25181cafee let the default function in button_to_function be nil 
I don't know which is the use case for button_to_function(name)
but there's a test for it. I am focused now on RJS extraction
and do not want to introduce a backwards incompatible change
at this moment. Perhaps worth revisiting when the whole thing
is done.
 2011-04-13 13:23:16 +02:00
Xavier Noria
f9472f064f applies API guidelines to example 2011-04-13 13:23:16 +02:00
Xavier Noria
3223e04a21 removes support for RJS in button_to_function 2011-04-13 13:23:16 +02:00
Xavier Noria
b878757c50 removes assert_select_rjs 2011-04-13 13:23:16 +02:00
Xavier Noria
8449da929e removes support for RJS in link_to_function 2011-04-13 13:23:16 +02:00
Xavier Noria
096fa1b60f jQuery is the new default 2011-04-13 13:23:16 +02:00
Matt Duncan
805126b20a Aligning comments 2011-04-13 16:14:53 +08:00
Matt Duncan
93def19063 Fixing distance_of_time_in_words range near 2 days 2011-04-13 16:14:52 +08:00
Joshua Peek
ed24595647 Merge branch 'master' into sprockets 2011-04-12 21:56:00 -05:00
Xavier Noria
3366479a9a Merge branch 'master' of git://github.com/lifo/docrails 2011-04-12 22:45:33 +02:00
David Heinemeier Hansson
d1575ae1b9 Change Object#either? to Object#among? -- thanks to @jamesarosen for the suggestion! 2011-04-12 00:23:07 +02:00
Oge Nnadi
d5634b2287 Added missing </tt> 2011-04-11 13:08:58 -07:00
Prem Sichanugrist
d6edaeeaf8 Fix failing test case on master 
It turned out that I overlook at some replacements ..
 2011-04-10 22:40:21 -07:00
Prem Sichanugrist
a9f3c9da01 Using Object#in? and Object#either? in various places 
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
 2011-04-11 03:17:09 +08:00
Jo Liss
c59456a1d9 removed :nodoc: from ActionController::MimeResponds 
So we don't miss out on the nice documentation of the respond_to and
respond_with instance methods.  Also added :nodoc: to protected method.
 2011-04-10 11:47:22 +02:00
James Robinson
2cdc1f0cd5 Make csrf_meta_tags use the tag helper 
Improved formatting of csrf_helper and improved test coverage
 2011-04-08 02:21:08 +02:00
Aaron Patterson
a7c5d40d80 Merge branch 'master' of github.com:rails/rails 
* 'master' of github.com:rails/rails:
  Cache flash now
  Revert "Use freeze instead of close!"
  Revert "Eagerly load Signed and Permanent cookies"
  cookies here
  Eagerly load Signed and Permanent cookies
  Use freeze instead of close!
 2011-04-07 09:35:24 -07:00
Santiago Pastorino
0e624ce9eb Cache flash now 2011-04-07 09:27:00 -03:00
Santiago Pastorino
03d561ad77 Revert "Use freeze instead of close!" 
This reverts commit 29592a7f09.
 2011-04-07 09:26:04 -03:00
Santiago Pastorino
5b0149a17a Revert "Eagerly load Signed and Permanent cookies" 
This reverts commit dffeda3770.
 2011-04-07 09:20:56 -03:00
Santiago Pastorino
17205435f8 cookies here 2011-04-07 09:20:35 -03:00
Santiago Pastorino
dffeda3770 Eagerly load Signed and Permanent cookies 2011-04-07 09:15:28 -03:00
Aaron Patterson
1e90229e04 many args does not make sense with the current implementation because of how use works 2011-04-06 18:13:16 -07:00
Aaron Patterson
32f876786a getting the flash hash under test 2011-04-06 18:01:03 -07:00
Aaron Patterson
76c2ea7882 favor composition over inheritance, have FlashHash delegate to a Hash 2011-04-06 17:26:55 -07:00
Santiago Pastorino
29592a7f09 Use freeze instead of close! 2011-04-06 20:53:48 -03:00
Aaron Patterson
0ca69ca65f CookieJar should prefer composition over inheritance 2011-04-06 16:27:05 -07:00
Santiago Pastorino
9f765f4e09 Delete useless arguments 2011-04-06 19:18:41 -03:00
Santiago Pastorino
ed04243629 Delete useless env variable 2011-04-06 19:15:33 -03:00
Santiago Pastorino
0d45567362 Add tests to verify that signed and permanent cookies raises if someone tries 
to modify the cookies when it was already streamed back to the client
or converted to HTTP headers
 2011-04-06 19:12:35 -03:00
Santiago Pastorino
0e4748cd41 Make process reuse the env var passed as argument 2011-04-06 16:37:55 -03:00
Santiago Pastorino
0c5aded092 raise if someone tries to modify the cookies when it was already streamed back to the client or converted to HTTP headers 2011-04-06 15:47:58 -03:00