github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,288 Commits 34 Branches 105 Tags
bc35631dc7d67ec9c918ec1967c708a5388a76e4
Commit Graph

17288 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
bc35631dc7 use constants instead of magic numbers. meow 2010-07-13 10:57:22 -07:00
Santiago Pastorino
2b22d1240b Makes CI builder install --pre version of Bundler, now that bundle install works again 2010-07-13 10:35:04 -07:00
Xavier Noria
6d2e4ee96c Merge remote branch 'docrails/master' 2010-07-13 18:41:09 +02:00
Benjamin Quorning
7e075e6247 Fixed many references to the old config/environment.rb and Rails::Initializer 2010-07-13 13:00:21 +02:00
Vitalii Khustochka
b75fca9e57 Added reorder delegation for ActiveRecord::Base(to be able to overwrite the default_scope ordering in the named scope [#5093 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:31:55 +02:00
Miles Egan
d2fae5f78e remove size attribute from tag generated by file_field helper [#5084 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:30:08 +02:00
Will St. Clair + Neeraj Singh
b520d602ff string IDs are now quoted correctly [#5064 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:14:52 +02:00
Subba Rao Pasupuleti
44e7fba59e renaming test name to fix accidently override 
[#5076 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:09:57 +02:00
Mislav Marohnić
571cb1ddc6 enable AS::JSON.encode to encode AR::Relation by providing as_json method 
[#5073 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:09:28 +02:00
José Valim
3401311562 Tidying up a bit, so update_attribute is not called twice on touch. 2010-07-13 08:05:09 +02:00
Neeraj Singh
1d45ea0814 with this fix touch method - does not call validations - doest not call callbacks - updates updated_at/on along with attribute if attribute is provided - marks udpated_at/on and attribute as NOT changed 
[#2520 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 07:03:42 +02:00
Aaron Patterson
2aed63eb52 our method is modifying the original array, so refactor to use destructive methods 2010-07-12 17:58:48 -07:00
Aaron Patterson
2c3aab32dd PostgreSQLAdapter#select_raw removing dead code 2010-07-12 17:52:53 -07:00
Aaron Patterson
79e9f4a318 PostgreSQLAdapter#select_raw use each_with_index to avoid multiple array lookups 2010-07-12 17:49:12 -07:00
Aaron Patterson
8521cdf03d PostgreSQLAdapter#select_raw fields and results are empty even if ntuples is 0 2010-07-12 17:44:15 -07:00
Aaron Patterson
c9710a43ff refactor PostgreSQLAdapter#result_as_array to create fewer Range objects 2010-07-12 17:00:29 -07:00
Aaron Patterson
7c4e0401d2 cleaning up PostgreSQLAdapter#select 2010-07-12 16:54:00 -07:00
Aaron Patterson
cee2ff2768 these strings do not need to be frozen 2010-07-12 16:43:20 -07:00
Aaron Patterson
8fb838ed16 use Hash#each to avoid a second hash lookup 2010-07-12 16:32:45 -07:00
José Valim
6b29dc876f Just add connection management middleware if running in a concurrent environment. 2010-07-12 20:18:54 +02:00
José Valim
da84c9d0d2 Remove old rubygems require. 2010-07-12 20:18:04 +02:00
Santiago Pastorino
d030f830cf Fixes a regression caused by having mapping options controller and action as blank 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-12 19:47:28 +02:00
Jaime Iniesta
4209cb97e3 Merge branch 'master' of github.com:lifo/docrails 2010-07-12 18:24:56 +02:00
Jaime Iniesta
cf69a01079 Getting started guide: typos and changelog 2010-07-12 18:23:13 +02:00
José Valim
3d7e411953 Routes should respect namespace even if action is a regexp and just controller is given to to. 2010-07-12 15:11:53 +02:00
Steven Hancock
1a35b6215f Removed deprecated |map| block argument from routing docs since it is no longer generated in edge Rails config/routes.rb 
Didn't touch plugins guide since I'm not too clear on how routes work in plugins.
 2010-07-11 23:57:26 -07:00
Santiago Pastorino
725090942f We shouldn't rely on float comparison, delta added just in case float representation of this values aren't equal 2010-07-12 09:59:52 +08:00
Santiago Pastorino
913aeaef81 We need to wait for the final release of bundler for this to make sense 2010-07-11 18:04:00 -03:00
Jaime Iniesta
1dddc79fee Getting started guide: Post validation example is clearer if we do p=Post.new;p.save better than p=Post.create;p.save 2010-07-11 21:47:31 +02:00
Jaime Iniesta
b0fab0c5c4 Getting started guide: rephrase the paragraph about the root route for better understanding 2010-07-11 19:17:36 +02:00
Santiago Pastorino
060ca6abce Add missing require to use Set 2010-07-11 02:55:47 -03:00
Santiago Pastorino
16c14f7465 Avoid interpreted as grouped expression warnings 2010-07-11 02:55:38 -03:00
Aaron Patterson
f33ee69d59 reducing funcalls, cleaning up primary key methods for sqlite adapter 2010-07-10 13:30:49 -07:00
Aaron Patterson
0bac4c7e02 primary key behavioral tests 2010-07-10 13:29:12 -07:00
Aaron Patterson
51783c0298 behavioral tests for sqlite adapter 2010-07-10 13:21:56 -07:00
Jeremy Kemper
80e47d7b88 Revert "Revert "Bump bundler to 1.0.0.beta.3"" 
It's out for reals!

This reverts commit 951dbf06b4.
 2010-07-09 20:55:59 -07:00
Aaron Patterson
1e1af8f612 adding more behavioral tests for the sqlite adapter 2010-07-09 17:12:29 -07:00
Xavier Noria
c81e476d6d missing article, only seen in github's colored diff by the beard of the prophet 2010-07-10 00:56:17 +02:00
Xavier Noria
86d5c728fb revises recent commit related to :uniq => true 2010-07-10 00:50:59 +02:00
Neeraj Singh
44b752bea1 expanding on :uniq option in has_many 2010-07-09 16:39:34 -04:00
Xavier Noria
2f04c87855 Merge remote branch 'docrails/master' 2010-07-09 22:08:24 +02:00
Xavier Noria
c9ae2c11eb application.rb: revises the comment for autoload_paths so that is assumes less from the user, and unifies punctuation 2010-07-09 19:09:47 +02:00
Jaime Iniesta
c6f4c5916e Minor typos: 'built-in' instead of 'built in', 'built into' instead of 'built in to' 2010-07-09 17:53:47 +02:00
Norman Clarke
d7ffa3c077 Describe recent changes in Multibyte::Chars. 2010-07-08 19:24:44 -03:00
José Valim
d9ebc76d70 Refactor previous commits a bit. 2010-07-08 23:45:10 +02:00
David Trasbo
786342e17f Return from ActiveRecord::Base#attributes= unless value is a hash [#4070 state:committed] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 23:24:20 +02:00
Neeraj Singh
1e53404fe9 reset_counter should work with non-traditional belongs_to and polymorphic belongs_to 
[#4984 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 23:24:12 +02:00
José Valim
87f64ef05e Improve a bit the code in latest commits. 2010-07-08 22:59:41 +02:00
Norman Clarke
6f83a57ac7 Improve bang method defs, make slice! operate in-place. [#5028 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:59:24 +02:00
Neeraj Singh
01629d1804 This patch changes update_attribute implementatino so: 
- it will only save the attribute it has been asked to save and not all dirty attributes

- it does not invoke callbacks

- it does change updated_at/on

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:43:18 +02:00