github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,318 Commits 34 Branches 105 Tags
bc556a21e2d5722f42dfac810c04d453076e09fb
Commit Graph

19318 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Santiago Pastorino
bc556a21e2 Remove unused var 2010-11-14 15:34:07 -02:00
Jason Cheow
93c9f4a942 Fix bug where size of through association is not correct after adding a has_many association (occurs only before main object has been reloaded). 
[#5968 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-14 15:32:52 -02:00
José Valim
fae4264a7e Update the guides. 2010-11-14 16:22:21 +01:00
Robert Pankowecki
88688cdd8e Fix when database column name has some symbolic characters. [#5818 state:resolved] 2010-11-14 17:24:31 +08:00
raggi
e6d14279b8 Add support for try to just yield the object to a block if no method is to be called. Kind of like a tap_if_present. 2010-11-14 17:23:44 +08:00
Larry Sprock
f43e5d160b HashWithIndifferentAccess should not change the subclass of an array 2010-11-14 17:14:47 +08:00
Santiago Pastorino
293c8a4de5 Tests added for rendering partial with layout, when the partial contains another render layout with block call added missing fixtures 2010-11-13 13:40:36 -02:00
Santiago Pastorino
e3b68e5f6b Tests added for rendering partial with layout, when the partial contains another render layout with block call 2010-11-13 13:38:40 -02:00
Santiago Pastorino
27f4ffd11a Make collection and collection_from_object methods return an array 
This transforms for instance scoped objects into arrays and avoid unneeded queries

[#5958 state:committed]
 2010-11-13 04:02:57 -02:00
Yehuda Katz
7cc371a032 Allow bundler 1.1 (and 1.2, etc.) in Rails 1.0.2 and above 2010-11-12 18:36:55 -06:00
Franck Verrot
983976ec54 Finder gives a little bit more info on the lookup column (primary key) 2010-11-13 06:32:08 +08:00
Santiago Pastorino
b15d816166 Update to JQuery 1.4.4 
Check out http://blog.jquery.com/2010/11/11/jquery-1-4-4-release-notes/
for information on what's new.
 2010-11-12 13:02:17 -02:00
Santiago Pastorino
b734e192a7 present? is better here 2010-11-11 19:00:33 -02:00
José Valim
c63600576a Remove whitespaces and add missing test. 2010-11-11 20:07:47 +01:00
José Valim
f912a359aa Merge remote branch 'drogus/plugin_new' 
Conflicts:
	railties/test/generators/app_generator_test.rb
 2010-11-11 19:39:21 +01:00
Franck Verrot
de2933e1a0 STI type is now updated when calling AR::Base.becomes on subclasses [#5953 state:resolved] 2010-11-12 02:17:34 +08:00
Santiago Pastorino
296e5c38f1 Use ! instead of not 2010-11-11 15:24:49 -02:00
Santiago Pastorino
894fd28859 Fixed bug in active_record/nested_attributes where an empty string id caused an ActiveRecord::RecordNotFound error. Found by [Ben Tillman] 
[#5638 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-11 15:23:40 -02:00
Santiago Pastorino
ceef719924 Bump Arel up to 2.0.2 2010-11-11 15:05:12 -02:00
Rob Zolkos
bafa1533f4 skip testing framework if app created with --skip-test-unit [#5796 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-11 17:35:18 +01:00
José Valim
37d3266f35 Add missing autoload. 2010-11-11 17:30:24 +01:00
zhengjia
8a6ac4fc26 Remove unused Configurable in Rails::Engine and Rails::Application. Remove unnecessary railties load path in cli [#5871 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-11 17:29:39 +01:00
Neeraj Singh
793967cd40 provide better error message if path is uri [#5914 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-11 17:27:47 +01:00
Jeff Kreeftmeijer
154e5d735e The model generator shouldn't throw warnings when using mass nouns [#5363 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-11 17:24:23 +01:00
Neeraj Singh
fbaf3a23d9 fields_for should treat ActiveRecord::Relation as an array 
[#5795 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-11 17:14:47 +01:00
José Valim
a897402863 Remove inline comment. 2010-11-11 17:07:06 +01:00
Marcelo Giorgi
2bb1c202b4 Make after_filter halt when before_filter renders or redirects [#5648 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-11 17:05:07 +01:00
Carlos Antonio da Silva
7846fb79e1 Fix render partial with layout and no block 
When using a render :partial with :layout call, without giving a block,
if the given :partial had another render :partial call, the layout was
not being rendered. This commit fixes this context by storing variables
before rendering the partial, so they are not overrided in any successive
call to render partials down the path. All ActionPack tests are ok.
 2010-11-11 16:22:39 +01:00
Carlos Antonio da Silva
50c7aab996 Fix issue with rendering partials and then yielding inside a render layout call 
The given block was never being executed when another render :partial call
existed before the yield call, due to the block being overriden.

This commit also adds some more tests to render with :layout option.
 2010-11-11 16:22:39 +01:00
Aditya Sanghi
920660b19c patching to ensure separator is printed with order [#5816 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-11 12:22:15 -02:00
José Valim
9c9f416d39 Allow AR Session Store to be renewed 2010-11-11 14:17:14 +01:00
Santiago Pastorino
2651a87a33 Duck typing here 2010-11-11 01:33:27 -02:00
Alvaro Bautista
5dc7f34dca Fix ActiveSupport::TimeWithZone#localtime method with DateTime 
[#5344 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-11 01:30:28 -02:00
Xavier Noria
c577e90f61 restores the example for fixed-width font in API guidelines 2010-11-10 23:46:00 +01:00
Santiago Pastorino
7a2be37592 Remove copy_instance_variables_from from guides 2010-11-10 19:12:10 -02:00
Santiago Pastorino
c20838596b Remove unused method 2010-11-10 16:57:12 -02:00
Denis Odorcic
b961c6c158 Remove useless cgi 
[#5943 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-10 16:43:26 -02:00
Xavier Noria
41366cdec6 syncs CHANGELOGs for 3.0.2 in 3-0-stable with the ones in master 2010-11-09 20:56:41 +01:00
Santiago Pastorino
88a559d414 Double negation of an already boolean value produces the same result 2010-11-09 16:53:03 -02:00
Santiago Pastorino
75dfd95618 Don't check if persisted is defined just initialize it properly 2010-11-09 16:00:02 -02:00
Santiago Pastorino
994a1c2a47 Execute less operations 2010-11-09 14:03:09 -02:00
David Chelimsky
1f06652a57 use persisted? instead of new_record? wherever possible 
- persisted? is the API defined in ActiveModel
- makes it easier for extension libraries to conform to ActiveModel APIs
  without concern for whether the extended object is specifically
  ActiveRecord

[#5927 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-09 13:54:04 -02:00
Xavier Noria
f57b5197b3 registers number_to_currency's :negative_format in the CHANGELOG 2010-11-09 09:37:32 +01:00
Andrew White
ef46b9f21a Strip regexp anchors from rake routes output [#5934 state:resolved] 2010-11-09 05:24:10 +00:00
Piotr Sarnacki
cc135e3b6d Allow to set dummy application path through options 2010-11-08 22:43:51 +01:00
Santiago Pastorino
4e0477c9b7 Test cache.key_file_path with separators ht. Jim Wilson [#5611] 2010-11-07 20:02:14 -02:00
Denis Odorcic
c452d734f2 Fix FileStore cache incorrectly regenerating its key from a pathname when a regexp is used in expire_fragment 
[#5850 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-07 20:01:51 -02:00
Michael Koziarski
3d6eea0221 Update the validates_uniqueness_of documentation to tell you to use a unique index. 
The other options mentioned were not good ideas and disclaimed as such in the documentation.
 2010-11-08 10:16:40 +13:00
Michael Koziarski
9ecaa80300 Make safe_append= live on AV::OutputBuffer not AS::SafeBuffer 
Conflicts:

	actionpack/lib/action_view/template/handlers/erb.rb
 2010-11-08 10:10:30 +13:00
Jan Maurits Faber
f04ec6a227 Added support for Erubis <%== tag 
<%== x %> is syntactic sugar for <%= raw(x) %>

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#5918 status:committed]
 2010-11-08 09:55:55 +13:00