Santiago Pastorino
bf22b287a4
Do not use primary key on insertion when it's nil
2010-12-29 01:22:43 -02:00
Neeraj Singh
27d0d4fffd
while defining callbacks option :rescuable => true
...
can be passed. There were no tests for this case.
This patch adds a test for :rescuable => true
option.
2010-12-29 05:32:23 +08:00
Xavier Noria
6b43a3a627
complete revision of the Contributing to Ruby on Rails guide
...
* adds instructions for PostgreSQL
* adds references to mysql2 here and there
* puts documentation contributions on par with code contributions
* adds a section about Rails Contributors
* documents C dependencies for Nokogiri and the database libs
* everything double-checked and revised step by step
* adds a section about warnings in the test suite
* removes section about the Rails wiki
* title and filename renamed
* overall rewording
2010-12-28 20:36:42 +01:00
Santiago Pastorino
eb2ebe7680
Simplify inspect implementation
...
After 304d38c053
2010-12-28 15:45:35 -02:00
Santiago Pastorino
304d38c053
Allow primary_key to be an attribute when the model is a new record
2010-12-28 10:11:27 -02:00
Aaron Patterson
897b56bb2f
I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2.
2010-12-27 12:47:30 -07:00
José Valim
ecc83c1e6e
Clean up PathSet.
2010-12-27 10:15:54 +01:00
José Valim
6b099975fa
No need to symbolize these.
2010-12-27 09:30:36 +01:00
José Valim
51a7d9acdd
Final tidy up on templates inheritance.
2010-12-27 09:14:13 +01:00
wycats
e03e1fdbc8
Speed up template inheritance and remove template inheritance option
2010-12-26 23:56:09 -08:00
wycats
7c568fda6b
A bunch of cleanup on the inherited template patch
2010-12-26 23:44:51 -08:00
artemave
6c5a3bb312
all tests pass
2010-12-26 22:32:15 -08:00
artemave
ce21ea7832
#948 make template inheritance optional
2010-12-26 22:32:15 -08:00
artemave
ddd85ef9c6
#948 template_inheritance
2010-12-26 22:32:15 -08:00
Aaron Patterson
9bac649fa4
try not to make so many funcalls
2010-12-26 20:22:13 -07:00
Aaron Patterson
67da590979
make our hash of klasses and ids actually have classes for keys
2010-12-26 20:15:09 -07:00
Aaron Patterson
7e91ad3f89
stop calling deprecated apis
2010-12-26 19:56:18 -07:00
Jon Leighton
9f5c18ce07
Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst other things
2010-12-26 16:27:12 -07:00
Xavier Noria
57420dffb6
small rewording of my entry in the credits
2010-12-26 21:27:00 +01:00
Xavier Noria
71775807c1
no docs credits are written in first person, thanks to Vijay Dev for spotting this
2010-12-26 21:15:33 +01:00
Jon Leighton
b0498372a1
Add a HasAssociation module for common code for has_* associations
2010-12-26 19:38:04 +00:00
Jon Leighton
0c272471fe
Remove AssociationProxy#dependent? - it's badly named and only used in one place
2010-12-26 19:38:04 +00:00
Jon Leighton
e8ada11aac
Associations: DRY up the code which is generating conditions, and make it all use arel rather than SQL strings
2010-12-26 19:38:04 +00:00
Jon Leighton
f2230c06ed
Fix dodgy tests which were effectively asserting nil == nil
2010-12-26 19:38:04 +00:00
Jon Leighton
7021b6b851
Remove custom_select param from construct_select, as it isn't used
2010-12-26 19:38:04 +00:00
Jon Leighton
d7a659334c
Remove construct_from from ThroughAssociationScope - it's not called from anywhere
2010-12-26 19:38:04 +00:00
Jon Leighton
93861d19e3
Set the create scope to an empty hash in ThroughAssociationScope. For reasoning please see the inline code comments.
2010-12-26 18:46:58 +00:00
Jon Leighton
ac67eee4e6
Use conditionals and implicit returns rather than explicit returns and postfix ifs (it's easier to read)
2010-12-26 18:46:58 +00:00
Jon Leighton
739ea1fbfe
Remove has_cached_counter? and cached_counter_attribute_name from HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation
2010-12-26 18:46:58 +00:00
Jon Leighton
99db97a322
Remove pointless use of 'private'
2010-12-26 18:46:58 +00:00
Jon Leighton
3eef0977e1
Use the through association proxy for operations on the through record, so that those operations are automatically scoped and therefore construct_join_attributes does not need to use construct_owner_attributes.
2010-12-26 18:46:58 +00:00
Jon Leighton
b5c30f9dac
Remove target_obsolete? which is not called from anywhere
2010-12-26 18:46:58 +00:00
Jon Leighton
c6e0433ca3
scoped.where_values_hash is never nil
2010-12-26 18:46:58 +00:00
Santiago Pastorino
57f5fe1850
Update JQuery UJS
2010-12-26 08:34:47 -02:00
Santiago Pastorino
e9a04320d7
Update Prototype UJS
2010-12-26 08:28:13 -02:00
Akira Matsuda
a329e7d9af
use https to fetch files from GitHub
...
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
[#6223 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-12-26 08:20:36 -02:00
Aaron Patterson
d767252d72
refactor to use group_by
2010-12-25 16:47:59 -07:00
Aaron Patterson
bde643fbec
arel will deal with casting the ids, so we can delete this
2010-12-25 16:42:49 -07:00
Aaron Patterson
75ac9c4271
use arel to determine selection column
2010-12-25 16:38:59 -07:00
Aaron Patterson
33b5a2637f
refactoring method selection
2010-12-25 16:36:07 -07:00
Aaron Patterson
5b918bb97c
using arel to compile sql statements
2010-12-25 16:19:59 -07:00
Aaron Patterson
0a609eea50
use sql literal factory method
2010-12-25 15:25:11 -07:00
Aaron Patterson
a6fe244e9b
take more advantage of arel sql compiler
2010-12-25 15:23:45 -07:00
Aaron Patterson
3fe9951fcc
refactoring AST building
2010-12-25 14:34:13 -07:00
Aaron Patterson
f855090a78
use arel to compile SQL statements
2010-12-25 14:31:22 -07:00
Aaron Patterson
ec13305b21
stop redifining methods on every call to set_primary_key
2010-12-24 22:15:41 -07:00
Aaron Patterson
23b03baba6
use the sql literal factory method
2010-12-24 16:01:07 -07:00
Aaron Patterson
0fbf829b1e
stop the recursive insanity
2010-12-24 15:59:02 -07:00
Aaron Patterson
34d79fad85
setting the primary key on the update manager
2010-12-24 15:59:02 -07:00
Santiago Pastorino
2cbf948f25
Bump up rack-cache
2010-12-24 14:38:18 -02:00
