Mislav Marohnić
c2ca73c9ee
ActiveModel::Observing: stop using Observable Ruby module, re-implement notify_observers
...
`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
callback chains) and has extra features (like `changed`) that were never used.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-16 13:09:07 -07:00
Mislav Marohnić
cf616e4876
merge callbacks_observers_test.rb into lifecycle_test.rb where other observers test reside
...
Benefits: test able to run independently, subclassing instead of changing the original Comment model
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-16 13:09:07 -07:00
Aaron Patterson
779723a0b4
fix a failure and some warnings on 1.9.2 [ #4417 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-04-16 09:03:42 -07:00
Santiago Pastorino
9c08ccd889
page_cache_extension is delegating to config so no need to deprecate
2010-04-16 11:03:16 -03:00
Santiago Pastorino
5699de1d15
Added test get to js should have a header with content-type text/javascript
2010-04-16 11:03:16 -03:00
Santiago Pastorino
8a8da68d1f
Tidy up a bit this test file
2010-04-16 11:03:16 -03:00
Santiago Pastorino
462a7b45f6
Revert "Add test case which check content type when rendering rjs" partial in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag
...
This reverts commit dc251389d1
2010-04-16 11:03:16 -03:00
Mislav Marohnić
8a91ccf976
add missing requires to Rescuable and RouteSet [ #4415 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-04-16 06:11:38 -07:00
Michael Koziarski
5aa58cc03f
Split the observer railtie into two phases.
...
Observers observing models with scopes defined will require the connection to be established.
2010-04-16 09:49:06 +12:00
Santiago Pastorino and Carl Lerche
0ea434e2f4
Make perform_caching work again, with the tests passing and backward compatible
2010-04-15 18:25:08 -03:00
Santiago Pastorino and Carl Lerche
005c2bac46
Revert "logger added to the deprecated config accessor" we need a major refactor to get this working
...
This reverts commit 68f4e046a7
2010-04-15 16:58:31 -03:00
Nicolas Sanguinetti
4bce5ba600
Avoid deprecation warnings and potential TypeErrors [ #4404 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-04-15 14:51:25 +01:00
Santiago Pastorino
68f4e046a7
logger added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
0ee2d3c89a
protected instance variables added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
ab808a9d71
asset and helper path added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
eb8c7b4639
page_cache added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
a618ad358a
Make use of config.perform_caching
2010-04-14 22:35:13 -07:00
Matthew Rudy Jacobs
fc22552e5f
action_dispatch/routing/deprecated_mapper needs with_options
...
[#4398 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 21:43:35 -07:00
Santiago Pastorino
a0cc94b32e
utc_offset returns nil for unknown zones
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 21:15:15 -07:00
Santiago Pastorino
e79193f852
Test for unknown zone with nil utc_offset
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 20:27:24 -07:00
Jeremy Kemper
8539e4ee73
Merge branch 'master' of github.com:rails/rails
2010-04-14 17:16:36 -07:00
wycats
14f8e17563
Merge branch 'master' of github.com:rails/rails
2010-04-14 17:15:20 -07:00
wycats
8c3bfa4ce9
Rely specifically on 0.6.0 and add a missing require
2010-04-14 17:15:13 -07:00
Santiago Pastorino
399d5338ac
Fix missing dependency on Hash#to_query
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 17:14:50 -07:00
Jeremy Kemper
ef6cdc974f
Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled
2010-04-14 17:04:33 -07:00
Xavier Noria
6be04c4631
i18n -> AS/i18n
2010-04-14 02:30:02 -07:00
Xavier Noria
dd635ec701
adds missing requires for arel and i18n, prevents Arel constant from being autoloaded (which was still seen), though it probably hides an issue related to dependencies
2010-04-14 02:01:55 -07:00
Xavier Noria
9a4fdff0af
Merge commit 'docrails/master'
2010-04-14 01:00:03 -07:00
Diego Carrion
e090898c5e
fixed typo in RUNNING_UNIT_TESTS
2010-04-14 13:15:51 +10:00
Ryan Bigg
d45cacc837
Use <plain> instead of <text>
2010-04-14 13:15:51 +10:00
Pratik Naik
2ff5f38abb
Ensure not to load the entire association when bulk updating existing records using nested attributes
2010-04-14 01:52:29 +01:00
Craig Davey
5208cc3cf5
Changed translate helper so that it doesn’t mark every translation as safe HTML. Only keys with a "_html" suffix and keys named "html" are considered to be safe HTML. All other translations are left untouched.
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-04-13 17:35:10 -07:00
Santiago Pastorino
0ab2ba336f
config.perform_caching added to the deprecated config accessor [ #4383 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-13 16:20:49 -07:00
Chetan Sarva
9059472177
Added tests for config.action_controller.perform_caching
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-13 16:20:34 -07:00
Xavier Noria
0e274639b4
removes unnecessary assignment and local variable in AR::Base#subclasses, and revises its rdoc
2010-04-13 16:11:36 -07:00
José Valim
c88b9337cf
Allow a Rails application to be initialized from any directory and not just from inside it (ht: Andre Arko).
2010-04-14 00:02:00 +02:00
Santiago Pastorino
bd34df00cf
Bring back bin/rails to life on edge
2010-04-13 14:23:38 -07:00
wycats
8e9df34fa3
Merge branch 'master' of github.com:rails/rails
2010-04-13 14:07:46 -07:00
José Valim
b4fd5e6f1a
template_name and template_path should not be added to mail headers.
2010-04-13 23:04:22 +02:00
Stanko Alexander
dc251389d1
Add test case which check content type when rendering rjs partial in html template
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-13 13:09:41 -07:00
Anil Wadghule
518891f490
Use correct RUBY_PLATFORM regex for Windows env [ #4385 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-13 12:39:03 -07:00
David Heinemeier Hansson
8116a2b981
Cleanup indention and spacing and turn errorExplanation into error_explanation now that nobody depends on it anymore
2010-04-13 12:33:34 -07:00
David Heinemeier Hansson
5c897270c2
Simple release script
2010-04-13 12:26:15 -07:00
David Heinemeier Hansson
4c8af9bf51
Update changelogs for release
2010-04-13 12:14:54 -07:00
Jeremy Kemper
4d098327da
Fix regexp typo
2010-04-13 12:06:12 -07:00
Santiago Pastorino
7fa6c16b70
Added missing require and delete unused one on proc.rb
2010-04-13 13:33:16 -03:00
Anil Wadghule
fe0b52befb
Changes in guide as per Rails 3 features
2010-04-13 12:25:44 +05:30
Norman Clarke
dceef0828a
Improve reliability of Inflector.transliterate. [ #4374 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-12 23:19:39 -07:00
wycats
36f3634a6a
Add a test that used to fail but is fixed now [ #3417 state:resolved]
2010-04-12 21:57:40 -07:00
Craig R Webster
54533d28ef
Fix a typo in the documentation. [ #4318 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 21:45:39 -07:00
