Jeremy Kemper
5c0656c9ee
Fix layouts in symlinked paths. Closes #9136 [court3nay, caio]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 20:54:26 +00:00
Jeremy Kemper
6efee90bf2
Missing :js template falls back to :html, so you don't have to explicitly specify template format everywhere, breaking old code
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 20:21:52 +00:00
Jeremy Kemper
4942e5b1cb
Whitespace + formatting
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-25 21:27:57 +00:00
David Heinemeier Hansson
b0bfcca16e
Fixed that FormHelper#radio_button would produce invalid ids ( closes #11298 ) [harlancrystal]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-24 21:32:50 +00:00
David Heinemeier Hansson
123f5a357d
Added :confirm option to submit_tag ( closes #11415 ) [miloops]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9087 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-24 21:24:40 +00:00
David Heinemeier Hansson
0e62c773f6
Fixed NumberHelper#number_with_precision to properly round in a way that works equally on Mac, Windows, Linux ( closes #11409 , #8275 , #10090 , #8027 ) [zhangyuanyi]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-24 21:12:55 +00:00
Rick Olson
5bf4cbbdb7
Allow the #simple_format text_helper to take an html_options hash for each paragraph. Closes #2448 [Francois Beausoleil, thechrisoshow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-24 02:29:30 +00:00
Jeremy Kemper
bd940d98bd
Re-added ActionView::Helpers::register_javascript/stylesheet_expansion to make it easier for plugin developers to inject multiple assets. Closes #10350 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-20 16:26:04 +00:00
David Heinemeier Hansson
54213dadfd
Docfixes ( closes #11356 , #11172 , #10523 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-20 02:15:29 +00:00
Jeremy Kemper
e87d3e3335
Revert [9106]. References #10350 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-19 19:56:07 +00:00
David Heinemeier Hansson
3c0fd445c0
Added :format option to NumberHelper#number_to_currency to enable better localization support #11149 [lylo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9052 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-17 22:08:25 +00:00
David Heinemeier Hansson
5f5822af37
Fixed that TextHelper#excerpt would include one character too many ( closes #11268 ) [Irfy]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9030 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-15 19:59:34 +00:00
Pratik Naik
58c30f6135
Move tests from action_view_test.rb to template_finder_test.rb so that they get run by default take task. [Pratik]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-13 11:52:53 +00:00
David Heinemeier Hansson
e915379a10
Added ActionView::Helpers::register_javascript/stylesheet_expansion to make it easier for plugin developers to inject multiple assets ( closes #10350 ) [lotswholetime]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-13 02:31:45 +00:00
Pratik Naik
a96272a0c5
Moved template handlers related code from ActionView::Base to ActionView::Template
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8981 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-05 02:03:24 +00:00
Pratik Naik
89ee5d63d0
Tests for div_for and content_tag_for helpers. Closes #11223 [thechrisoshow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-05 01:26:24 +00:00
Michael Koziarski
51b6619d4e
Refactor partial rendering into a PartialTemplate class. [Pratik]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-03 04:01:35 +00:00
Michael Koziarski
4673c47d7b
Allow html_options to be passed to all the date helpers. Closes #6000 [h-lame, Jakob S]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-02 04:40:54 +00:00
Michael Koziarski
6da3771346
Fix regexp to contain only one rjs, and add rhtml [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-01 00:01:28 +00:00
Michael Koziarski
cd937e6ad7
Make date_helper use tag and content_tag. Move to assert_dom_equal instead of assert_equal to avoid being dependent on hash ordering. Closes #11131 [ernesto.jimenez]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-20 04:23:18 +00:00
Geoff Buesing
3025ff28cc
Tests for distance_of_time_in_words with TimeWithZone instances. Closes #10914 [ernesto.jimenez]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-16 21:16:03 +00:00
Michael Koziarski
86cb0a61fb
Ensure that :confirm doesn't need extra quotes when using drop_receiving_element. Closes #8299 [thechrisoshow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-16 00:07:52 +00:00
Michael Koziarski
692dbbf793
Introduce a Template class to ActionView. Closes #11024 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-06 04:26:40 +00:00
Jeremy Kemper
0da2aa6d11
Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75 ). Closes #9883 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 06:16:04 +00:00
Jeremy Kemper
9d79e0668d
Fix number_to_human_size incorrectly removing trailing zeros. Closes #10099 [libc, developingchris]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 02:59:10 +00:00
Michael Koziarski
10aa728e8b
Don't repeatedly add relative_url_root to asset sources. Closes #10767 [tomtoday, Koz]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-27 01:10:48 +00:00
Michael Koziarski
9f1fdcc27d
Handle corner case with image_tag when passed 'messed up' image names. Closes #9018 [duncanbeevers, mpalmer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-25 04:13:50 +00:00
Michael Koziarski
c0110a9faa
Refactor template compilation from AV::Base into the template handlers. Closes #10888 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-22 01:46:34 +00:00
Michael Koziarski
7701e6466d
Add label_tag helper for generating elements. Closes #10802 [DefV]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-21 21:08:28 +00:00
Michael Koziarski
61c90a4ad6
Reapply the TemplateFinder first applied in [8669] then reverted in [8676]. Closes #10800 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-21 20:45:04 +00:00
Jeremy Kemper
88bc014acc
Revert r8669 for now, breaks Action Mailer. Reopens #10800 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-19 06:01:57 +00:00
Jeremy Kemper
84b0f9c739
Introduce TemplateFinder to handle view paths and lookups. Closes #10800 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-19 03:20:39 +00:00
Michael Koziarski
7e1c04d866
Allow users to declare other namespaces when using the atom feed helpers. Closes #10304 [david.calavera]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-13 00:11:39 +00:00
David Heinemeier Hansson
5d1a305f06
Fixed ActionView::Helpers::ActiveRecordHelper::form for when protect_from_forgery is used ( closes #10739 ) [jeremyevans]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-11 16:25:23 +00:00
Michael Koziarski
e6de95889d
* Pass around handler instances, not their classes [Koz]
...
* Move compilation, rendering and 'compilable?' checks into the Handlers [Koz]
* Remove delegate_* methods as the handler is now an instance [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-11 04:45:06 +00:00
Jeremy Kemper
3600536b04
Ruby 1.9 compat: account for hash ordering
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-07 08:10:23 +00:00
Jeremy Kemper
a1b0349362
The asset_host block takes the controller request as an optional second argument. Example: use a single asset host for SSL requests. Closes #10549 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-06 20:53:23 +00:00
Jeremy Kemper
9d755f1983
require abstract_unit directly since test is in load path
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-05 13:32:06 +00:00
Rick Olson
744b1d7f4d
Fix atom_feed_helper to comply with the atom spec. Closes #10672 [xaviershay]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-02 19:45:53 +00:00
Jeremy Kemper
001fe6a435
Fix failing date helper test. Closes #10664 [Wesley Moxam]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-02 18:09:52 +00:00
Rick Olson
58cf6df41a
Fix that auto_link looks for ='s in url paths (Amazon urls have them). Closes #10640 [bgreenlee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-28 20:59:30 +00:00
Jeremy Kemper
a81333f115
Add :default option to time_zone_select. Closes #10590 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-21 22:18:07 +00:00
Jeremy Kemper
0333190d1a
Rails 1.9 compat: asset tag helper tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-21 12:26:51 +00:00
Jeremy Kemper
7630b38e22
Ruby 1.9 compat: compiled templates test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-21 12:26:27 +00:00
Jeremy Kemper
79790df40c
Ruby 1.9 compat: note failing form options helper test, probably in html-scanner
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-21 12:25:55 +00:00
Jeremy Kemper
a4c77f9bc4
Ruby 1.9 compat: text helper
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-21 11:51:17 +00:00
Jeremy Kemper
f16cd7220f
Ruby 1.9 compat: ENV.delete rather than assigning nil
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8452 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-20 22:27:37 +00:00
David Heinemeier Hansson
d6859a7216
Add tests for html_escape, and remove an unneeded backslash ( closes #10511 ) [fxn]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-16 23:53:45 +00:00
David Heinemeier Hansson
56e646296a
Added option to pass proc to ActionController::Base.asset_host for maximum configurability ( closes #10521 ) [chuyeow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-16 23:50:02 +00:00
Jeremy Kemper
9aca06fbee
More Action View refactoring. Knock :erb default down a notch. Closes #10455 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-10 23:14:47 +00:00