github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-25 06:18:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,316 Commits 34 Branches 105 Tags
c2ed453880539fbc27fc0e00a95fbcf9949d0ed6
Commit Graph

1316 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
c2ed453880 Fix quote_bound_value to not map Strings #1416 [htonl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 10:13:37 +00:00
David Heinemeier Hansson
bdf51f9582 Revealed the man behind the mask! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:46:22 +00:00
David Heinemeier Hansson
253a2bbefb Allow any Enumerable, not just Array, to work as bind variables #1344 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:44:48 +00:00
David Heinemeier Hansson
a895be0259 Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:42:49 +00:00
David Heinemeier Hansson
a7a1c4e2cd Added cuba to country list #1351 [todd] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
ec6f0a1f51 Fixed radio_button to work with numeric values #1352 [demetrius] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:34:08 +00:00
David Heinemeier Hansson
665ab93761 Added :extension option to NumberHelper#number_to_phone #1361 [delynnb] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4 Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
70757cb273 Fix spelling 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:12:15 +00:00
David Heinemeier Hansson
791e66b2da Fixed the test_helper.rb to be safe for requiring controllers from multiple spots, like app/controllers/article_controller.rb and app/controllers/admin/article_controller.rb, without reloading the environment twice #1390 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:08:55 +00:00
David Heinemeier Hansson
89e06ed4c6 Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
a32303e0fc Fixed Webrick to escape + characters in URL's the same way that lighttpd and apache do #1397 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:01:52 +00:00
David Heinemeier Hansson
5b3bc3139a Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
a3659d5835 Fixed Time#at_beginning_of_week returned the next Monday instead of the previous one when called on a Sunday #1403 [jean.helou@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:56:49 +00:00
David Heinemeier Hansson
4351419ba5 Added -e/--environment option to script/runner #1408 [fbeausoleil@ftml.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:50:24 +00:00
David Heinemeier Hansson
691562746f Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
bfe6a759c2 Added actual database-changing behavior to collection assigment for has_many and has_and_belongs_to_many #1425 [Sebastian Kanthak] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:35:10 +00:00
David Heinemeier Hansson
7b47f150fd Its Iraq, not Irak #1443 [ivan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8 Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700 
Ticket 1394 - Helper isolation
 r1319@iwill:  jeremy | 2005-06-15 01:10:00 -0700
 Formulate a test case for helper isolation.
 r1331@iwill:  jeremy | 2005-06-15 15:21:07 -0700
 Update changelog
 r1332@iwill:  jeremy | 2005-06-15 15:21:30 -0700
 Remove superfluous, broken layout_test
 r1333@iwill:  jeremy | 2005-06-15 15:24:10 -0700
 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class.  Create a new helper module for subclasses which includes its superclass' helper module.  Remove unnecessary ActionView::Base.controller_delegate.  Update helper tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f render(:template) applies a layout by default. render("foo/bar") works with a layout again. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
280c224b43 Reverted changeset #1326 coming off ticket #1230 since it caused stale caches to be shared.. nasty 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 09:16:23 +00:00
David Heinemeier Hansson
cb79118111 Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216, #1404 [nilsga] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 04:17:45 +00:00
Jamis Buck
ac1fa98bb9 Removed the require hack used in functional tests that worked around an earlier bug in rake. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 16:17:56 +00:00
Jamis Buck
ed7bfc9662 Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 15:19:03 +00:00
Jamis Buck
3cb869eab6 Resync with html-scanner (fix parser bug) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:56:46 +00:00
Jamis Buck
75fb0a32a8 Support :render option to :verify #1440 [TobiasLuetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:23:55 +00:00
Jamis Buck
b2b757be39 Fix broken test case caused by change of testing address from 127.0.0.1 to 0.0.0.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 10:31:31 +00:00
Jamis Buck
c23b2a4ad3 Updated vendor copy of html-scanner lib, for bug fixes and optimizations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 10:30:36 +00:00
David Heinemeier Hansson
bca13f727e Changed test requests to come from 0.0.0.0 instead of 127.0.0.1 such that they don't trigger debugging screens on exceptions, but instead call rescue_action_in_public 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 08:04:49 +00:00
Jeremy Kemper
1d9905a67f r1307@iwill: jeremy | 2005-06-13 19:05:00 -0700 
Ticket 1312 - Malformed habtm finder sql
 r1308@iwill:  jeremy | 2005-06-13 19:58:48 -0700
 Add a habtm with an unquoted condition to Project.
 r1309@iwill:  jeremy | 2005-06-13 19:59:46 -0700
 Space out habtm finder conditions.
 r1310@iwill:  jeremy | 2005-06-13 20:00:16 -0700
 Test habtm.find with quoted and unquoted conditions.
 r1311@iwill:  jeremy | 2005-06-13 20:00:25 -0700
 Update changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1414 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 21:51:43 +00:00
Jeremy Kemper
2e6f6ced42 r1300@iwill: jeremy | 2005-06-13 18:31:29 -0700 
Ticket 1436 - Faster indifferent hash
 r1301@iwill:  jeremy | 2005-06-13 18:45:28 -0700
 Apply, tweak, test.
 r1305@iwill:  jeremy | 2005-06-13 18:50:24 -0700
 Updated changelog.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 20:40:11 +00:00
Jamis Buck
37a370d8d4 Be sure to use the @finder_sql in the has_many association's #find method, even if explicit conditions have not been given. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 12:03:33 +00:00
Jamis Buck
e0537acaeb Added ActiveRecord::Recursion to guard against recursive calls to #save 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 10:52:53 +00:00
Jeremy Kemper
76e4c1a558 r1294@iwill: jeremy | 2005-06-13 02:17:42 -0700 
Ticket #1281
 r1295@iwill:  jeremy | 2005-06-13 02:50:50 -0700
 Apply patch, tweak, and test.
 r1296@iwill:  jeremy | 2005-06-13 02:51:04 -0700
 Changelog entry.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 04:42:36 +00:00
Leon Breedt
fa7f4a0664 Add workaround for SOAP4R changing find_mapped_soap_class return value [Shugo Maeda] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 03:22:01 +00:00
Leon Breedt
887e67c80e Fix moduled controller URLs in WSDL, and add unit test to verify the generated URL. 
See ticket #1428.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 02:58:44 +00:00
Jeremy Kemper
1fde44bfee r1278@iwill: jeremy | 2005-06-12 05:11:48 -0700 
Branch for PostgreSQL schema.  Ticket #827.
 r1281@iwill:  jeremy | 2005-06-12 19:06:43 -0700
 remove search_path from PostgreSQL db definition
 r1282@iwill:  jeremy | 2005-06-12 19:07:50 -0700
 Rakefile support for database-specific tests.
 r1283@iwill:  jeremy | 2005-06-12 19:10:18 -0700
 Add schema_search_path attribute to PostgreSQL adapter.  Replace table_structure with column_definitions which finds the given table_name in the schema search path.
 r1284@iwill:  jeremy | 2005-06-12 19:12:10 -0700
 Unit test PostgreSQL schema search path.
 r1285@iwill:  jeremy | 2005-06-12 19:12:20 -0700
 Changelog entry.
 r1286@iwill:  jeremy | 2005-06-12 20:08:20 -0700
 Don't try to quote schema names.  Include a reference to the PostgreSQL schema docs.
 r1287@iwill:  jeremy | 2005-06-12 20:16:07 -0700
 SchemasTest -> SchemaTest


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 22:05:30 +00:00
Jeremy Kemper
c4a3634929 Corrected @@configurations typo. #1410 [david@ruppconsulting.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 13:32:06 +00:00
Jeremy Kemper
d0bd3b5af4 Return PostgreSQL columns in the order they are declared #1374 (perlguy@gmail.com). Unit test column order, adapter housekeeping, simplify users of columns_hash. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 06:56:51 +00:00
Jeremy Kemper
3cb26e9cb3 r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700 
Branch to have scaffold use new render methods
 r2496@sedna:  jeremy | 2005-05-28 10:50:51 -0700
 axe unused process_request method
 r2497@sedna:  jeremy | 2005-05-28 10:51:58 -0700
 sanity assertions in process method check that @controller, @request, @response are set
 r2498@sedna:  jeremy | 2005-05-28 10:53:42 -0700
 clean up escaping.  use instance_variable_get instead of instance_eval.  put id in form action instead of hidden input (like the generated scaffolding)
 r2499@sedna:  jeremy | 2005-05-28 10:54:46 -0700
 clean up interpolation, remove tabs from stylesheet
 r2500@sedna:  jeremy | 2005-05-28 10:56:40 -0700
 modernize dynamic scaffolding.  use params[:id] instead of @params[id].  use consolidated render method instead of render_action, render_file, etc.  use builtin inflections rather than module methods.
 r2501@sedna:  jeremy | 2005-05-28 11:00:26 -0700
 modernize generated scaffolding.  use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
 r2542@sedna:  jeremy | 2005-06-12 02:24:06 -0700
 use :id => model instead of :id => model.id.  clean up the form helper method.  use flash[:notice] instead of flash['notice'].
 r2543@sedna:  jeremy | 2005-06-12 02:33:22 -0700
 whitespace
 r2544@sedna:  jeremy | 2005-06-12 02:56:57 -0700
 update changelogs
 r2545@sedna:  jeremy | 2005-06-12 03:26:23 -0700
 test dynamic form help when @post is not a new record
 r2546@sedna:  jeremy | 2005-06-12 03:44:14 -0700
 touch up TestCase#process sanity assertions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 05:33:23 +00:00
Jeremy Kemper
dedb9c8483 Don't expect fixtures to be returned in the order they were inserted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 02:27:19 +00:00
Jeremy Kemper
68b19ea7f3 Don't expect fixtures to be returned in the order they were inserted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-11 20:56:12 +00:00
Jeremy Kemper
cd033c63c2 Preserve extendedWarranty case in PostgreSQL computers table. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-11 20:26:07 +00:00
Jamis Buck
d79838fdcb Allow before/after update hooks to work on models with optimistic locking 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-11 10:06:47 +00:00
Jamis Buck
2c0fa32088 Do not use instantiated fixtures (in general) in tests. Also, support the use of transactional fixtures by setting the AR_TX_FIXTURES environment variable to "yes". 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 14:58:02 +00:00
Jamis Buck
7f9ffb2ebf Eager loading of dependent has_one associations won't delete the association #1212. Also, starting to refactor the tests to make them speedier, with optional support for transactional fixtures. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 13:54:58 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 12:21:25 +00:00
Jamis Buck
6cff8487ed Fixture for new test in [1395] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-08 10:29:17 +00:00
Jamis Buck
29d6d15fc3 Silently ignore Errno::EINVAL errors when converting between charsets. Some mail clients apprently send X-UNKNOWN to represent unknown charsets, and this caused the conversion to blow up. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-08 10:18:26 +00:00