github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-25 06:18:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,316 Commits 34 Branches 105 Tags
c2ed453880539fbc27fc0e00a95fbcf9949d0ed6
Commit Graph

430 Commits

Author SHA1 Message Date
David Heinemeier Hansson
c2ed453880 Fix quote_bound_value to not map Strings #1416 [htonl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 10:13:37 +00:00
David Heinemeier Hansson
bdf51f9582 Revealed the man behind the mask! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:46:22 +00:00
David Heinemeier Hansson
253a2bbefb Allow any Enumerable, not just Array, to work as bind variables #1344 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:44:48 +00:00
David Heinemeier Hansson
bfe6a759c2 Added actual database-changing behavior to collection assigment for has_many and has_and_belongs_to_many #1425 [Sebastian Kanthak] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:35:10 +00:00
Jeremy Kemper
1d9905a67f r1307@iwill: jeremy | 2005-06-13 19:05:00 -0700 
Ticket 1312 - Malformed habtm finder sql
 r1308@iwill:  jeremy | 2005-06-13 19:58:48 -0700
 Add a habtm with an unquoted condition to Project.
 r1309@iwill:  jeremy | 2005-06-13 19:59:46 -0700
 Space out habtm finder conditions.
 r1310@iwill:  jeremy | 2005-06-13 20:00:16 -0700
 Test habtm.find with quoted and unquoted conditions.
 r1311@iwill:  jeremy | 2005-06-13 20:00:25 -0700
 Update changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1414 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 21:51:43 +00:00
Jamis Buck
37a370d8d4 Be sure to use the @finder_sql in the has_many association's #find method, even if explicit conditions have not been given. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 12:03:33 +00:00
Jamis Buck
e0537acaeb Added ActiveRecord::Recursion to guard against recursive calls to #save 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 10:52:53 +00:00
Jeremy Kemper
76e4c1a558 r1294@iwill: jeremy | 2005-06-13 02:17:42 -0700 
Ticket #1281
 r1295@iwill:  jeremy | 2005-06-13 02:50:50 -0700
 Apply patch, tweak, and test.
 r1296@iwill:  jeremy | 2005-06-13 02:51:04 -0700
 Changelog entry.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-13 04:42:36 +00:00
Jeremy Kemper
1fde44bfee r1278@iwill: jeremy | 2005-06-12 05:11:48 -0700 
Branch for PostgreSQL schema.  Ticket #827.
 r1281@iwill:  jeremy | 2005-06-12 19:06:43 -0700
 remove search_path from PostgreSQL db definition
 r1282@iwill:  jeremy | 2005-06-12 19:07:50 -0700
 Rakefile support for database-specific tests.
 r1283@iwill:  jeremy | 2005-06-12 19:10:18 -0700
 Add schema_search_path attribute to PostgreSQL adapter.  Replace table_structure with column_definitions which finds the given table_name in the schema search path.
 r1284@iwill:  jeremy | 2005-06-12 19:12:10 -0700
 Unit test PostgreSQL schema search path.
 r1285@iwill:  jeremy | 2005-06-12 19:12:20 -0700
 Changelog entry.
 r1286@iwill:  jeremy | 2005-06-12 20:08:20 -0700
 Don't try to quote schema names.  Include a reference to the PostgreSQL schema docs.
 r1287@iwill:  jeremy | 2005-06-12 20:16:07 -0700
 SchemasTest -> SchemaTest


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 22:05:30 +00:00
Jeremy Kemper
c4a3634929 Corrected @@configurations typo. #1410 [david@ruppconsulting.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 13:32:06 +00:00
Jeremy Kemper
d0bd3b5af4 Return PostgreSQL columns in the order they are declared #1374 (perlguy@gmail.com). Unit test column order, adapter housekeeping, simplify users of columns_hash. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 06:56:51 +00:00
Jeremy Kemper
dedb9c8483 Don't expect fixtures to be returned in the order they were inserted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 02:27:19 +00:00
Jeremy Kemper
68b19ea7f3 Don't expect fixtures to be returned in the order they were inserted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-11 20:56:12 +00:00
Jeremy Kemper
cd033c63c2 Preserve extendedWarranty case in PostgreSQL computers table. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-11 20:26:07 +00:00
Jamis Buck
d79838fdcb Allow before/after update hooks to work on models with optimistic locking 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-11 10:06:47 +00:00
Jamis Buck
2c0fa32088 Do not use instantiated fixtures (in general) in tests. Also, support the use of transactional fixtures by setting the AR_TX_FIXTURES environment variable to "yes". 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 14:58:02 +00:00
Jamis Buck
7f9ffb2ebf Eager loading of dependent has_one associations won't delete the association #1212. Also, starting to refactor the tests to make them speedier, with optional support for transactional fixtures. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 13:54:58 +00:00
Jamis Buck
b0a35b6fe9 Sort the migration files explicitly so that they are always ordered correctly. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-07 17:00:43 +00:00
David Heinemeier Hansson
7411af95db Replace the in-memory object, but dont orphan the existing one 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-07 12:48:37 +00:00
David Heinemeier Hansson
2bdaff4a4e Added a second parameter to the build and create method for has_one that controls whether the existing association should be replaced (which means nullifying its foreign key as well). By default this is true, but false can be passed to prevent it. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1392 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-06 21:10:59 +00:00
Jamis Buck
ba254b5494 Using transactional fixtures now causes the data to be loaded only once, for BIG speed improvements 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-03 16:06:38 +00:00
Jamis Buck
6d9ee4a306 Added fixture accessors that can be used when fixture instantiation is disabled, "model_name(:fixture_name)" 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-03 11:49:34 +00:00
David Heinemeier Hansson
dab360e181 Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]. Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:51:08 +00:00
David Heinemeier Hansson
3022ee84cc Added note of limitation for #1279 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:23:35 +00:00
David Heinemeier Hansson
a1e9ceebd5 Added Errors#add_on_blank which works like Errors#add_on_empty, but uses Object#blank? instead. CHANGED: validates_presence_of now uses Errors#add_on_blank, which will make " " fail the validation where it didnt before #1309. Added that " " is now also blank? (using strip if available) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:12:36 +00:00
David Heinemeier Hansson
10eb22cdce Added the :if option to all validations that can either use a block or a method pointer to determine whether the validation should be run or not. #1324 [Duane Johnson/jhosteny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 10:57:18 +00:00
David Heinemeier Hansson
c8b4cf65df Speed up timestamping a tad #1227 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:05:12 +00:00
David Heinemeier Hansson
47dcc5ffc6 Fixed use of construct_finder_sql when using :join #1288 [dwlt@dwlt.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:23:28 +00:00
David Heinemeier Hansson
190e04645b Fixed that :delete_sql in has_and_belongs_to_many associations couldn't access record properties #1299 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1313 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:07:56 +00:00
David Heinemeier Hansson
b3fcf2fa3c Fixed docs for scaffolding generator #1303 [thijs@vandervossen.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:00:16 +00:00
David Heinemeier Hansson
6ea6a725c4 Push to .org instead 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:42:47 +00:00
David Heinemeier Hansson
bd79a4eb3b Fixed that clone would break when an aggregate had the same name as one of its attributes #1307 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:39:50 +00:00
David Heinemeier Hansson
c8bd316754 Changed that destroying an object will only freeze the attributes hash, which keeps the object from having attributes changed (as that wouldn't make sense), but allows for the querying of associations after it has been destroyed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 16:48:07 +00:00
David Heinemeier Hansson
24a9050b6e Changed the callbacks such that observers are notified before the in-object callbacks are triggered. Without this change, it wasn't possible to act on the whole object in something like a before_destroy observer without having the objects own callbacks (like deleting associations) called first. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 16:46:30 +00:00
David Heinemeier Hansson
cce294fd71 Started work on a per-request query cache 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 07:04:20 +00:00
David Heinemeier Hansson
5f77f64e92 Added option for passing an array to the find_all version of the dynamic finders and have it evaluated as an IN fragment 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 05:34:27 +00:00
David Heinemeier Hansson
b921b5da15 Fixed association picture reference 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:55:25 +00:00
David Heinemeier Hansson
2bf223051e Added compatibility with camelCase column names for dynamic finders #533 [Dee.Zsombor] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:49:28 +00:00
David Heinemeier Hansson
eefe4d0ddd Fixed extraneous comma in count() function that made it not work with joins #1156 [jarkko/Dee.Zsombor] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:45:15 +00:00
David Heinemeier Hansson
787951348b Fixed incompatibility with Base#find with an array of ids that would fail when using eager loading #1186 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 14:04:01 +00:00
David Heinemeier Hansson
9f1b57779f Fixed that validate_length_of lost :on option when :within was specified #1195 [jhosteny@mac.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 14:02:03 +00:00
David Heinemeier Hansson
06f1895ac6 A few more tests #1199 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 13:24:43 +00:00
David Heinemeier Hansson
9ede45f60f Added encoding and min_messages options for PostgreSQL #1205 [shugo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 13:21:47 +00:00
David Heinemeier Hansson
b09fde1924 Fixed acts_as_list where deleting an item that was removed from the list would ruin the positioning of other list items #1197 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-25 16:11:31 +00:00
David Heinemeier Hansson
d8fc381ebc Added validates_exclusion_of as a negative of validates_inclusion_of 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-24 16:25:57 +00:00
David Heinemeier Hansson
56412f4441 Optimize counting of has_many associations by setting the association to empty if the count is 0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-23 18:18:18 +00:00
David Heinemeier Hansson
83a531ed5b Fixed frivilous database queries being triggered with eager loading on empty associations and other things 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 17:05:54 +00:00
David Heinemeier Hansson
3140e37d18 Dont reload on empty associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 16:59:30 +00:00
David Heinemeier Hansson
6f34400086 Fixed order of loading in eager associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 16:32:57 +00:00
David Heinemeier Hansson
5462358cd3 Fixed that :get, :post, and the others should take a flash array as the third argument just like process #1144 [rails@cogentdude.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 11:04:38 +00:00