Commit Graph

3061 Commits

Author SHA1 Message Date
Emilio Tagua
c57f94d730 Merge commit 'rails/master' 2009-08-21 17:43:32 -03:00
Jeremy Kemper
8bc3a14727 Benchmark script via miloops' arel fork via DataMapper's AR comparison script 2009-08-20 21:09:59 -07:00
Emilio Tagua
0c6aed0a09 Add bench script for ActiveRecord. Ignore log file and temporary cache
sql files.
2009-08-20 18:58:12 -03:00
Emilio Tagua
a60334fdc5 Remove useless conditionals/local var. 2009-08-19 19:36:06 -03:00
Emilio Tagua
54fcbb881d Make sure join association methods are called once. 2009-08-19 17:45:13 -03:00
Emilio Tagua
b32474020c Don't sanitize_sql where it doesn't make sense. 2009-08-19 16:29:26 -03:00
Emilio Tagua
ccf5f2c4a2 Remove old method and comment. 2009-08-19 16:17:16 -03:00
Emilio Tagua
3e1ef198e0 Remove useless InnerJoinDependency, inner joins are performed through
Arel::InnerJoin.
2009-08-19 16:08:54 -03:00
Emilio Tagua
2048556a14 Remove whitespace. 2009-08-19 11:09:12 -03:00
Emilio Tagua
c36cfa7568 Remove unused quoted_record_ids, now ARel does this using ARel::In. 2009-08-18 20:03:32 -03:00
Emilio Tagua
a09215ee96 has_many nullify associations keys using ARel. 2009-08-18 20:02:14 -03:00
Emilio Tagua
a7178773d2 Remove now unused quote_table_name, ARel does that quoting now. 2009-08-18 19:53:21 -03:00
Emilio Tagua
d5476b466f habtm insertion with ARel integration. 2009-08-18 19:51:41 -03:00
Emilio Tagua
c1f833dff4 habtm delete method integrated with ARel. 2009-08-18 19:38:34 -03:00
Emilio Tagua
0abba2813b Call to_sql method on ActiveRecord::Relation instance not it's relation
attribute.'
2009-08-18 19:38:03 -03:00
Emilio Tagua
74ed123e08 Override respond_to? in ActiveRecord::Relation to go with
method_missing.
2009-08-18 16:35:33 -03:00
Emilio Tagua
fefb4c78ac Cache arel_table when possible, use class method arel_table instead
instance method.
2009-08-18 16:28:04 -03:00
Emilio Tagua
0d6997b6e3 Cache #arel_able when possible. 2009-08-18 14:49:11 -03:00
Emilio Tagua
60926db9e0 Inline initializer setup. 2009-08-18 14:22:38 -03:00
Emilio Tagua
66fbcc1de6 Use immutable relation objects to generate queries. 2009-08-18 14:10:03 -03:00
Emilio Tagua
ac03bc91db Use explicit method definition instead of metaprogramming. 2009-08-18 08:27:37 -03:00
Emilio Tagua
fa8f5c2667 Relation#joins! should know what to join instead of delegating to
construct_join.
2009-08-18 08:18:24 -03:00
Emilio Tagua
08f6af2d53 Fix typo in test classname. 2009-08-18 08:12:35 -03:00
Emilio Tagua
79e951ca9b Use finder options as relation method names to provide more familiar
naming. Use bang methods convention in methods that alter the
relation.
2009-08-18 07:50:11 -03:00
Emilio Tagua
c923409630 Clean up relation joins when finding records with included associations. 2009-08-17 20:17:40 -03:00
Emilio Tagua
4b339f44bd Merge commit 'rails/master' 2009-08-17 19:46:32 -03:00
Emilio Tagua
c01c8967a0 Merge commit 'rails/master'
Conflicts:
	activerecord/lib/active_record/calculations.rb
2009-08-17 19:46:06 -03:00
Pratik Naik
25e5b0c4a8 Remove support for SQLite 2.
If you're still using it, please install the plugin from git://github.com/rails/sqlite2_adapter.git
2009-08-17 14:54:34 +01:00
Emilio Tagua
770fca10fb Remove group when building the relation, it will be added later if
options[:group] is given.
2009-08-16 17:27:45 -03:00
Jay Pignata
7213da37ce Fix test_has_many_through_polymorphic_has_one on sqlite2 [#3054 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-08-15 19:14:32 -07:00
Jay Pignata
cb3e669b0d Fix calculation tests on sqlite2 [#3053 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-08-15 19:14:11 -07:00
Jeremy Kemper
76335c27b6 Bump pg gem requirement to 0.8.0. Build psql db with UTF8 encoding. 2009-08-15 19:04:25 -07:00
Emilio Tagua
796ec652ad Don't use regular rinder on calculations since scoping order blows
PostreSQL.
2009-08-14 15:59:55 -03:00
Emilio Tagua
48c1e6d584 Merge commit 'rails/master' 2009-08-14 12:34:38 -03:00
Emilio Tagua
9ac01fad19 Use ARel's joins when building a query for finding records with included
associations.
2009-08-14 12:33:05 -03:00
Joshua Peek
c6bc8e6626 Break up concerns for choosing what attributes should be serialized and the actual serializer 2009-08-13 22:27:36 -05:00
Emilio Tagua
b68ef73344 Merge commit 'rails/master' 2009-08-11 12:41:49 -03:00
Pratik Naik
0a558b36eb Add tests for hm:t#push failures 2009-08-11 02:37:04 +01:00
Emilio Tagua
10af9fae4a Merge commit 'rails/master' 2009-08-10 18:19:24 -03:00
Emilio Tagua
0e2fbd80e2 Merge commit 'rails/master'
Conflicts:
	activerecord/lib/active_record/calculations.rb
	activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
	activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
2009-08-10 18:07:33 -03:00
Pratik Naik
d0f891ae02 Rewrite hm:t#create tests using assert_no_difference and assert_difference 2009-08-10 21:30:44 +01:00
Pratik Naik
ad28e0037b Remove unnecessary scoping for creating hm:t join record 2009-08-10 21:20:01 +01:00
Pratik Naik
50b83984f1 Remove unnecessary scoping and validation checks from hm:t#create 2009-08-10 21:06:49 +01:00
Pratik Naik
d9c4087a9e Unify hm:t#create and create! implementation 2009-08-10 21:02:06 +01:00
Joshua Peek
f97dae5ebe Extract common dirty tracking methods in AMo 2009-08-10 13:51:48 -05:00
Joshua Peek
391f978acd AMo overrides alias_attribute and manages aliasing all known attribute method matchers 2009-08-10 11:58:44 -05:00
Arthur Zapparoli
55b5cf586a Fixed typo in test name and CHANGELOG [#3017 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-08-10 16:13:18 +01:00
Emilio Tagua
eb3ae44cca Merge commit 'rails/master'
Conflicts:
	activerecord/lib/active_record/migration.rb
2009-08-10 10:40:11 -03:00
Cristi Balan
3e35ba2481 Add tests for scoping schema_migrations index by global table prefix and suffix
[#1543 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-08-09 22:59:04 -07:00
Tim Peters
7eaed4fefe Use table prefix and suffix for schema_migrations index.
[#1543 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-08-09 22:56:37 -07:00