Commit Graph

5535 Commits

Author SHA1 Message Date
Jeremy Kemper
ccb87e2f69 BufferedLogger#add converts the message to a string. Closes #9724.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 14:09:35 +00:00
David Heinemeier Hansson
bbdb4e55f6 Added :include option to to_json (closes #9677) [chuyeow]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 14:07:23 +00:00
David Heinemeier Hansson
078bd0515e Added fixture caching thatll speed up a normal fixture-powered test suite between 50% and 100% (closes #9682) [frederick.cheung@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7662 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 14:05:03 +00:00
David Heinemeier Hansson
3c695356ae Fixed the layout defaults (closes #9564) [lifo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 01:23:20 +00:00
Jeremy Kemper
5f4d121798 Dependencies Ruby 1.9 compat
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 11:01:20 +00:00
Jeremy Kemper
053d057a88 send -> send! for some private methods
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7659 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 10:41:12 +00:00
Jeremy Kemper
b01a7c69fc Alias Object#send to send! for Ruby 1.9 forward compatibility.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7658 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 10:38:37 +00:00
Jeremy Kemper
8886036867 Convert the Ruby 1.9 enumerator to an array
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7657 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 10:25:51 +00:00
Jeremy Kemper
42bc9b3b16 Mark String#each_char test failing with Ruby 1.9
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7656 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 10:21:39 +00:00
Jeremy Kemper
db9b2f5c22 Extract InflectorTestCases so both inflector and string inflections tests can use them.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7655 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 10:19:48 +00:00
Jeremy Kemper
935f821537 Object#copy_instance_variables_from Ruby 1.9 compat
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7654 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 10:13:50 +00:00
Jeremy Kemper
f3560d5a95 Mark another Duration test failing with Ruby 1.9
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7653 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 09:54:43 +00:00
Jeremy Kemper
d4e164f670 Prefer class_eval with block to many sends for Ruby 1.9 compat
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 09:52:15 +00:00
Jeremy Kemper
c81bd19b13 Hax to workaround private send for Ruby 1.9. Consider moving to send! and aliasing to send for < 1.9.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7651 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 09:37:45 +00:00
Jeremy Kemper
e36b9b95fe Use instance_variable_defined? instead of instance_variables.include? to account for string/symbol differences between 1.8 and 1.9
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 09:27:37 +00:00
Jeremy Kemper
d96e38be99 Backport Object#instance_variable_defined? for Ruby < 1.8.6.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 09:26:46 +00:00
Jeremy Kemper
7974f4752b Mark Duration test failing with Ruby 1.9
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 08:54:31 +00:00
Jeremy Kemper
cd1f2d7b0e Date/Time/DateTime Ruby 1.9 compat
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 08:49:18 +00:00
Jeremy Kemper
7faeb0db07 Change test for ruby 1.9 crash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 08:09:14 +00:00
Jeremy Kemper
ae165361c3 Cleanup comment. References #9702, closes #9703.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 06:16:20 +00:00
Nicholas Seckar
5430eb6dcd Avoid calling is_missing on LoadErrors. Closes #7460.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 05:04:02 +00:00
Jeremy Kemper
6f06ac6e1a BufferedLogger#add doesn't modify the message argument. Closes #9702.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-27 04:50:58 +00:00
Jeremy Kemper
1c68394b68 Reinstate the default AR.instantiate_observers to_prepare block.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-26 01:29:28 +00:00
Jeremy Kemper
f08da31a4f Move Railties' Dispatcher to ActionController::Dispatcher, introduce before_ and after_dispatch callbacks, and warm up to non-CGI requests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-26 01:24:07 +00:00
David Heinemeier Hansson
6b2226aae9 Fix webrick when using the debugger (closes #9348) [bronson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 19:08:50 +00:00
David Heinemeier Hansson
a4e1b79b07 Fix test (closes #9120) [hasmanyjosh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 19:06:24 +00:00
David Heinemeier Hansson
f65c202416 Use the correct generator name in the docs (closes #9111) [ceefour]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 19:04:52 +00:00
David Heinemeier Hansson
82c1fed89f Protect button_to behind protect_from_forgery (closes #9675) [lifo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:50:35 +00:00
David Heinemeier Hansson
106b236824 Include the tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:48:50 +00:00
David Heinemeier Hansson
6f0390c957 Add BufferedLogger#add #9667 [tomafro]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:41:46 +00:00
David Heinemeier Hansson
42d35472b2 Please do remember
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:40:56 +00:00
David Heinemeier Hansson
7ca53e1d31 Added another failing test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7632 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:37:43 +00:00
David Heinemeier Hansson
2a6f8c99da Doh, forgot this file
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:30:38 +00:00
David Heinemeier Hansson
06dd4b3166 Better failing tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 15:09:21 +00:00
David Heinemeier Hansson
55a9c86e62 Added failing tests for iphone
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7629 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 14:57:15 +00:00
Jeremy Kemper
3b98b68516 Doof. Don't call it with false if it doesn't respond.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 08:51:06 +00:00
Jeremy Kemper
14c1cb4bcb Skip test runner workaround only if Test::Unit is loaded. Closes #9671 [tomafro]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 08:44:26 +00:00
David Heinemeier Hansson
79a9c7a702 Added ActiveSupport::BufferedLogger as a duck-typing alternative (albeit with no formatter) to the Ruby Logger, which provides a very nice speed bump (inspired by Ezra's buffered logger) [DHH] Changed the default logger from Ruby's own Logger with the clean_logger extensions to ActiveSupport::BufferedLogger for performance reasons [DHH]. (You can change it back with config.logger = Logger.new(/path/to/log, level).)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 03:47:37 +00:00
David Heinemeier Hansson
501244fee4 Updated iphone_with_html_response_type to fail as it uses the new register_alias approach
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:44:36 +00:00
David Heinemeier Hansson
89235ba0bb Include the new 422 in the app generation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:31:59 +00:00
David Heinemeier Hansson
bdf5672077 Change from InvalidToken to InvalidAuthenticityToken to be more specific
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:12:25 +00:00
David Heinemeier Hansson
e70bb8031f Stop rdoc from whining
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:01:50 +00:00
Jeremy Kemper
8e78a4542e Object#instance_exec produces fewer garbage methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:00:42 +00:00
David Heinemeier Hansson
eca3b790b5 Give a pointer on where to look for more
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 22:52:35 +00:00
David Heinemeier Hansson
959a1fc22d Added a default 422.html page to be rendered when ActiveRecord::RecordInvalid, ActiveRecord::RecordNotSaved, or ActionController::InvalidToken is raised [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 22:50:43 +00:00
Jeremy Kemper
dfcb5af2dc Move rescue_action_with_handler from rescue_action to perform_action so it isn't clobbered by test overrides. References #9449, closes #9645.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7618 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 19:56:11 +00:00
Jeremy Kemper
40f9fd39f6 Include asset host in public path cache key. Clear cache between asset tag tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 19:47:45 +00:00
Rick Olson
605aadb3cd protect new rails apps from csrf by default.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 18:11:59 +00:00
Michael Koziarski
fc042435a6 Fix ARes tests under jruby. [tom.enebo@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7615 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 18:01:09 +00:00
Rick Olson
2c73115b2f port over some of the csrf_killer README docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 17:59:17 +00:00