github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,032 Commits 34 Branches 105 Tags
ccc8eba4dcdee9ae07788574f7cfffe1e15c2d0a
Commit Graph

17032 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
wycats
ccc8eba4dc Change the generated Gemfile to resolve, via documentation, the issue of rspec generators being unavailable in development mode 2010-06-25 12:19:22 -07:00
Neeraj Singh and Santiago Pastorino
0ebb5bf659 Support for multiple selects added 
[#4841 state:committed]
 2010-06-25 15:57:04 -03:00
Santiago Pastorino
3d8ccb9240 Makes a build_select for the select part of build_arel 2010-06-25 15:06:32 -03:00
Santiago Pastorino
82dc16b7d2 Metaprogramming not needed here 2010-06-25 15:06:32 -03:00
Santiago Pastorino
3344c011da Avoid a blank line before the add/remove columns 2010-06-25 15:06:32 -03:00
Andrew White
5f64bce10f Failing test for whether glob parameters accept regexps 
[#4970 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-25 10:17:28 -07:00
Andrew White
3d8200318a Add failing test case for parameters with periods 
[#2536 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-25 10:12:11 -07:00
Jeremy Kemper
0883b2b0c3 Depend on unreleased rack-mount 0.6.6.pre 2010-06-25 10:11:46 -07:00
José Valim
01472b5217 Do not mark the session as loaded if an error happened while doing it. 2010-06-25 19:03:00 +02:00
José Valim
21c99e9388 Calling exists? in the session store, without checking for stale sessions, was causing the cookie store to panic because we need to unpack the whole session to get its key. This commit fixes this issue and also caches exists calls for performance improvements. 2010-06-25 12:15:17 +02:00
Łukasz Strzałkowski
518b16d9ae Line break in migration template and nicer code indentation 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-25 10:57:05 +02:00
Carlos Antonio da Silva
b01df28413 Do not wrap hidden fields with error proc [#4962 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-25 09:49:29 +02:00
Prem Sichanugrist
617e94658d Make sure that Rails doesn't resent session_id cookie over and over again if it's already there [#2485 state:resolved] 
This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-25 09:41:52 +02:00
José Valim
a12b76b09e Just reading flash messages should not create a session if one does not exist yet. 2010-06-25 09:36:26 +02:00
David Heinemeier Hansson
6682cce038 Dont reload the environment, just not needed bro 2010-06-24 17:38:46 -05:00
Neeraj Singh
4e8ca7bc9a adding missing assertion and fixing the test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:34:51 +02:00
Neeraj Singh
0d2cebe338 fixing test by replacing assert with assert_equal 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:34:46 +02:00
José Valim
73682d016c Merge remote branch 'miloops/fixes' 2010-06-24 20:19:19 +02:00
Prem Sichanugrist
67ee6c38b9 Remove the --singeleton option from scaffold generator. 
It turned out to be that scaffold for singeleton resource will always depend on another model, and it's not possible at the moment to make the application tests pass after generate the singeleton scafold. So, it would be better to remove it for now and probably provide another generator, such as singeleton_scaffold, in which also require the depended model name.

[#4863 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:17:59 +02:00
Santiago Pastorino
7a7c608a26 Your original TIME ZONE value on PostgreSQL is correctly restored now, after going through options :utc and then going back to :local 
[#4950 state:committed]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:12:22 +02:00
Santiago Pastorino
497a0c3b00 quotes are not necessary here 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:12:22 +02:00
Neeraj Singh
81c5684267 adding middleware test for RAILS_CACHE 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:08:50 +02:00
Prem Sichanugrist
974196b091 Remove obsolete test case, since we have move Rails::LogSubscriber to ActiveSupport::LogSubscriber in [6788db824a] [#4816 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 20:05:07 +02:00
José Valim
d69ebb849a Avoid deserializing cookies too early, which causes session objects to not be available yet. Unfortunately, could not reproduce this in a test case. 2010-06-24 20:03:03 +02:00
Emilio Tagua
4b5f417e63 Only yield block if given. 2010-06-24 13:17:24 -03:00
Nick Sieger
b549d93d2f AS::Isolation functional on Windows/JRuby. 
Doesn't make up for the fact that it's slooooooooow, though.

Signed-off-by: wycats <wycats@gmail.com>
 2010-06-24 09:10:58 -07:00
Emilio Tagua
2c203a9413 Remove block definitions in finder methods. 2010-06-24 13:07:39 -03:00
Emilio Tagua
4086ecea24 Remove block definition from method, is not needed since yield is used inside. 2010-06-24 12:02:00 -03:00
Emilio Tagua
d9f199e123 Don't define block, just yield if block is given. 2010-06-24 11:40:23 -03:00
Emilio Tagua
fdb7f84eb1 Remove deprecated block usage in composed_of. 2010-06-24 11:17:05 -03:00
José Valim
7710a8cb6b Ops, this should be beta4. 2010-06-24 04:31:07 -07:00
Andrew White
df15ba7ead Fix namespaced redirects [#4389 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 13:26:24 +02:00
Elomar França
176c386409 Fix bug where ActiveResource::HttpMock would overwrite Accept/Content-Type header to application/xml [#4939 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 13:25:10 +02:00
José Valim
6788db824a Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] 2010-06-24 13:23:43 +02:00
Emilio Tagua
5441e082f9 Add tests for relation count. Fix other tests that were conceptually wrong. 
[#4882 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 11:41:55 +02:00
José Valim
e061a12a15 Remove run_initializers from class methods. 2010-06-24 11:40:22 +02:00
Jeremy Kemper
5eb3b4d9a7 Fix initializable tests 2010-06-24 02:16:59 -07:00
Jeremy Kemper
9f7874ac41 Move Collection responsibility from application to initializable 2010-06-24 02:13:08 -07:00
Jeremy Kemper
cdb8609c64 Speed up boot by tsorting as infrequently as possible 2010-06-24 02:04:00 -07:00
Jeremy Kemper
60ab9255f0 Don't halt railties tests on failures 2010-06-24 02:04:00 -07:00
Jeremy Kemper
0b3dd5718c Array#sample now exists, so test for #forty_two instead 2010-06-24 02:04:00 -07:00
Jeremy Kemper
4883082ff1 Support an extra profile printer arg 2010-06-24 01:08:12 -07:00
Jeremy Kemper
7b730a2f1b Show GC time and # of runs too 2010-06-23 16:11:13 -07:00
José Valim
69abbe8934 Avoid using Pathname on Resolver and AS::Dependencies. 2010-06-24 01:06:37 +02:00
Xavier Noria
6f83a5036d renames load_(once_)paths to autoload_(once_)paths in dependencies and config 2010-06-24 00:17:28 +02:00
Paul Gillard
4a0a640d33 Remove incorrect comment regarding #initialize_copy 
Comment added in #3164 is incorrect after reading http://dev.rubyonrails.org/ticket/7191.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 22:42:17 +02:00
Michael Lovitt
49f52c3d91 Sessions should not be created until written to and session data should be destroyed on reset. 
[#4938]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-23 11:56:35 -07:00
Neeraj Singh
0bf3baa6b3 adding fix for to_xml for ActiveRecord relation object 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 18:00:32 +02:00
Neeraj Singh
eb04408a20 ActiveRecord's relation object should respond to to_json and to_yaml 
[#4547 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 18:00:25 +02:00
Neeraj Singh
a3ce6fcc56 adding column named 'group' to ensure that nothing breaks given that 'group' is sql reserved word 
[#4945 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 17:46:37 +02:00