github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
23,659 Commits 34 Branches 105 Tags
cd48bd2478accbb2638bcfc7e32cb62d3d0ab2cc
Commit Graph

23659 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Arun Agrawal
cd48bd2478 Using not effected timezone in tests. 2011-06-29 01:47:56 +05:30
Aaron Patterson
941d5c1f40 Merge pull request #1857 from vijaydev/irreversible-migration 
IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration
 2011-06-28 12:05:19 -07:00
Aaron Patterson
a5cb5a5af6 Merge pull request #1860 from dmathieu/comparison 
Allow comparison on model objects - Closes #1858
 2011-06-28 11:46:25 -07:00
Aaron Patterson
26caf32949 remove useless assignment 2011-06-28 10:57:56 -07:00
Aaron Patterson
13e79eb6c3 lock_optimistically is typically true, so evaluate the common failure case first 2011-06-28 10:51:23 -07:00
Aaron Patterson
02f45d6e0c reduce object allocation during AR instantiation 2011-06-28 10:22:39 -07:00
José Valim
c290900a77 Merge pull request #1878 from arunagw/mime_test_fix 
Removing image/gif from this test.
 2011-06-28 05:55:50 -07:00
Arun Agrawal
8c1f62acda No need to register again. As it's default now. 
Removing gif from here because when it got unregister it start failing other places.
 2011-06-28 18:20:28 +05:30
José Valim
71d7c52019 Update railties.gemspec 2011-06-28 09:35:46 -03:00
José Valim
e3053ee753 Copy the bin to railties so it also works if you don't have the rails gem. 2011-06-28 09:09:46 -03:00
José Valim
0a873627e4 Merge pull request #1877 from arunagw/fix_mime 
Fix test to use Mime::Zip
 2011-06-28 04:58:29 -07:00
Arun Agrawal
1b957177e7 Fix test to use Mime::Zip 2011-06-28 16:51:19 +05:30
José Valim
76581d0f1b Edited actionpack/CHANGELOG via GitHub 2011-06-28 02:45:27 -07:00
José Valim
4f372cf4d9 Merge pull request #1875 from esad/master 
Fixed issue #1847
 2011-06-28 02:44:04 -07:00
Esad Hajdarevic
2a61d47b55 Make send_file guess content-type from file extension, if type wasn't supplied (Issue #1847). Update tests & documentation. 2011-06-28 06:58:28 +02:00
Esad Hajdarevic
d73269ba53 Register some commonly used mime types (png, jpeg, pdf, zip etc.) per default 2011-06-28 06:56:47 +02:00
Aaron Patterson
9921eca51c remove the check for needs_type_condition? because ensure_proper_type will pick up the type column 2011-06-27 20:44:39 -07:00
Aaron Patterson
4006e738ed stop using && for the short circuit side effect 2011-06-27 18:16:01 -07:00
Aaron Patterson
4ec47cac10 let strings be converted to symbols inside the interpreter 2011-06-27 18:15:28 -07:00
Aaron Patterson
9152126110 avoice paying hash cost if there are no serialized attributes 2011-06-27 17:46:56 -07:00
Aaron Patterson
45b7209f1f cache column defaults for AR object instantiation 2011-06-27 17:45:34 -07:00
Aaron Patterson
06d4247f02 AR object instantiation is ~30% faster in the simple case 2011-06-27 16:15:34 -07:00
Aaron Patterson
5ddb60f2b3 initialize instance variables 2011-06-27 14:47:11 -07:00
Aaron Patterson
6054c092dc oops! remove debugging codes 2011-06-27 14:46:56 -07:00
Aaron Patterson
997aed24be default create_with_value to a hash so we can eliminate conditionals, add test surrounding create_with(nil) behavior 2011-06-27 14:18:49 -07:00
Aaron Patterson
506b2dad55 Merge pull request #1871 from guilleiguaran/arel-2-1-3 
Bump ARel to 2.1.3
 2011-06-27 14:06:00 -07:00
Santiago Pastorino
4bcb05de2d Merge pull request #1870 from chriseppstein/asset_urls_master 
Asset urls master
 2011-06-27 14:01:34 -07:00
Xavier Noria
a0960ec2d4 the generated ALT attribute for images no longer contains the digest, if any 2011-06-27 23:00:05 +02:00
Chris Eppstein
024bed387b Added a configuration setting: 
config.action_controller.default_asset_host_protocol

It's best to leave this unset.

When unset the :request protocol is used whenever it can be and
:relative is used in the other situations.

When set to :request then assets hosts will be disabled when there
is no request in scope and will use the request protocol whenever a
request is in scope.

If set to :relative, then a relative protocol is always used except
for stylesheet link tags which must use the :request protocol to
avoid double downloads in IE6&7.

Conflicts:

	actionpack/lib/sprockets/helpers/rails_helper.rb
	actionpack/test/template/sprockets_helper_test.rb
 2011-06-27 13:58:51 -07:00
Guillermo Iguaran
1c23887ab0 Bump ARel to 2.1.3 2011-06-27 15:58:40 -05:00
Chris Eppstein
2cc1bc3773 Move the config bootstrapping to initialization to minimize access to the Rails.application global. 2011-06-27 13:55:10 -07:00
Chris Eppstein
6c64e1e3a3 Stylesheet link tags should use the request protocol to avoid duplicate download of stylesheets in IE7 and IE8. 
Conflicts:

	actionpack/lib/action_view/helpers/asset_tag_helpers/stylesheet_tag_helpers.rb
	actionpack/lib/sprockets/helpers/rails_helper.rb
 2011-06-27 13:54:54 -07:00
Chris Eppstein
96137e8bd0 Add asset_url helper and refactor the asset paths so that asset hosts can be used during asset precompilation. 
Conflicts:

	actionpack/lib/action_view/asset_paths.rb
	actionpack/lib/sprockets/helpers/rails_helper.rb
	actionpack/test/template/sprockets_helper_test.rb
 2011-06-27 13:48:36 -07:00
Chris Eppstein
266b80c7b2 OrderedOptions must implement respond_to? if it implements method_missing. 2011-06-27 13:44:53 -07:00
David Heinemeier Hansson
f63f0baa59 Add JavaScript Runtime name to the Rails Info properties (thanks Sam Ruby) 2011-06-27 11:59:46 +02:00
David Heinemeier Hansson
449cc3e999 Merge pull request #1481 from arunagw/lib_assets 
Generating /lib/assets  for assets
 2011-06-27 02:16:24 -07:00
Damien Mathieu
eb22c51173 comparing different classes returns nil 2011-06-26 09:41:30 +02:00
Damien Mathieu
bc743dc1ce allow comparison on model objects - Closes #1858 2011-06-26 09:41:08 +02:00
Santiago Pastorino
095f0466c8 Merge pull request #1861 from dchelimsky/fixture_path 
Get the fixture_path from self.class instead of ActiveSupport::TestCase.
 2011-06-25 12:12:49 -07:00
David Chelimsky
a7af1e0051 Get the fixture_path from self.class instead of ActiveSupport::TestCase. 
This allows test classes that are not subclasses of
ActiveSupport::TestCase (like those in rspec-rails) to interact with
with this variable without having to reference ActiveSupport::TestCase.
 2011-06-25 13:59:49 -05:00
Xavier Noria
211fa2d28d Merge pull request #1853 from arunagw/string_parameterize 
StringToParameterizeWithNoSeparator: dashed parameter will not change.
 2011-06-25 06:05:11 -07:00
Vijay Dev
c278a2c5e1 record unsupported methods in CommandRecorder instead of letting the unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations 2011-06-25 17:17:02 +05:30
Arun Agrawal
4700e1fe6e StringToParameterizeWithNoSeparator: dashed parameter will not 
change.
 2011-06-25 06:17:00 +05:30
Xavier Noria
7e56bf7244 registers support for acronyms in the CHANGELOG of Active Support 2011-06-24 23:28:30 +02:00
Xavier Noria
370b380306 Merge pull request #1648 from dlee/acronyms 
Inflector support for acronyms (Issue #1366)
 2011-06-24 14:19:42 -07:00
James Cox
d446c798a5 make the logs a little simpler to view, put the render message inline with other events, pull processing to char[0] and add a new line to the completed. looks more like a block now, which is useful for serial actions like test/dev 2011-06-24 13:10:06 -07:00
Santiago Pastorino
d6413f043c Merge pull request #1848 from raviolicode/postgresql_order_multiple_params 
Fix for complex ordering of multiple columns on postgresql
 2011-06-24 13:09:33 -07:00
Lucia Escanellas
9734a416fa Improve ordering of multiple columns on postgresql 
* Only on postgresql, order("first asc, second asc") was invalid
* Closes #1720
 2011-06-24 13:37:08 -03:00
Santiago Pastorino
7ca1a3d2aa Merge pull request #1840 from wildchild/master 
Minor formatting fix
 2011-06-23 16:47:56 -07:00
Alexander Uvarov
e945497955 Minor formating fix 2011-06-24 03:52:39 +06:00