github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
16,994 Commits 34 Branches 105 Tags
cdb8609c64ed7db7ea91cdcd4bcb4b400f7dfe07
Commit Graph

16994 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
cdb8609c64 Speed up boot by tsorting as infrequently as possible 2010-06-24 02:04:00 -07:00
Jeremy Kemper
60ab9255f0 Don't halt railties tests on failures 2010-06-24 02:04:00 -07:00
Jeremy Kemper
0b3dd5718c Array#sample now exists, so test for #forty_two instead 2010-06-24 02:04:00 -07:00
Jeremy Kemper
4883082ff1 Support an extra profile printer arg 2010-06-24 01:08:12 -07:00
Jeremy Kemper
7b730a2f1b Show GC time and # of runs too 2010-06-23 16:11:13 -07:00
José Valim
69abbe8934 Avoid using Pathname on Resolver and AS::Dependencies. 2010-06-24 01:06:37 +02:00
Xavier Noria
6f83a5036d renames load_(once_)paths to autoload_(once_)paths in dependencies and config 2010-06-24 00:17:28 +02:00
Paul Gillard
4a0a640d33 Remove incorrect comment regarding #initialize_copy 
Comment added in #3164 is incorrect after reading http://dev.rubyonrails.org/ticket/7191.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 22:42:17 +02:00
Michael Lovitt
49f52c3d91 Sessions should not be created until written to and session data should be destroyed on reset. 
[#4938]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-23 11:56:35 -07:00
Neeraj Singh
0bf3baa6b3 adding fix for to_xml for ActiveRecord relation object 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 18:00:32 +02:00
Neeraj Singh
eb04408a20 ActiveRecord's relation object should respond to to_json and to_yaml 
[#4547 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 18:00:25 +02:00
Neeraj Singh
a3ce6fcc56 adding column named 'group' to ensure that nothing breaks given that 'group' is sql reserved word 
[#4945 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 17:46:37 +02:00
David Chelimsky
32b8be9533 Expose view via the view() method in AV::TestCase::Behavior 
- was exposed as _view, which suggested it was private
- left _view as an alias of view as not to break any extensions that are
  relying on _view

[#4932 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 17:45:48 +02:00
David Chelimsky
0e0df4b0c5 In ActionView::TestCase::Behavior, assign variables right before 
rendering the view.

- Previously, _assigns were locked down the first time _view was
  referenced.

[#4931 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 15:07:44 +02:00
Josh Kalderimis
e8c064bbe0 Regression with how base errors messages are added to a model. Works correctly for both string error messages and symbol translated messages. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 14:45:55 +02:00
Mohammed Siddick.E
7008911222 Patch for Namespace problem in Scaffold. [#4763 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 09:30:55 +02:00
Paul Gillard
d132dd3352 Don't clone associations [#4894 state:resolved] 
Cloning an active record object should be shallow in that it should copy attributes but not associations. This was no longer true as a result of #3164.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 09:27:15 +02:00
Santiago Pastorino
ef7a04ea85 Fixes encoding mistakes on old_base/mail_service tests 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 09:26:49 +02:00
Jeff Dean
ac8d3e3aca make text_field and hidden_field omit the value attribute if the developer explicitly passes in :value => nil [#4839 state:resolved] 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2010-06-23 16:23:54 +12:00
Jeff Dean
e639536ea8 remove_column should raise an ArgumentError when no columns are passed [#4803 state:resolved] 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2010-06-23 16:21:29 +12:00
knapo
995b1a243c Fix controller_name for non default controller paths [#4901 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 01:37:52 +02:00
José Valim
ed5c096d60 Tidy up asset tag a bit and make railties tests green again. 2010-06-23 01:34:25 +02:00
Josh Kalderimis
97b773303d refactored the javascript asset tag helpers and moved the default scripts setup within the railtie 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 01:02:59 +02:00
José Valim
a6eeb0865e Update CHANGELOG. 2010-06-23 00:52:20 +02:00
Carlos Antonio da Silva
9651ca751c Add the :path option to match routes when given as symbols. This is specially useful in http helpers for generating routes in scenarios like: 
resources :users, :path => 'usuarios' do
    get :search, :on => :collection, :path => 'pesquisar'
  end

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-23 00:49:15 +02:00
José Valim
61317b643a Provive resources_path_names helpers in the router. 2010-06-23 00:43:25 +02:00
José Valim
e5444f84df Stop filling the blocks scope array with nil. 2010-06-22 23:52:12 +02:00
Carlos Antonio da Silva
aacb83143f Allow namespace accept options in routes [#4936 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 23:37:49 +02:00
José Valim
fef5cf92ed Deprecate :name_prefix in the new router DSL. 2010-06-22 23:30:19 +02:00
Edgars Beigarts
62c4e4d385 Fix connection reloading in development mode. [#4929 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:48:43 +02:00
Neeraj Singh
c0fc084e93 should be able to run ActiveModel validations_test [#4933 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:38:27 +02:00
Santiago Pastorino
f61ac89947 Avoid method redefined warning 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:16:59 +02:00
Trevor Turk
64987d6711 Note that 'rails server' allows specifying mongrel, thin, etc [#4845 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:13:12 +02:00
James Harton
d0df7f1196 Fix small bug where ActiveRecord::PredicateBuilder#build_from_hash didn't test for Arel::Relation as right hand value. [#4917 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 18:05:27 +02:00
Neeraj Singh
7033be5f72 test for #4917 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 18:04:38 +02:00
Paco Guzman
ec37452f68 Remove unused variable on assert_recognizes [#4912 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:37:18 +02:00
Prem Sichanugrist
6c4bab306a Missing require for the class/attribute.rb [4812 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:18:28 +02:00
David Chelimsky
f29fb0dd9e update the list of instance variables that are excluded from assigns in view tests 
[#4930 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:15:56 +02:00
Emilio Tagua
12a9e84799 Clean CHANGELOG whitespace. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 16:44:10 +02:00
Emilio Tagua
7df105b1e6 Fix order method to accept relation attributes. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 16:44:10 +02:00
Emilio Tagua
df595b577e Use the new query API in AR performance script. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 16:44:10 +02:00
David Calavera
b8330a2261 preventing memcached initialization errors with default servers list [#4921 state:resolved] 
As of this writing the JRuby client does not support a default port.

Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-06-22 16:28:29 +02:00
David Calavera
256a33d0fb defines ORIG_ARGV in Active Support's abstract_unit.rb (used in isolation.rb) [#4922 state:resolved] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-06-22 16:27:09 +02:00
rohit
40bf76165c Rails Runner now sets $0 and $PROGRAM_NAME to name of file being run [#2244 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:20:29 +02:00
rohit
9be0b50962 Added 4 tests for Rails Runner. 2 failing tests for $0 and $PROGRAM_NAME [#2244 state:open] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:20:28 +02:00
RainerBlessing
70c932f794 adds minus to value part of id [#4862 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:10:56 +02:00
Neeraj Singh
dcfb9805f2 test for #4862 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:10:49 +02:00
Santiago Pastorino
6ea967729f Avoid method redefined warning 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:09:01 +02:00
David Chelimsky
0576ec4ddd Add support for specifying locals in view tests with assert template [#4927 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 14:51:22 +02:00
José Valim
02399a1184 Ensure overwritten callbacks conditions in controllers work [#4761 state:resolved] [#3913 state:resolved] 2010-06-22 07:57:45 +02:00