github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,254 Commits 34 Branches 105 Tags
cf69a010790d22dc2e66f172437c71ccff2e6366
Commit Graph

17254 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jaime Iniesta
cf69a01079 Getting started guide: typos and changelog 2010-07-12 18:23:13 +02:00
Jaime Iniesta
1dddc79fee Getting started guide: Post validation example is clearer if we do p=Post.new;p.save better than p=Post.create;p.save 2010-07-11 21:47:31 +02:00
Jaime Iniesta
b0fab0c5c4 Getting started guide: rephrase the paragraph about the root route for better understanding 2010-07-11 19:17:36 +02:00
Xavier Noria
c81e476d6d missing article, only seen in github's colored diff by the beard of the prophet 2010-07-10 00:56:17 +02:00
Xavier Noria
86d5c728fb revises recent commit related to :uniq => true 2010-07-10 00:50:59 +02:00
Neeraj Singh
44b752bea1 expanding on :uniq option in has_many 2010-07-09 16:39:34 -04:00
Xavier Noria
2f04c87855 Merge remote branch 'docrails/master' 2010-07-09 22:08:24 +02:00
Xavier Noria
c9ae2c11eb application.rb: revises the comment for autoload_paths so that is assumes less from the user, and unifies punctuation 2010-07-09 19:09:47 +02:00
Jaime Iniesta
c6f4c5916e Minor typos: 'built-in' instead of 'built in', 'built into' instead of 'built in to' 2010-07-09 17:53:47 +02:00
Norman Clarke
d7ffa3c077 Describe recent changes in Multibyte::Chars. 2010-07-08 19:24:44 -03:00
José Valim
d9ebc76d70 Refactor previous commits a bit. 2010-07-08 23:45:10 +02:00
David Trasbo
786342e17f Return from ActiveRecord::Base#attributes= unless value is a hash [#4070 state:committed] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 23:24:20 +02:00
Neeraj Singh
1e53404fe9 reset_counter should work with non-traditional belongs_to and polymorphic belongs_to 
[#4984 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 23:24:12 +02:00
José Valim
87f64ef05e Improve a bit the code in latest commits. 2010-07-08 22:59:41 +02:00
Norman Clarke
6f83a57ac7 Improve bang method defs, make slice! operate in-place. [#5028 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:59:24 +02:00
Neeraj Singh
01629d1804 This patch changes update_attribute implementatino so: 
- it will only save the attribute it has been asked to save and not all dirty attributes

- it does not invoke callbacks

- it does change updated_at/on

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:43:18 +02:00
Neeraj Singh
690352dce4 consolidating updated_at and updated_on 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:41:58 +02:00
Grant Ammons
17650e394f Eager loading :through associations will join the :source model if there are :conditions. [#2362 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:36:26 +02:00
Sudara
e848ab527c Allow a PID file to be specified to rails server [#5031 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:35:02 +02:00
Ken Collins
0e9bc23c0e Fix the #using_limitable_reflections? helper to work correctly by not examining the length of an array which contains false/true, hence always passing. [#4869 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:34:34 +02:00
Thiago Pradi
8b2330ebc3 Tests to specify the behaviour of ActiveRecord::Migrator.get_all_versions() [#5066 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:29:08 +02:00
Łukasz Strzałkowski
4a26a292a0 Removing method before redefining it. It was causing warnings. [#5072 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:29:08 +02:00
Josh Kalderimis
b09fd9ccbb removed an old unused method in AR which removed readonly attributes 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:29:08 +02:00
Neeraj Singh
a4f5f0547f removing unused method 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 22:29:08 +02:00
Aaron Patterson
7b0f8534c7 moving parse_sqlite_config to the sqlite3_connection method (where it belongs) [#5071 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-08 11:52:38 -07:00
Aaron Patterson
9ac9c35117 removing useless code. [#5070 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-08 11:45:42 -07:00
Mislav Marohnić
00f1cd71a9 fix ActiveRecord destroy_all so it returns destroyed records 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-08 11:35:17 -07:00
Jeremy Kemper
951dbf06b4 Revert "Bump bundler to 1.0.0.beta.3" 
(It's not out yet)

This reverts commit 64cee90c0f.
 2010-07-08 10:59:05 -07:00
Jeremy Kemper
64cee90c0f Bump bundler to 1.0.0.beta.3 2010-07-08 10:53:06 -07:00
José Valim
c285f07a92 Change documentation for ActiveModel::MassAssignmentSecurity a bit and make debug always be called since some people may overwrite warn! to add extra behavior even if logger is not available. 2010-07-08 19:02:34 +02:00
Josh Kalderimis
4b66aab00f mass_assignment_security moved from AR to AMo, and minor test cleanup 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 18:28:45 +02:00
Josh Kalderimis
7c86e8e21b minor changes to mass assignment security patch to bring it in line with rails standards 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 18:28:38 +02:00
Eric Chapweske
606088df3f Mass assignment security refactoring 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 18:28:32 +02:00
Neeraj Singh
723a0bbe3a This test never runs and it has never run. Since the day this file 
was created this test has name not beginning with test_. Also this
test is trying to use has_many on another has_many which is not
supported.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-08 18:02:07 +02:00
Xavier Noria
a9587935de copy-edits some docs 2010-07-08 16:53:37 +02:00
Neeraj Singh
4a1207d540 Merge branch 'master' of github.com:lifo/docrails 2010-07-08 10:09:39 -04:00
Neeraj Singh
f6fa6cf611 clarifying how to create non standard primary key 2010-07-08 10:09:20 -04:00
Rohit Arondekar
dc364fdc59 API Docs: Fixes to the Routing docs 2010-07-07 22:15:15 -07:00
Akira Matsuda
bf5d154567 Print proper "Usage:" messages for "rails plugin" command 
* suppress outputting "Unknown command:" when no command were specified
* output the "Usage:" message when no plugin names were given

[#5043 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-07 16:20:56 -07:00
Akira Matsuda
ff44cc2844 whitespace 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-07 16:20:51 -07:00
Ben Somers
de51cbccf8 Fixed gruoped_by_title spelling [#5063 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-07-08 00:26:25 +02:00
Aaron Patterson
c58e7a71b5 adding some behavioral tests for the sqlite adapter. [#5065 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-07 14:25:22 -07:00
Jeremy Kemper
81f398b804 Fix setting helpers_path to a string or pathname 2010-07-07 12:03:08 -07:00
Xavier Noria
64c75d6618 Merge remote branch 'docrails/master' 2010-07-07 12:58:46 +02:00
José Valim
8735d15e61 Add a test to ensure url helpers are not action methods in ActionMailer. 2010-07-07 12:50:38 +02:00
Andrew White
0f96cea322 Add note about incompatibility of namespace and :controller 2010-07-07 05:32:26 +01:00
Andrew White
b802a0d4c7 When a dynamic :controller segment is present in the path add a Regexp constraint that allow matching on multiple path segments. 
Using a namespace block isn't compatible with dynamic routes so we
raise an ArgumentError if we detect a :module present in the scope.

[#5052 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-07 00:11:13 +02:00
Andrew White
f4be0041c6 Refactor handling of :only and :except options. The rules are: 
1. Don't inherit when specified as an option on a resource
2. Don't push into scope when specified as an option on a resource
2. Resources pull in :only or :except options from scope
3. Either :only or :except in nested scope overwrites parent scope

[#5048 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-06 20:46:20 +02:00
Xavier Noria
92ff71bb14 documents automatic management of join models in hmt associations, in particular the gotcha that deletion is direct 2010-07-06 17:29:34 +02:00
Neeraj Singh
ffdbe56d99 Merge branch 'master' of github.com:lifo/docrails 2010-07-06 10:10:05 -04:00