Aaron Patterson
cfca55949f
convert duration to an attr_reader
2010-07-17 16:03:56 -07:00
Santiago Pastorino
cebe5c2fac
It's not needed to initialize the attr when calling mattr_writer
2010-07-18 06:06:58 +08:00
Nick Quaranto
7aec9f9c02
Removing ActionDispatch::Http::FilterParameters#fitered_parameters alias
2010-07-18 06:04:55 +08:00
Aaron Patterson
606d8fdfc8
drained? is never called
2010-07-17 14:45:59 -07:00
Aaron Patterson
fa73e777a1
private method is not needed
2010-07-17 14:44:29 -07:00
Aaron Patterson
4226c93779
removing Binding class
2010-07-17 14:35:44 -07:00
Aaron Patterson
9c80f5b391
use === to avoid regular expression creation, and speed up string comparison
2010-07-17 13:14:38 -07:00
Xavier Noria
631b9564d2
Merge remote branch 'docrails/master'
2010-07-17 20:00:48 +02:00
Xavier Noria
caddee253c
new guide: API Documentation Guidelines, ported and revised from the docrails github wiki
2010-07-17 19:42:44 +02:00
José Valim
c6e2058637
Add skip_eager_load!, skip_autoload! and friends to path objects.
2010-07-17 09:55:11 +02:00
Santiago Pastorino
38f1ea8fe2
Makes test use the new config.action_view.javascript_expansions[:defaults] initialization syntax
2010-07-17 05:53:18 +08:00
Aaron Patterson
42be67e8d4
unfactoring clear_stale_cached_connections!
2010-07-16 14:48:50 -07:00
Aaron Patterson
8d17f53318
adding a test for clearing stale connections
2010-07-16 14:39:40 -07:00
Aaron Patterson
7ba54ff711
fixing test file name
2010-07-16 13:54:14 -07:00
Aaron Patterson
2244bb0013
fixing whitespace errors
2010-07-16 13:50:58 -07:00
Xavier Noria
ef165b355d
minor pass to generated code in application.rb related to :defaults
2010-07-16 21:54:13 +02:00
Aaron Patterson
04ef434b21
only test for existence of +pool+ once
2010-07-16 11:44:29 -07:00
Aaron Patterson
b952470cc2
use an attr_reader for performance
2010-07-16 11:44:29 -07:00
Santiago Pastorino
79d9e0f155
Makes this test don't trust on the speed of execution
2010-07-17 02:39:26 +08:00
Santiago Pastorino
114fa4d431
Adds application.js when app is generated with -J and clear javascript_expansions[:defaults]
2010-07-17 01:59:51 +08:00
Nick Sieger
ea7f1fb026
Don't rely on implementation-specific order-dependence of array comparisons in unit tests
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-07-17 01:59:51 +08:00
Santiago Pastorino
041e47b326
Explain how to change javascript default files
2010-07-17 01:59:50 +08:00
Aaron Patterson
1b2824b659
fixing typeo. thanks bamnet!
2010-07-16 09:13:51 -07:00
Neeraj Singh
1f2a5199cb
moving persistence related tests to a new file
...
Before refactoring test result from AR:
2291 tests, 7180 assertions, 0 failures, 0 errors
After the refactoring test result from AR:
2291 tests, 7180 assertions, 0 failures, 0 errors
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-16 17:26:06 +02:00
Neeraj Singh
c9630d9d87
adding proper markup to comment
2010-07-16 09:58:01 -04:00
Pratik Naik
130bf3c9ed
Fix data loading from the performance script
2010-07-16 08:28:49 +01:00
David Genord II
1fcf4e8ecb
JoinDependency#graft does not properly set parent join [ #5124 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-07-16 08:28:49 +01:00
Xavier Noria
181e0d326d
AS guide: revised the docs of class_attribute and cattr_* macros
2010-07-16 00:48:08 +02:00
Santiago Pastorino
ea0bf4e664
CI should bundle update instead of install so gems are properly updated
2010-07-16 05:52:34 +08:00
Carlos Antonio da Silva
c09cd192aa
Small fix in cookie docs and trailing whitespaces
2010-07-15 18:41:29 -03:00
Łukasz Strzałkowski
06c74cf5fe
Bump bundler to 1.0.0.beta.5
...
[#5102 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-15 13:52:59 -07:00
Santiago Pastorino
fcb230144b
Bump up nokogiri, memcache-client, sqlite3-ruby, fcgi, mail and tzinfo
2010-07-15 13:18:47 -07:00
Santiago Pastorino
3952268929
Bump up to rack-mount 0.6.9 and rack-mount-0.6.6.pre removed from action_dispatch vendor
2010-07-15 13:18:44 -07:00
Jaime Iniesta
5543e8bd6b
Migrations guide: minor typos corrected
2010-07-15 17:42:41 +02:00
Pratik Naik
0c2c893434
Revert "Style fixes"
...
This reverts commit 3c300b3121
2010-07-15 13:17:35 +01:00
Xavier Noria
c7d79a4ce1
Merge remote branch 'docrails/master'
2010-07-15 10:19:31 +02:00
Xavier Noria
897f86a974
layouts and rendering guide: use content_for? instead of the yield or yield idiom
2010-07-15 09:47:22 +02:00
Aaron Patterson
62dd1d8d23
clean up ||= with an initialized variable and attr_reader
2010-07-14 17:53:20 -07:00
wycats
3c300b3121
Style fixes
2010-07-14 17:33:07 -07:00
Aaron Patterson
955b26ac6e
primary_key_name already checks for the model_class
2010-07-14 17:11:52 -07:00
Aaron Patterson
d41a28bcca
use array intersection for dry / faster code
2010-07-14 17:09:14 -07:00
Aaron Patterson
1db8ed0f4b
activerecord tests should inherit from ActiveRecord::TestCase
2010-07-14 16:35:52 -07:00
Aaron Patterson
6a534455f6
remove useless ternary in PostgreSQL adapter
2010-07-14 15:44:15 -07:00
Aaron Patterson
8ba14c238e
PostgreSQLAdapter#query string interpolation calls to_s for us
2010-07-14 15:18:48 -07:00
Aaron Patterson
51c9b666e6
PostgreSQLAdapter#query bail early if there is no column and dry up our conditionals
2010-07-14 15:10:45 -07:00
Aaron Patterson
36150c902b
Let's initialize instance variables in the postgres adapter.
2010-07-14 15:04:14 -07:00
Pratik Naik
d5921cdb7a
Remove unintentional API changes. [ #1108 ]
2010-07-14 18:32:28 +01:00
Pratik Naik
4a06489525
Style fixes
2010-07-14 16:50:26 +01:00
Xavier Noria
b7944e1b21
revises the rdoc of update_attributes and update_attributes! to document they are wrapped in a transaction, and adds code comments explaining why
2010-07-14 17:42:57 +02:00
Xavier Noria
5994567839
AR queying guide: let limit and offset be different numbers to help making clear what is what in the explanation, rewords also a bit
2010-07-14 13:18:07 +02:00
