github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,682 Commits 34 Branches 105 Tags
cff7f53fbcce14f190cc2d993467ba77fe8fa03d
Commit Graph

17682 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
cff7f53fbc do not pass AR objects to ARel 2010-08-04 08:44:53 -07:00
José Valim
7e2399a42f Revert "Put lib back on the autoload path" 
This was causing engines/gems to eager load everything in lib. Another fix is comming soon.

This reverts commit 02a5842cd0.
 2010-08-04 14:13:50 +02:00
wycats
c25c3879ce I'm unsure how cloning was working in Rails 3 before 2010-08-04 04:05:54 -07:00
wycats
847c123ca5 Concernify SanitizeHelper and TextHelper so including TextHelper correctly include SanitizeHelper and extends its ClassMethods 2010-08-04 03:25:57 -07:00
wycats
991cd59a22 If a file is in the load path, require it without its full path (in more places) 2010-08-04 03:25:57 -07:00
wycats
8bf79739b4 require_dependency should require using the normal mechanism if possible to avoid double-requires 2010-08-04 03:25:57 -07:00
Aaron Patterson
6d6ed55324 avoid passing AR::Base objects to Arel when we can 2010-08-03 17:58:56 -07:00
RainerBlessing
7e4e1f0ca5 query value is converted to_s instead of to_yaml 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-03 21:08:43 -03:00
wycats
02a5842cd0 Put lib back on the autoload path 2010-08-03 14:57:55 -07:00
wycats
c0fa4de65b Allow :name to be a Symbol (was this removed by accident?) 2010-08-03 12:22:36 -07:00
Subba Rao Pasupuleti
8d9d8bc93c Tidy up error.rb code 
[#5288 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-03 14:54:13 -03:00
Aaron Patterson
41c1aa607d order query is already a string, no need to to_s 2010-08-03 09:16:01 -07:00
Santiago Pastorino
b8634dddab Stub is_a? not instance_of? here 2010-08-03 12:17:53 -03:00
José Valim
84081fcc54 Freeze options so we raise an error when people modify it in place. 2010-08-03 15:36:23 +02:00
José Valim
f23bc8444b validates_length_of should not change the options hash in place. [#5283 state:resolved] 2010-08-03 15:22:54 +02:00
rohit
621246f997 Failing test for validates_length_of, when both too_short and too_long messages are set [#5283 state:open] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 15:11:51 +02:00
Samuel Lebeau
f01184ad9e Avoid potentially expensive inspect call in router. [#4491 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 11:52:19 +02:00
Curtis Cablegram
e1142dfcae Refactor log-tailer to depend on File#eof? rather than File#mtime 
[#5220 state:resolved]

Eliminate 1 instance variable and 1 local variable.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:50:25 +02:00
Curtis Cablegram
1466f312ba Change log-tailer to properly track multi-byte characters. 
When end-of-line is represented within a file as "\r\n",
it is represented in memory as a single "\n".  This patch eliminates
the discrepancy between size on disk and size in memory.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:50:21 +02:00
Tore Darell
2c8a4a53a8 Remove or fix non-working examples and add a few tests to Dirty [#5185 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:47:30 +02:00
Neeraj Singh
fb2b8fec24 adding test cases for ActiveModel::Errors 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:46:16 +02:00
Neeraj Singh
db1c484c55 Dynamic finder method like scoped_by_* create methods so that 
method_missing is not hit next time. Adding a test for this
scenario.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:46:09 +02:00
Neeraj Singh
807239f5a1 Making Active Record base_test.rb thinner by moving tests 
to relevant files.

Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:45:54 +02:00
Xavier Noria
4dc2521028 Merge remote branch 'docrails/master' into 3-0-stable 2010-08-03 02:15:12 +02:00
Neeraj Singh
db0e3e5ad1 Correcting the documentation which wrongly states that each dynamic finder creates 
method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new
methods.
 2010-08-02 13:10:32 -04:00
Neeraj Singh
d3eacf9352 Adding to AR::Base documentation about dynamically scopeded_by query 
User.scoped_by_user_name('David')
 2010-08-02 13:07:18 -04:00
José Valim
88b5f938cf Bring returning back to ease migration. 2010-08-02 18:40:20 +02:00
Neeraj Singh
1ce40ca562 ensuring that description does not exceed 100 columns 2010-08-02 12:25:26 -04:00
José Valim
9effe3cc18 Remove duplicated logic. 2010-08-02 17:20:17 +02:00
Neeraj Singh
009aa8825b Eager loading an association should not change the count of children 
[#4971 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 17:12:59 +02:00
Neeraj Singh
b8d9d9ce0a updating documentation to ensure line does not exceed 100 columns 2010-08-02 11:09:31 -04:00
Josef Reidinger
59693c4c49 fix loading of different elements in array then int and string [#5036 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 17:06:09 +02:00
José Valim
e1344bf504 Tidy up previous commit. 2010-08-02 16:51:08 +02:00
Robert Pankowecki
f8b53f35b9 test and fix collection_singular_ids= with string primary keys [#5125 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:41:20 +02:00
José Valim
558ee6e95c Handle edge cases in the previous patch. 2010-08-02 16:40:02 +02:00
Fred Wu
cdad483dff Improved how AppGenerator generates the application name. It now detects the current app name whenever possible. This means that renaming the residing directory will not effect the app name generated by AppGenerator. 
[#5225 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:30:20 +02:00
Alex Le
aeaab06c79 ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:26:32 +02:00
Chris Hoffman
59cf514a5b Add missing require in ActiveSupport::HashWithIndifferentAccess [#5189 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:18:33 +02:00
José Valim
2dfeb7bc30 Merge branch 'master' of github.com:rails/rails 2010-08-02 16:17:34 +02:00
José Valim
b613c3cc7b Add an internal (private API) after_touch callback. [#5271 state:resolved] 2010-08-02 16:16:46 +02:00
Jakub Kuźma
311ea94f73 added failing touch propagation test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 15:56:49 +02:00
Santiago Pastorino
e6331b1e97 Makes rails destroy scaffold don't duplicate routes.draw do |map| |map| when using the deprecated syntax 
[#5263 state:committed]
 2010-08-02 10:55:09 -03:00
rohit
c544fcc8eb Failing test to check for route file corruption if legacy map parameter is used. [#5263 state:open] 2010-08-02 10:55:05 -03:00
Neeraj Singh
b29c23a618 ensuring that documentation does not exceed 100 columns 2010-08-01 21:32:36 -04:00
Prashant P. Shah
3b44b52fb0 Corrected the rake test:units and test:functionals description [#5251 state:committed] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-01 22:17:15 -03:00
Santiago Pastorino
111234e7c1 Use AS::OrderedHash when trusting in the order of the hash 2010-08-01 21:56:06 -03:00
Carlos Antonio da Silva
11614bddc0 Fix label form helper to use I18n and html options, without the need of 'nil' text param: 
Before: f.label :title, nil, :class => 'title'
  After : f.label :title, :class => 'title'

[#5267 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-01 21:51:54 -03:00
Santiago Pastorino
fb0bd8c109 Makes form_helper use overriden model accessors 
[#3374 state:committed]
 2010-08-01 19:32:22 -03:00
Xavier Noria
f78de68649 explains Array.wrap directly, rather by comparison with Kernel#Array which is too obscure, leaves the comparison to document the differences, and adds a comparison with the related idiom that uses the splat operator 2010-08-01 03:19:58 +02:00
Johan Lundström
96f8325116 DHH forgot to remove JS, CSS in generated index.html [#5261 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-07-31 20:38:12 -03:00