Subba Rao Pasupuleti
8d9d8bc93c
Tidy up error.rb code
...
[#5288 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-08-03 14:54:13 -03:00
José Valim
84081fcc54
Freeze options so we raise an error when people modify it in place.
2010-08-03 15:36:23 +02:00
José Valim
f23bc8444b
validates_length_of should not change the options hash in place. [ #5283 state:resolved]
2010-08-03 15:22:54 +02:00
Tore Darell
2c8a4a53a8
Remove or fix non-working examples and add a few tests to Dirty [ #5185 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:47:30 +02:00
Alex Le
aeaab06c79
ActiveModel::Errors json serialization to work as Rails 3b4 [ #5254 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-02 16:26:32 +02:00
Xavier Noria
ccd45618ed
Merge remote branch 'rails/master'
2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755
edit pass to apply API guideline wrt the use of "# =>" in example code
2010-07-30 02:30:04 +02:00
Neeraj Singh
1a6d76223b
expanding on the will_change! method in documentation
2010-07-29 09:18:29 -04:00
David Heinemeier Hansson
856fc4bbc3
Prep for RC
2010-07-26 12:53:25 -05:00
Neeraj Singh
aa2235be7b
replacing around with for in the comments for callbacks
2010-07-22 01:28:30 +02:00
Piotr Sarnacki
6807b08099
Moved a few methods from RecordIdentifier to ActiveModel::Naming
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 11:29:58 +02:00
Neeraj Singh
c9630d9d87
adding proper markup to comment
2010-07-16 09:58:01 -04:00
Santiago Pastorino
060ca6abce
Add missing require to use Set
2010-07-11 02:55:47 -03:00
José Valim
87f64ef05e
Improve a bit the code in latest commits.
2010-07-08 22:59:41 +02:00
Łukasz Strzałkowski
4a26a292a0
Removing method before redefining it. It was causing warnings. [ #5072 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:29:08 +02:00
José Valim
c285f07a92
Change documentation for ActiveModel::MassAssignmentSecurity a bit and make debug always be called since some people may overwrite warn! to add extra behavior even if logger is not available.
2010-07-08 19:02:34 +02:00
Josh Kalderimis
4b66aab00f
mass_assignment_security moved from AR to AMo, and minor test cleanup
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 18:28:45 +02:00
Santiago Pastorino
075f8b7241
Add a missing require to allow the usage of Array#to_xml
2010-07-03 09:59:51 -03:00
Santiago Pastorino
51be8dbded
Move constantize from conversions to inflections.
...
This removes ActiveModel dependency on TZInfo.
[#4979 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 20:49:30 +02:00
José Valim
7bd85a8fc2
Work around the fact the JSON gem was overwriting to_json implementation for all Ruby core classes.
...
This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized.
So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved]
2010-06-26 12:01:13 +02:00
Josh Kalderimis
e8c064bbe0
Regression with how base errors messages are added to a model. Works correctly for both string error messages and symbol translated messages.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 14:45:55 +02:00
José Valim
0421fb7a91
Refactor previous commit a bit [ #4057 state:resolved]
2010-06-21 12:17:24 +02:00
Jeroen van Dijk
26392c4ac5
Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options.
...
This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format".
Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation.
Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options).
Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now.
The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 11:55:21 +02:00
Xavier Noria
207fa59675
Merge remote branch 'rails/master'
...
Conflicts:
actionpack/lib/abstract_controller/base.rb
2010-06-20 23:13:19 +02:00
José Valim
0247995d05
ActiveModel::Validations::Callbacks should not be required by default.
2010-06-19 18:20:02 +02:00
Neeraj Singh
51739d3228
moving before_validation and after_validation functionality from ActiveRecord to ActiveModel
...
[#4653 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-19 17:59:52 +02:00
Rizwan Reza
de65c82bfa
Changes call backs to callbacks.
2010-06-15 22:48:10 +04:30
Rizwan Reza
596300ac8a
Merge branch 'master' of github.com:lifo/docrails
2010-06-15 22:21:39 +04:30
Rizwan Reza
3ae67fbebb
Add titles to the rest of the files in active_model/validations/*
2010-06-15 22:20:19 +04:30
Rizwan Reza
d896d8fa20
Minor doc changes to active_model/validations/confirmation.rb
2010-06-15 22:17:06 +04:30
Rizwan Reza
6907bfe1ab
Minor doc changes to active_model/validations/acceptance.rb
2010-06-15 22:13:30 +04:30
Bryan Woods
89b96c0313
Active Model lint - fix minor typos
2010-06-15 13:38:22 -04:00
Evgeniy Dolzhenko
ef404c771d
Fix a bunch of minor spelling mistakes
2010-06-15 12:04:22 +04:00
Xavier Noria
f17159b029
edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord"
2010-06-14 23:22:04 +02:00
Rizwan Reza
e67c28dfe0
Added headings to serializers.
2010-06-14 13:59:55 +04:30
Rizwan Reza
7d7d54fa1f
Revised the rest of the files from ActiveModel.
2010-06-14 13:56:51 +04:30
Rizwan Reza
2572af11ce
Revised and added headings.
2010-06-14 13:49:01 +04:30
Rizwan Reza
de12b5e616
Revised naming.rb and lint.rb
2010-06-14 13:44:49 +04:30
Rizwan Reza
c5db6450ec
Added headings and revised active_model.rb/lint.rb grammatically
2010-06-14 13:43:06 +04:30
Rizwan Reza
626586b8c7
Minor changes to active_model/errors.rb
2010-06-14 13:40:57 +04:30
Rizwan Reza
716c243def
Minor changes to active_model/callbacks.rb and dirty.rb
2010-06-14 13:38:29 +04:30
Rizwan Reza
97d6778c80
Minor changes to active_model/attribute_methods
2010-06-14 13:36:05 +04:30
Rizwan Reza
4523081317
Minor changes to callbacks and conversion API docs.
2010-06-14 13:28:00 +04:30
Evgeniy Dolzhenko
ccf9577aee
Fix a bunch of minor spelling mistakes
2010-06-11 14:15:34 +04:00
Pavel Gorbokon
835fd07b48
Fix spelling error in ActiveModel::Conversion docs. [ #4826 state:resolved]
2010-06-11 03:09:27 +03:00
José Valim
b67ec8ba20
class_attribute is not a direct replacement of class_inheritable_*.
...
If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.
2010-06-10 19:39:09 +02:00
Neeraj Singh
e11bb95d56
Validators should at model level and not at AR:Base level [ Closes #4804 ]
...
[#4804 state:resolved]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-10 11:50:42 -04:00
David Heinemeier Hansson
32d4330b81
Get ready for beta 4
2010-06-08 14:47:02 -04:00
José Valim
a04060fb6f
Really make include_root_in_json default to true [ #3770 state:resolved]
2010-06-08 01:02:45 +02:00
Santiago Pastorino
b3d2080278
Observing module is using constantize
2010-06-06 22:42:28 -07:00
