Commit Graph

21887 Commits

Author SHA1 Message Date
Arun Agrawal
d42e43b3e5 Fixed images path in plugin_new_generator 2011-04-23 04:08:01 +08:00
Schneems
a8870d140e show http method in routing error message 2011-04-23 03:40:09 +08:00
Arun Agrawal
eb599295db Images path fixed in test. 2011-04-23 02:22:12 +08:00
David Heinemeier Hansson
bb6b17216d Need this for testing 2011-04-22 20:03:12 +02:00
David Heinemeier Hansson
89f315bfb2 We cant use assert_block because its buggy in MiniTest and wont actually show you the failure message you provide -- instead you just always get a "Expected block to return true" 2011-04-22 19:38:01 +02:00
Aaron Patterson
a37722182f removing incorrect comment and string concatenation 2011-04-22 12:21:59 -05:00
Pavel Forkert
96acdd3ec4 Added test case and fix for proper eager loading associations 2011-04-22 12:06:15 -05:00
Aaron Patterson
fe4932b531 bumping the pg requirements 2011-04-22 11:27:14 -05:00
Ken Collins
bc50c1cb02 The #substitute_at gets an ActiveRecord::ConnectionAdapters::Column in #insert to match replacement in #exec_query. 2011-04-23 00:15:33 +08:00
David Heinemeier Hansson
59ce0f695b Turn on JS/CSS compression by default 2011-04-22 18:06:59 +02:00
Joshua Peek
dab96a267e Add shorthand for js and css compressors 2011-04-22 10:49:55 -05:00
Ken Collins
ed2820d6ec Move #exec_insert to abstract adapter's database statements. 2011-04-22 22:32:55 +08:00
Aaron Patterson
724a786677 stop using distinct on for the unique id queries. [#6450 state:resolved] 2011-04-21 22:47:13 -05:00
Joshua Peek
84f1b83df8 Only include SprocketsHelper into assets context 2011-04-21 11:03:56 -05:00
José Valim
d31af44012 Fix tests on 1.8 by explicitly checking for strings (which also improves performance). 2011-04-20 21:54:19 +02:00
Xavier Noria
356dacbafc Merge branch 'master' of git://github.com/lifo/docrails 2011-04-19 23:03:28 +02:00
Josh Kalderimis
68eb84d735 correction to the i18n locale filter examples 2011-04-19 22:52:00 +02:00
José Valim
2f549b8bbd Use initialize_copy! to proper initialize now on clone. 2011-04-19 22:38:51 +02:00
Florent Piteau
89ed9fbd19 Don't reuse a closed flash when using now 2011-04-20 04:32:26 +08:00
José Valim
22fcef90b1 Actually add an abstract class, so it is easier to get rid of old asset paths in the future. 2011-04-19 22:02:02 +02:00
Xavier Noria
e162e912c9 Merge branch 'master' of git://github.com/lifo/docrails
Conflicts:
	railties/guides/source/ajax_on_rails.textile
	railties/guides/source/generators.textile
2011-04-19 21:54:10 +02:00
José Valim
a19c260038 Include modules to the context in the railtie. 2011-04-19 21:49:28 +02:00
Xavier Noria
ad60286926 Revert "Better formatting"
No need to change this formatting.

This reverts commit 9c861e8a0e.
2011-04-19 21:43:17 +02:00
José Valim
914218ef30 Let's use inheritance here, shall we? 2011-04-19 21:32:58 +02:00
Xavier Noria
5fee98adf8 remove unwanted Example headers as per the guidelines, s/instaces of NilClass/nil/ and friends, completes some rdocs 2011-04-19 21:15:15 +02:00
Xavier Noria
eaf0d1a491 commit copy-edit: simplifies blank? rdoc and revises formatting 2011-04-19 21:00:16 +02:00
Xavier Noria
571b4a2a91 Revert "Formated docs"
Reason: "To be blank" and "to be empty" belongs to our everyday
terminology, they go in regular font.

This reverts commit 280a870992.
2011-04-19 21:00:15 +02:00
Xavier Noria
3265516c50 brings a #:nodoc: back 2011-04-19 21:00:15 +02:00
Florent Piteau
a1639ad752 Undocumented :openssl_verify_mode option for smtp_settings 2011-04-19 20:44:20 +02:00
David Heinemeier Hansson
c96bf840ad Add app/assets/images and include the rails.png as a sample there 2011-04-19 20:38:38 +02:00
David Heinemeier Hansson
9aac54c4bf Add note about the option to add other precompile targets 2011-04-19 20:35:53 +02:00
David Heinemeier Hansson
e6850136d6 Set a default precompile target to be the application.js, application.css, and all non-css/js files (images etc) 2011-04-19 20:33:56 +02:00
David Heinemeier Hansson
1e56c89559 Give assets access to asset_path during precompilation 2011-04-19 20:06:09 +02:00
David Heinemeier Hansson
626bcc9bf4 Switch to asset_path and make it available in the Sprockets::Context (now you can do asset_path("logo.png") in a stylesheet.css.erb file and get fingerprinting) 2011-04-19 19:05:07 +02:00
David Heinemeier Hansson
d35c91225e Cleanup compute_sprockets_path -- when you are reaching for code comments, the method could be simpler 2011-04-19 18:30:44 +02:00
Xavier Noria
9b423ac0b7 let this regexp be stricter
The purpose of this regexp is to detect strings that
are valid identifiers to be used as method names.
The anchor $ allows a trailing newline, and both ^
and $ may be bypassed because Ruby regexps are
multiline always. The anchors \A and \z are the
proper ones to ensure string boundaries.
2011-04-19 18:16:38 +02:00
David Heinemeier Hansson
a3a5c7eba3 All assets, including images, audio, and video, now uses the asset pipeline when its on 2011-04-19 18:07:42 +02:00
José Valim
dca31b9224 Let's not dup because value may not always be duplicable. 2011-04-19 18:06:01 +02:00
José Valim
30472d4244 Avoid define_method if possible. 2011-04-19 17:58:06 +02:00
Joshua Peek
d24d938af4 Merge branch 'joshk-multi_json' 2011-04-19 09:43:47 -05:00
Joshua Peek
011afb70e5 Merge branch 'multi_json' of https://github.com/joshk/rails into joshk-multi_json 2011-04-19 09:42:11 -05:00
Josh Kalderimis
b24621809e remove MultiJson from the Gemfile and instead add the current rc to the AS gemspec 2011-04-19 16:34:34 +02:00
José Valim
069e9b004f Do not stream on HTTP/1.0. 2011-04-19 15:04:28 +02:00
José Valim
b398520c14 Output a redirect to the 500 page if something happens when streaming.
Currently, we output:

  "><script type="text/javascript">window.location = "/500.html"</script></html>
2011-04-19 12:26:11 +02:00
José Valim
a66c917235 Do not inherit from Rack::Response, remove a shit-ton of unused code. 2011-04-19 11:54:12 +02:00
Paco Guzman
66a2ffcdb7 Update link to Rails 2.3 guides from 2.3.8 to last release 2.3.11. Maybe someone could regenerate the guides 2011-04-19 11:24:09 +02:00
José Valim
6380f1a9f4 Be sure to not store the closed flash in the session. 2011-04-19 10:34:17 +02:00
Sebastian Martinez
082e299e97 docs for ActionMailer::Base.default_i18n_subject 2011-04-18 23:37:27 -03:00
Jon Leighton
3bff8bdb2a Merge branch 'master' of github.com:rails/rails 2011-04-18 23:35:28 +01:00
Jon Leighton
019cd51a3f Bring back support for passing a callable object to the default_scope macro. You can also just use a block. 2011-04-18 23:35:22 +01:00