Commit Graph

19225 Commits

Author SHA1 Message Date
Paco Guzman
d44cd370bf colorize_logging is a Rails General Configuration option not a specific option of ActiveRecord 2010-11-13 12:17:21 +01:00
Frederick Ros
e7723baa0b Fixed the name of the 'generator option' 2010-11-11 23:02:05 +01:00
Rajinder Yadav
5cdb46d9fb this reads better, i don't know what the other 'so on' are, doesn't help reader imho 2010-11-09 05:05:56 -05:00
Rajinder Yadav
4e074c7cc6 added missing word to clear up meaning in my previous commit 2010-11-09 04:34:32 -05:00
Rajinder Yadav
26d314ed6a Merge branch 'master' of github.com:lifo/docrails 2010-11-09 04:31:08 -05:00
José Valim
645f515843 Add a note to TextHelpers making explicit their default behavior of not escaping but sanitizing. 2010-11-08 01:47:49 -08:00
Rajinder Yadav
4b7ac55780 removed indentation, for code style consistency and readibility 2010-11-08 04:17:56 -05:00
dmathieu
78e085b12c Use Rails.logger, not ActiveRecord::Base.logger
Because everybody is not using ActiveRecord. And the logger is not specific to it.
2010-11-08 10:14:15 +01:00
Rajinder Yadav
149f795d16 removed etc. not require 2010-11-08 04:04:18 -05:00
Rajinder Yadav
e135f13f50 added missing space and minor rewording 2010-11-08 03:58:19 -05:00
Rajinder Yadav
4d5807bcd5 corrected to Rails 3 syntax for declaring resources 2010-11-08 03:47:45 -05:00
Francesc Esplugas
e22ad7ae1d Fixes ActionMailer example error 2010-11-07 22:08:59 +01:00
Ryan Bigg
b591989b5f Fix indentation for :as option documentation on the namespace method 2010-11-07 12:22:39 +10:00
Ryan Bigg
ff3a494e2e Document the :shallow_path option for scope 2010-11-07 12:21:56 +10:00
Ryan Bigg
e6aed6b6a8 Indent final comment for :path option 2010-11-07 12:18:19 +10:00
Ryan Bigg
ee646788fc Indent code example for :as option 2010-11-07 12:17:36 +10:00
Ryan Bigg
7d83673134 Document the :as option for the scope method 2010-11-07 12:11:39 +10:00
Ryan Bigg
ffe97e338e Space between module option documentation and path documentation 2010-11-07 12:09:58 +10:00
Ryan Bigg
4a6150a3eb Fix indentation on comment for :path option 2010-11-07 12:09:38 +10:00
Ryan Bigg
6ca042b3e4 Document the :as option for the namespace method 2010-11-07 12:07:41 +10:00
Ryan Bigg
66d1276d7f Document the :module option for namespace 2010-11-07 12:05:55 +10:00
Ryan Bigg
0eef4e3bfb Document the :path option for namespace 2010-11-07 12:05:14 +10:00
Ryan Bigg
379939e1e0 Begin to document the namespace method for AD's Mapper 2010-11-07 12:04:25 +10:00
Ryan Bigg
e5eece41b5 Document the controller method for AD's Mapper 2010-11-07 11:49:57 +10:00
Ryan Bigg
5f7f3adccd Document the defaults method 2010-11-07 11:39:57 +10:00
Ryan Bigg
5040ecbfea Document the :module and :path options for the scope method. 2010-11-07 11:39:55 +10:00
Ryan Bigg
35c7ca5c37 Separate comments and examples with "Examples" header. 2010-11-07 11:39:53 +10:00
Ryan Bigg
433e1aca86 Fix where the documentation says "photos", but the example shows "posts" or "comments" by switching both to simply "posts" 2010-11-07 11:39:50 +10:00
Ryan Bigg
203e45cd7f Add further documentation + examples for the get, post, put and delete methods in ActionDispatch::Routing::Mapper::HttpHelpers 2010-11-07 11:39:27 +10:00
Xavier Noria
3cf85fb4fc Merge branch 'master' of git://github.com/lifo/docrails 2010-10-30 23:28:16 +02:00
Aaron Patterson
296467fcc4 only returning where values for the corresponding relation, also filtering where value hash based on table name [#5234 state:resolved] [#5184 state:resolved] 2010-10-30 13:25:49 -07:00
Aaron Patterson
cbca12f908 adding tests for #5234 and #5184. Tests were from Akira Matsuda. Thanks Akira! 2010-10-30 13:20:54 -07:00
Aaron Patterson
7d5762d2c2 no need to merge where values if no new where values have been added 2010-10-30 12:28:49 -07:00
Aaron Patterson
2b48e47654 ruby-debug19 does not work with 1.9.3, so I am removing it 2010-10-30 11:30:08 -07:00
Denis Odorcic
cc9742920c Convert :primary_key in association to a string before comparing to column names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved] 2010-10-30 11:24:36 -07:00
Aaron Patterson
67a3a70295 refactoring find_join_association 2010-10-30 08:45:40 -07:00
Ernie Miller
0bb85ed9ff Fix issues when including the same association multiple times and mixing joins/includes together. 2010-10-30 06:48:44 -07:00
Jon Leighton
b82fab25f9 Refactoring: replace the mix of variables like @finder_sql, @counter_sql, etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly. 2010-10-30 06:30:00 -07:00
Aaron Patterson
2a47e7ef10 only do string substitution on column names once, remove intermediate data structures 2010-10-30 06:16:54 -07:00
Aaron Patterson
2e07260f36 columns are always strings 2010-10-30 06:12:50 -07:00
Aaron Patterson
6cf44a1bd6 no need to to_i, sqlite does that for us 2010-10-30 06:11:06 -07:00
snusnu
973b908777 Added missing AS require to active_model/naming.rb
We saw a failing spec when running the DataMapper
ActiveModel compliance specs for dm-active_model.

  ActiveModel::Naming#model_name

relies on the Module#parents method defined in

  active_support/core_ext/module/introspection.rb

Adding the appropriate require statement of course
fixed our specs.
2010-10-30 00:20:31 +08:00
Aditya Sanghi
3ca1665038 reverting last change to javascript helper; needs more investigation 2010-10-29 10:13:48 +05:30
Aditya Sanghi
74f3f74b6e fixed javascript helper doc to close issue #10 raised by jialin 2010-10-29 10:01:43 +05:30
Aaron Patterson
6a3d6b7f13 select_all() should always return an array, so no need to test 2010-10-27 14:39:24 -07:00
Aaron Patterson
f6ddb3553a fisting test name 2010-10-27 14:33:02 -07:00
Aaron Patterson
9ce0211806 speeding up query cache 2010-10-27 14:23:01 -07:00
Aaron Patterson
7104122cc3 making query cache work with prepared statements 2010-10-27 14:05:40 -07:00
Andrew White
47ceb135c6 Ensure that Rails.env is defined first 2010-10-27 10:30:14 +01:00
Aaron Patterson
e73b0b84d9 renaming bind_values to binds where it makes sense 2010-10-26 13:44:11 -07:00