Commit Graph

1077 Commits

Author SHA1 Message Date
David Heinemeier Hansson
d5b67ed8d3 Added the option to specify the acceptance string in validates_acceptance_of #1106 [caleb@aei-tech.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1188 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 10:04:07 +00:00
David Heinemeier Hansson
154668898a Fixed that purge_test_database would use database settings from the development environment when recreating the test database #1122 [rails@cogentdude.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1187 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 10:00:37 +00:00
David Heinemeier Hansson
78d8503a94 Added acts_as_nested_set #1000 [wschenk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:59:52 +00:00
David Heinemeier Hansson
339f4956b3 Added acts_as_nested_set #1000 [wschenk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1185 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:52:12 +00:00
David Heinemeier Hansson
8e8bf37aa9 Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
c3ca5ab7a8 Added Element.toggle, Element.show, and Element.hide to the prototype javascript library. Toggle.display has been deprecated, but will still work #992 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:52:50 +00:00
David Heinemeier Hansson
6acda705dc Added that deleting a cookie should not just set it to an empty string but also instantly expire it #1118 [todd@robotcoop.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:18:39 +00:00
David Heinemeier Hansson
ed46cc3058 Added insert_at(position) to acts_as_list #1083 [DeLynnB]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:50:17 +00:00
David Heinemeier Hansson
949294e0f7 Cleaned up validates_length_of by calling existing validations on the common stuff #1108 [caleb@aei-tech.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:34:13 +00:00
David Heinemeier Hansson
5e9dc49744 Dont prefix on updates and deletes, only selects
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:32:49 +00:00
David Heinemeier Hansson
ffdd4bc251 Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
5e3b8b36fa Fixed url_for(nil) in functional tests #1116 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1175 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:18:33 +00:00
David Heinemeier Hansson
68dfe3e046 Clean up load paths to avoid unit test interaction #1113 [alles@atomicobject.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:16:00 +00:00
David Heinemeier Hansson
db16349bc1 Fixed error handling of broken layouts #1115 [Michael Schubert]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:11:58 +00:00
Leon Breedt
5feb7e26e8 Send a stripped down message in the text following 500, and leave the detailed
response for the body, or we may generate invalid HTTP responses that causes 404's.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1172 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 21:59:55 +00:00
Leon Breedt
7f32666924 Remove a cause of casting failure for XML-RPC by ignoring structure members not
defined in the target type, and perform more sanity checks to make more obvious
what the resolution should be when neglecting to provide a valid signature or
failing to attach an API to a service implementation class.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1171 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 19:29:42 +00:00
David Heinemeier Hansson
6ee06ebec6 Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
82456d9392 Fixed partials handling
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:06:29 +00:00
David Heinemeier Hansson
0baf344457 Made migrations create InnoDB tables per default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 06:38:12 +00:00
David Heinemeier Hansson
9dd8d3d3e4 Honor the order in the new finder
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-15 08:32:56 +00:00
David Heinemeier Hansson
624d5bb176 Added script/benchmarker to easily benchmark one or more statement a number of times from within the environment. Added script/profiler to easily profile a single statement from within the environment
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-14 08:23:50 +00:00
David Heinemeier Hansson
75b8ac80d9 Dont initialize the association proxy for nil records
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-14 07:49:13 +00:00
David Heinemeier Hansson
cef09015c7 Order by is no longer a guarentee
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-14 04:07:26 +00:00
David Heinemeier Hansson
ff1db4de5f Qualify the ids used such that eager loading can avoid ambigious keys
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 18:12:59 +00:00
David Heinemeier Hansson
71bdf13b60 Removed the default order by id on has_and_belongs_to_many queries as it could kill performance on large sets (you can still specify by hand with :order)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 17:51:43 +00:00
David Heinemeier Hansson
54cc595dff Improved address header processing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 17:49:24 +00:00
David Heinemeier Hansson
f3e5e07982 Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
ad24c6d756 Fixed pagination to work with joins #1034 [scott@sigkill.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:40:22 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
ecf82d127b Added Rake target clear_logs that'll truncate all the *.log files in log/ to zero #1079 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:32:21 +00:00
David Heinemeier Hansson
2ad8dc6a1f Added :confirm option to link_to_remote just like link_to has #1082 [yrashk@fp.org.ua]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:21:37 +00:00
David Heinemeier Hansson
908e9a17d8 Fixed that Base.silence should restore the old logger level when done, not just set it to DEBUG #1084 [yon@milliped.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:16:52 +00:00
David Heinemeier Hansson
c29db9f210 Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
e0a2dab816 Added KLOC counter for AR and AP. Combined theyre at ~9KLOC
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:06:40 +00:00
David Heinemeier Hansson
bf1bcff2bd Fixed that an exception would be thrown when an empty form was submitted #1090 [jan@ulbrich-boerwang.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:50:54 +00:00
David Heinemeier Hansson
988dc1e862 Improved tests for NumberHelper
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:49:01 +00:00
David Heinemeier Hansson
5fe0ecce0a Fixed boolean saving on Oracle #1093 [mparrish@pearware.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:46:59 +00:00
David Heinemeier Hansson
d5cadfc110 Address parsing failed when the "to" (or "cc", or whatever) was an array. It was also too restrictive in the formats of the addresses #1097 [Jamis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:44:58 +00:00
David Heinemeier Hansson
6f5fcc4469 Made error_messages_for take a symbol as object_name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 17:44:28 +00:00
David Heinemeier Hansson
7140f65355 Moved TextHelper#human_size to NumberHelper#number_to_human_size, but kept an deprecated alias to the old method name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 08:04:38 +00:00
David Heinemeier Hansson
3b9e90a4da Moved build_association and create_association for has_one and belongs_to out of deprecation as they work when the association is nil unlike association.build and association.create, which require the association to be already in place #864
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1146 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 05:34:10 +00:00
David Heinemeier Hansson
b59619600f No conditions relevant here
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-11 15:13:43 +00:00
David Heinemeier Hansson
a67beac9d0 Dont quote the body
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-11 11:46:12 +00:00
David Heinemeier Hansson
256e800a01 Fixed quoting for all address headers, not just to #955 [Jamis Buck] Added that quoting to UTF-8 only happens if the characters used are in that range #955 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-11 10:29:15 +00:00
David Heinemeier Hansson
ea803aa4e3 Doc changes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:47:04 +00:00
David Heinemeier Hansson
1cad24f6fd Doc fix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:43:12 +00:00
David Heinemeier Hansson
a0403bd732 Fixed #1030
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:42:17 +00:00
David Heinemeier Hansson
5cd021393c Tests for AS
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:37:20 +00:00