github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,593 Commits 34 Branches 105 Tags
d6c2285e31cbc7150cf99ff3a537eddbdb50fb29
Commit Graph

9593 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pratik Naik
d6c2285e31 Merge commit 'mainstream/master' 2008-12-28 20:00:29 +00:00
Xavier Noria
a2270ef259 Inline code comments for class_eval/module_eval [#1657 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-28 19:49:28 +00:00
Mike Gunderloy
1fb275541a Ensure template runner tests don't depend on hash ordering [#1654 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-28 17:49:58 +00:00
Pratik Naik
fec0ea9d6d Request#env['SERVER_NAME'] does not contain port number 2008-12-28 17:07:13 +00:00
Aaron Quint
c0c79f779c Use SimpleLogger for Rails::TemplateRunner outside of the Generator context [#1618 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-28 16:49:19 +00:00
Pratik Naik
aaea12c497 Revert inline docs 2008-12-28 16:01:38 +00:00
Andrew Timberlake
297276b99c Added documentation to gsub_file method 2008-12-28 01:25:23 -05:00
Chris Kampmeier
1ea13fce1a Rewrite ActiveRecord::Base.delete docs for clarity, and mention return value 2008-12-27 18:03:19 -05:00
Mike Gunderloy
fa6218c923 Regenerate Guides HTML 2008-12-27 16:16:49 -06:00
Aaron Quint
9fd35fc2d8 Adding test coverage and better logging to Rails::TemplateRunner [#1618 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-27 21:03:44 +00:00
Xavier Noria
8b1d69d197 adds more inline docs for dynamically created methods in Active Support 2008-12-27 20:49:28 +01:00
Xavier Noria
6adfbf2844 adds inline docs for dynamically created methods in Active Record 2008-12-27 20:25:41 +01:00
Xavier Noria
0ba8dcb444 adds inline docs for dynamically created methods in Action Pack 2008-12-27 20:06:45 +01:00
Xavier Noria
8cabcbd272 adds inline docs for dynamically created methods in Active Support 2008-12-27 19:28:32 +01:00
Yaroslav Markin
fdaa9ed033 Fix ActionPack build on Windows: we really should not test anything regarding symlinks on Windows. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-12-27 17:33:13 +00:00
Mike Gunderloy
711512a42b More formatting cleanup for testing guide 2008-12-27 09:34:56 -06:00
Mike Gunderloy
930b20678e Fix typo in layout and rendering guide 2008-12-27 09:07:55 -06:00
Mike Gunderloy
6d0639c95e Merge patch on subtemplates into layouts & rendering guide 2008-12-27 09:05:37 -06:00
Mike Gunderloy
e51b8e2036 Add information on new rendering syntax to layouts + rendering guide 2008-12-27 08:52:32 -06:00
Yaroslav Markin
28347d889b Refactor ActiveRecord::Base#new_record? [#1647 state:committed] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2008-12-27 15:25:39 +01:00
Mike Gunderloy
d65a24c49e Formatting changes on index and testing guide 2008-12-27 08:23:33 -06:00
Mike Gunderloy
8584922705 Add version links to index 2008-12-27 08:03:36 -06:00
Yaroslav Markin
6e98adfc8e ActiveRecord::Base#new_record? now returns false for existing records (was nil) [#1219 state:committed] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2008-12-27 14:36:11 +01:00
Yaroslav Markin
fa0502494e It is better to have this commented out to let locale-checking scripts perform better (rails-i18n) 2008-12-27 13:27:54 +03:00
Yehuda Katz
4f043a4838 More optimizations on respond_to after a profile and benching: 
App with simple respond_to:
  def index
    respond_to do |format|
      format.html
      format.xml
      format.json
    end
  end

On JRuby (after complete hotspot warmup) -- 8% improvement:
  550 requests per second after this commit
  510 requests per second with old method_missing technique

On MRI (8% improvement):
  430 requests per second after this commit
  400 requests per second with old method_missing technique
 2008-12-27 00:06:57 -08:00
Aditya Chadha
dce642f22a Fixed typo 2008-12-27 02:50:30 -05:00
Pratik Naik
f4f8923cf0 Merge commit 'fred/pullable' 2008-12-26 21:56:21 +00:00
Yehuda Katz
6dc1288111 Remove method missing use in respond_to 2008-12-26 13:41:02 -08:00
Chris Kampmeier
d49fa21a03 ActionController::Request docs: fix reference to nonexistent ACCEPTED_HTTP_METHODS constant, clean up #request_method and #method 2008-12-26 16:32:14 -05:00
Frederick Cheung
5cebe69e74 Preload uses exclusive scope [#643 state:resolved] 
With self referential associations, the scope for the the top level should not affect fetching of associations, for example
when doing

Person.male.find :all, :include => :friends

we should load all of the friends for each male, not just the male friends.
 2008-12-26 18:25:55 +00:00
Pivotal Labs
eb457ceee1 Association preloading no longer stops if it hits a nil object [#1630 state:resolved] 
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
 2008-12-26 18:25:50 +00:00
trans
c9d4335418 MaKe Hash#slice! return removed values, akin to Array [#971 state:resolved] 
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
 2008-12-26 18:25:42 +00:00
Frederick Cheung
dce0da77e7 Fix assert_select_rjs not checking id for inserts [#540 state:resolved] 2008-12-26 18:25:32 +00:00
Frederick Cheung
d7b6e48c70 Fix randomly failing cookie store tests 
Marshal.dump(Marshal.load(marshaled_hash)) is not guarenteed to be equal to marshaled_hash
because of the lack of ordering of hash
 2008-12-26 18:25:03 +00:00
Pivotal Labs
fe9239e9c6 Documentation for merged joins 2008-12-26 17:29:45 +00:00
Pratik Naik
d9ca219e3e Merge commit 'mainstream/master' 2008-12-26 17:29:35 +00:00
Pratik Naik
db5a98e6cb Merge docrails 2008-12-26 17:19:59 +00:00
Pratik Naik
73e9f4e909 Merge commit 'mainstream/master' 2008-12-26 17:18:06 +00:00
Pratik Naik
07298fd092 Don't recurse when ActionController#render is called without any arguments 2008-12-26 01:49:14 +00:00
Pratik Naik
80307c8b0a Make ActionController#render(symbol) behave same as ActionController#render(string) [#1435] 2008-12-26 01:12:11 +00:00
Pratik Naik
cd1d6e8768 Make ActionController#render(string) work as a shortcut for render :action => string. [#1435] 
Examples:
  # Instead of render(:action => 'other_action')
  render('other_action')

Note : Argument must not have any '/'
 2008-12-25 23:05:34 +00:00
Pratik Naik
d67e03871e Make ActionController#render(string) work as a shortcut for render :template => string. [#1435] 
Examples:
  # Instead of render(:template => 'controller/action')
  render('controller/action')

Note : Argument must not begin with a '/', but have at least one '/'
 2008-12-25 22:26:03 +00:00
Pratik Naik
061952392a Make ActionController#render(string) work as a shortcut for render :file => string. [#1435] 
Examples:
  # Instead of render(:file => '/Users/lifo/home.html.erb')
  render('/Users/lifo/home.html.erb')

Note : Filename must begin with a forward slash ('/')
 2008-12-25 21:43:07 +00:00
Pratik Naik
dd0753458f Move ActionController::Base#render arguments validation to a separate method 2008-12-25 20:49:31 +00:00
Pratik Naik
04a8b2362d Make render_test.rb run in isolation 2008-12-25 19:28:08 +00:00
Pratik Naik
6e2a771661 Undry ActionController::TestCase#<HTTP_METHODS> for better documentation 2008-12-25 17:54:44 +00:00
Pratik Naik
e898f82a74 Move request parsing related code to ActionController::RequestParser 2008-12-25 03:51:04 +00:00
Mislav Marohnić
2cd8d3b4c5 form helpers: twakes based on feedback; more content; set outline for remaining topics 2008-12-25 00:23:51 +01:00
Joshua Peek
9c1e48eaea ActionController::VerbPiggybacking middleware 2008-12-23 13:36:05 -06:00
Ryan Bigg
ee69bac14e Xavier Noria suggestions added! Guides #16, parts 27-29. 2008-12-23 21:28:10 +10:30