github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,957 Commits 34 Branches 105 Tags
d6e4113c83a9d55be6f2af247da2cecaa855f43b
Commit Graph

9957 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yehuda Katz
d6e4113c83 YAGNI Method references. Deprecated 2009-06-02 22:06:21 -07:00
Yehuda Katz
6b4da2ecac Add explicit requirement in a few cases it was missing. 
TODO: Come up with the minimal core and remove all of these
 2009-06-02 21:43:54 -07:00
Yehuda Katz
1126a85aed Further cleaning up new callbacks 2009-06-02 21:41:31 -07:00
Yehuda Katz
971e2438d9 Simplify callbacks to use less metaprogramming 2009-06-02 19:00:59 -07:00
Yehuda Katz + Carl Lerche
196f780e30 Get all the callback tests to work on new base 2009-06-01 15:40:40 -07:00
Jeremy Kemper
dcba6e1148 Fix initializer i18n path test 2009-06-01 13:44:43 -07:00
Jeremy Kemper
94911c7af7 Ensure ERB source begins with the encoding comment 2009-06-01 12:34:08 -07:00
Han Kessels
9537fd0e3a fix for IE incompatibility of :disable_with in submit_tag 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-01 14:03:52 +12:00
Giles Alexander
532219fd09 Schema dumper now records scale 0 decimal columns as decimal not integer. 
The schema dumper would dump out any decimal or numeric column that had a zero
scale as an integer column. This will cause problems for very large precision
columns on some DBMSs, particularly PostgreSQL. It also looks strange to see
your column change type after moving through schema.rb.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2741 state:committed]
 2009-06-01 13:40:05 +12:00
Jeff Dean
b3839f1c98 Updated the db:structure:dump task to properly format the pgdump command when you have multiple schemas in your schema search path. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2695 state:committed]
 2009-06-01 12:12:45 +12:00
Vladimir Dobriakov
64756e8f71 better db:create for mysql - do not assume root user 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1459 state:committed]
 2009-06-01 12:09:19 +12:00
Jeremy Kemper
f9bd10054c Sidestep need for Kernel#silence_warnings 2009-05-30 11:59:17 -07:00
Jeremy Kemper
c79551f02b Depend on Hash#slice and Object#try 2009-05-30 11:59:17 -07:00
Jeremy Kemper
85eb3af873 Tolerate missing logger 2009-05-30 11:59:17 -07:00
Jeremy Kemper
3962be5b8c Use URI and Inflector 2009-05-30 11:59:17 -07:00
Jeremy Kemper
c53057d4fd html-scanner uses Set and class_inheritable_accessor 2009-05-30 11:59:17 -07:00
Jeremy Kemper
249d9a6606 Depend on Hash#diff extension 2009-05-30 11:59:17 -07:00
Jeremy Kemper
5481e54175 AM::StateMachine autoloads 2009-05-30 11:59:16 -07:00
Joshua Peek
a1140a1031 Revert "Only save the session if we're actually writing to it [#2703 state:resolved]" 
This reverts commit dd98280e38.
 2009-05-30 09:36:08 -05:00
Luke Melia
54984f0f24 Avoid loading the ActiveRecord::SessionStore class on initialization if it is not in use [#2737 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-30 09:35:25 -05:00
Joshua Peek
e7d6f48ea9 Use AS::Concern in ActiveModel 2009-05-30 09:35:24 -05:00
Pratik Naik
e767c65cc9 Make sure tests pass action name to Controller.action() 2009-05-30 15:18:46 +01:00
Pratik Naik
63992e8f3a Support Object#filter method for before/after filters 2009-05-30 15:14:23 +01:00
Joshua Peek
669fd84910 AS::Concern redefines "include" to lazy include modules as dependencies 2009-05-29 17:03:23 -05:00
Joshua Peek
c7c35be8fe AS::Concern includes InstanceMethods module if it exists 2009-05-29 16:28:54 -05:00
Joshua Peek
69742ca8fa Merge branch 'master' into active_model 
Conflicts:
	activemodel/lib/active_model/core.rb
	activemodel/test/cases/state_machine/event_test.rb
	activemodel/test/cases/state_machine/state_transition_test.rb
	activerecord/lib/active_record/validations.rb
	activerecord/test/cases/validations/i18n_validation_test.rb
	activeresource/lib/active_resource.rb
	activeresource/test/abstract_unit.rb
 2009-05-29 16:06:21 -05:00
Jeremy Kemper
5ec2c7dc29 Ruby 1.9: ERB template encoding using a magic comment at the top of the file 2009-05-28 17:12:48 -05:00
Jeremy Kemper
e23554d79e Ruby 1.9: flushing the output buffer preserves its encoding 2009-05-28 17:12:48 -05:00
Jeremy Kemper
d120f9de7e Reinstate pending output buffer tests 2009-05-28 17:12:48 -05:00
Jeremy Kemper
cf3ccd7be0 Ruby 1.9: use UTF-8 for default internal and external encodings. 2009-05-28 17:12:48 -05:00
Joshua Peek
4e50a35fa2 Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern. 2009-05-28 11:35:36 -05:00
Joshua Peek
de203245af Revert "Revert "Whitespace!"" 
This reverts commit 0cac68d3be.
 2009-05-28 09:49:02 -05:00
Johan Sörensen
dd98280e38 Only save the session if we're actually writing to it [#2703 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:35:17 -05:00
Johan Sörensen
72cb6f58be The FlashHash and friends causes a lot of needless session storing, when we know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [#2703 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:30:49 -05:00
Olly Legg
0349278f3d Memoize cookies so that updates to cookies are available in the current request. [#2733 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:18:27 -05:00
Joshua Peek
d17fb9dc76 Fix script/server's default mount path [#2731 state:resolved] 2009-05-28 09:16:29 -05:00
Yehuda Katz + Carl Lerche
f2f58f5355 Fix failing ActionCacheFilter tests due to around filter changes. 2009-05-27 17:31:48 -07:00
Yehuda Katz + Carl Lerche
1e2628431a Added support to new callbacks for around filter object that respond to :before & :after used in before|after callbacks 2009-05-27 16:50:40 -07:00
Yehuda Katz + Carl Lerche
2b166d306c Added support to new callbacks for around filter object that respond to :before & :after 2009-05-27 16:49:23 -07:00
Yehuda Katz + Carl Lerche
bd7e3dc47d Added a compatibility layer to get legacy filter tests to pass on new base 2009-05-27 16:49:04 -07:00
Yehuda Katz + Carl Lerche
e70bd6bdfa Added hook point in new base #send_action which does the actual action method dispatching 2009-05-27 16:16:33 -07:00
Carl Lerche
a5688fa907 Add the ability to prepend filters to new callbacks 2009-05-27 16:15:53 -07:00
Hongli Lai (Phusion)
760cb63339 Make the default 500 Internal Server Error page more friendly. Many people don't know they're supposed to look in the log files. [#2716 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 15:01:03 -05:00
calavera
0d9e904da3 ensure initialize_database_middleware doesn't use ActionController if action_controller framework is not enabled [#2680 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 14:56:14 -05:00
Joshua Peek
6ef329d325 Ensure Memcache local cache returns duplicated values [#2302 state:resolved] 2009-05-27 14:54:58 -05:00
Eduard Bondarenko
61c471eebb Add % to RESERVED_PCHAR [#2574 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 14:53:05 -05:00
Niels Ganser
bb8e5843f3 ActionController::Flash::FlashHash.use now returns either the value corresponding to the passed key or itself when no key is passed [#1792 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 14:51:33 -05:00
anupom syam
746f3860c1 server command help inconsistency fix [#2685 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-27 14:45:16 -05:00
Chad Woolley
5679bf64d5 Fix failing CI test (broken in 2daac47 or e693f45): make test_multipart_with_template_path_with_dots only test path with dots, and stop failing on unrelated mimetype assertion. The image/jpeg multipart content type is already tested in test_explicitly_multipart_messages. 
Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local>
 2009-05-27 21:38:23 +02:00
Fabien Jakimowicz
2cb60abfec Add an model_subclass generator. 
This generator creates a new model as a subclass of an existing model and the unit test for that model.  Lets users avoid having to manually delete the fixtures and migration or remember to pass those arguments.

[#2702 state:committed]

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-05-27 13:14:04 +02:00