github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 08:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,973 Commits 34 Branches 105 Tags
da5fef45fe259dc47d00c3c52cfa336ade412645
Commit Graph

5973 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marcel Molina
da5fef45fe When a NonInferrableControllerError is raised, make the proposed fix clearer in the error message. Closes #10199 [danger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:31:41 +00:00
Marcel Molina
d64832c040 Give examples for what tables should be called for models inside a module namespace. Closes #10288 [scott_willson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:28:05 +00:00
Marcel Molina
7f671f4ae5 Document the :message option for validates_associated. Closes #10357 [dylans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:24:39 +00:00
Marcel Molina
e4d845ef54 Document automatically generated predicate methods for attributes. Closes #10373 [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 14:22:26 +00:00
Michael Koziarski
519f2c9d71 Document Date conversions. Closes #10368 [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 06:24:39 +00:00
Michael Koziarski
ab12c14494 Enhance documentation for Active Support's Time Conversion functions. [rsanheim, jeremymcanally, chuyeow] Closes #7164 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 05:58:20 +00:00
Michael Koziarski
2eaa8e67c0 Remove Great Britain from the Country select helper to ensure consistency with iso 3166's long_names. Closes #6872 [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 05:55:26 +00:00
Sam Stephenson
b6d9c17af1 Update Prototype to 1.6.0.1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 03:08:29 +00:00
David Heinemeier Hansson
37b1d33ba3 Try again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 02:50:18 +00:00
Jeremy Kemper
e7dab3b166 MySQL: we can't distinguish a fake 0 default in 4.x 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 02:46:28 +00:00
David Heinemeier Hansson
3a622d0045 Fix broken test (closes #10364) [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 02:34:36 +00:00
David Heinemeier Hansson
a5fded3e88 Fix that options[:from] table names should never be quoted [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 02:30:30 +00:00
David Heinemeier Hansson
0aec2423ed Removed some of the tags that does not make sense to allow per default in the whitelist 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-04 20:04:48 +00:00
Thomas Fuchs
cfa31c30b8 Update trunk to script.aculo.us 1.8.0.1, fixes a regression in the autocompleter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-04 18:12:54 +00:00
Rick Olson
112ed30316 Add 'disabled' attribute to <OPTION> separators used in time zone and country selects. Closes #10354 [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-04 05:30:28 +00:00
David Heinemeier Hansson
9663f9952a Make sure that setting the format with a symbol works too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 19:49:22 +00:00
David Heinemeier Hansson
326548770d Copy the cache too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 02:22:06 +00:00
David Heinemeier Hansson
e6f54290af Added ActiveRecord::Base#becomes to turn a record into one of another class (mostly relevant for STIs) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 02:01:21 +00:00
David Heinemeier Hansson
c4cb2dd014 Fixed that to_xml should not automatically pass :procs to associations included with :include (closes #10162) [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 01:47:21 +00:00
Michael Koziarski
f1047173e8 Remove old tests which relied on @ being an ATOM to work around old Mail.app bugs. Closes #10317 [mikel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 20:31:39 +00:00
Marcel Molina
c84c0437d7 Fix documentation typo introduced in [8250]. Closes #10339 [Henrik N] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 19:54:18 +00:00
Michael Koziarski
92f02adf40 Don't escape forward slashes with String#to_json, our unicode encoding of < and > prevent the XSS problems. [tpope] Closes #10273 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 08:45:35 +00:00
Jeremy Kemper
e7c5da6260 Handle 8.1 default formatting. Closes #10333 [Tim Pope] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 03:33:58 +00:00
David Heinemeier Hansson
84ca7e6ef7 Deal with nested fields_for too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 01:10:50 +00:00
David Heinemeier Hansson
d0ce7cd4c7 Added the same record identification guessing rules to fields_for as form_for has [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 00:46:43 +00:00
Michael Koziarski
67442cb40d Fix potential extra space in Array#to_sentence. Closes #10327 [kamal] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 00:28:30 +00:00
Michael Koziarski
c01c28c304 Warn users about the race condition in validates_uniqueness_of. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-01 23:12:49 +00:00
Jeremy Kemper
2a3dc59de0 Don't inadvertently hit const_missing in defined?(ActionMailer::Base) check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-01 21:19:23 +00:00
David Heinemeier Hansson
e47392b81f Added db:fixtures:identity as a way of locating what ID a foxy fixture was assigned (closes #10332) [jbarnette] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-01 20:53:15 +00:00
David Heinemeier Hansson
cc86875a14 Generated fixtures should not specify ids since theyre expected to be foxy fixtures (closes #10330) [jbarnette] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-01 20:51:54 +00:00
Michael Koziarski
c0d1f035fb Remove @ as an ATOM character, syncing with upstream tmail. [mikel] Closes #10317 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-01 08:06:17 +00:00
David Heinemeier Hansson
e03f13c553 Fixed that verification violations with no specified action didn't halt the chain (now they do with a 400 Bad Request) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-30 21:04:57 +00:00
David Heinemeier Hansson
b6d255559e You dont need to explicitly declare which controller youre testing when you follow the naming convention 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-30 18:17:21 +00:00
Michael Koziarski
ea59e9d50a use autoeval not autoirb, it's mostly equivalent but doesn't make stepping frustrating [Koz]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-30 00:08:41 +00:00
Tobias Lütke
a25b2e116c Removed documentation for the removed rollback! method on transactions and mention ActiveRecord::Rollback [cody] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 22:25:42 +00:00
Michael Koziarski
1d32cec17d Allow body to be specified for nested parts with action mailer. Closes #10271 [redinger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
v2.0.0_RC2 		2007-11-29 02:52:49 +00:00
Michael Koziarski
fd3f048f6d Make sure assert_select_rjs gets counted, Closes #10278 [tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 02:49:11 +00:00
Michael Koziarski
e302759451 Make reset return nil when using a dangling belongs_to association. Current behaviour is to return false which can be confusing. Closes #10293 [fcheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 02:19:10 +00:00
Rick Olson
0a9bc591e7 Raise UnknownHttpMethod exception for unknown HTTP methods. Closes #10303 [tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 02:08:51 +00:00
Sam Stephenson
ab73a988ac Update to Prototype -r8232 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 00:39:59 +00:00
David Heinemeier Hansson
54a75de3ec Prep for RC2 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 00:27:53 +00:00
Jeremy Kemper
3a3e7efee9 attr_protected and _accessible use sets of strings instead of arrays of symbols internally. Closes #10300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 20:13:17 +00:00
Jeremy Kemper
a33007d31a attr_readonly uses a set of strings instead of an array of symbols internally. References #10300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 20:12:49 +00:00
Jeremy Kemper
f1d6a0e4d2 Introduce SecretKeyGenerator for more secure session secrets than CGI::Session's pseudo-random id generator. Consider extracting to Active Support later. Closes #10286. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 19:36:59 +00:00
Michael Koziarski
fa866765c2 correct confusing comments 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 04:14:51 +00:00
Michael Koziarski
6a611e1e95 Make sure the optimisation code for routes doesn't get used if :host, :anchor or :port are provided in the hash arguments. [pager, Koz] Closes #10292 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 04:11:37 +00:00
David Heinemeier Hansson
45d679bcb8 Added protection from trailing slashes on page caching (closes #10229) [devrieda] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 00:29:43 +00:00
David Heinemeier Hansson
4d177ae0d6 Added Array#from and Array#to that behaves just from String#from and String#to [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-27 19:42:30 +00:00
Marcel Molina
69165404be Asset timestamps are appended, not prepended. Closes #10276 [mnaberez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-27 06:11:23 +00:00
Jeremy Kemper
c7e3969189 Foxy fixtures: support single-table inheritance. Closes #10234. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8219 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-26 22:46:11 +00:00