github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
23,117 Commits 34 Branches 105 Tags
db8eeaff06009deac2d34337942a8b8414dfd7ba
Commit Graph

23117 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Guillermo Iguaran
db8eeaff06 Allow multiple sources in Sprockets helpers 2011-06-05 01:01:35 -05:00
Jon Leighton
75e56101d4 Bring back oracle specific crap 2011-06-04 23:49:54 +01:00
Jon Leighton
253bb6b926 Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. 2011-06-04 23:47:03 +01:00
Jon Leighton
cdce7ff191 Force RAILS_ENV=development in rackup_test.rb. This fixes a problem on the CI server. For some reason the RAILS_ENV on the CI server is production, which means that the ActionDispatch::Static middleware is not used, and so the request in 'config.ru can be racked up' returns a 404 rather than a 200. 2011-06-04 23:47:03 +01:00
Xavier Noria
1c527afe87 adds Vijay Dev to the new Rails Guides Reviewers team 
See http://weblog.rubyonrails.org/2011/6/2/news-from-the-documentation-front
 2011-06-05 00:13:50 +02:00
Xavier Noria
bcc0a297d7 move Ryan up, since the list is ordered by surname 2011-06-04 14:35:12 +02:00
Xavier Noria
6a2863e78e adds Ryan Bigg to the credits page of the guides, he is the author of the new configuring guide 2011-06-04 14:26:39 +02:00
Xavier Noria
cd8ecec31f specify image dimensions for pictures in the guides credits page 2011-06-04 14:25:54 +02:00
Andrew White
a50865c7dc Add missing require for cookies middleware 2011-06-04 09:35:48 +01:00
Andrew White
d4658d86fe Refactor ActionController::TestCase cookies 
Assigning cookies for test cases should now use cookies[], e.g:

  cookies[:email] = 'user@example.com'
  get :index
  assert_equal 'user@example.com', cookies[:email]

To clear the cookies, use clear, e.g:

  cookies.clear
  get :index
  assert_nil cookies[:email]

We now no longer write out HTTP_COOKIE and the cookie jar is
persistent between requests so if you need to manipulate the environment
for your test you need to do it before the cookie jar is created.
 2011-06-04 07:09:11 +01:00
José Valim
64325a8242 Merge pull request #1468 from castlerock/fix_issue_1467 
Double assignment of attributes on a collection association occurs fixed #1467
 2011-06-03 06:22:35 -07:00
Raghunadh
7ef2f6fc04 Double assignment of attributes on a collection association occurs fixed for the issue issue #1467 2011-06-03 18:52:43 +05:30
Andrew White
54883682de Don't double assign attributes - closes #1467. 2011-06-03 13:57:00 +01:00
Jon Leighton
f064664de7 Fix broken test. You know, the merge button will be the end of us... 2011-06-01 23:13:40 +01:00
Piotr Sarnacki
04593742c4 Merge pull request #1447 from dmathieu/empty_route 
Fix creating an empty route on 1.8. Closes #1210
 2011-06-01 12:47:19 -07:00
Aaron Patterson
63665f6c9f Merge pull request #1385 from smartinez87/drop 
#drop_table accepts no options now.
 2011-06-01 10:52:41 -07:00
Arun Agrawal
7d447c4726 Adding comment 2011-06-01 18:50:43 +01:00
Vishnu Atrai
230f788759 AttributeMethodTest test fix #jruby 2011-06-01 18:50:26 +01:00
Brian Mathiyakom
1e43bd9f35 Fix issue #1272 
Set reverse_order_value when asked to reverse_order().
Do the actual reversal in build_arel.
 2011-06-01 18:29:29 +01:00
José Valim
fba977dfa3 Merge pull request #1448 from ernie/attr_internal_require 
Require attr_internal before using in ActionView::Helpers
 2011-06-01 07:49:25 -07:00
Ernie Miller
3a2ef52ad6 Require attr_internal before using in ActionView::Helpers 2011-06-01 10:30:54 -04:00
Damien Mathieu
8a0ffa7c95 fix creating an empty route on 1.8. Closes #1210 2011-06-01 15:51:36 +02:00
José Valim
1ff4bfc147 Merge pull request #1441 from guilleiguaran/no_rb_require 
Don't add .rb in requires
 2011-06-01 01:13:26 -07:00
Jon Leighton
69c52b0e9a Add missing require to fix the CI 2011-06-01 08:58:50 +01:00
Guillermo Iguaran
698b600719 Don't add .rb in requires 2011-05-31 21:43:04 -05:00
Aaron Patterson
a48b0e5783 Merge pull request #1439 from sikachu/isolated_pg_test 
Isolated PostgreSQL test into PostgreSQL folder
 2011-05-31 19:29:30 -07:00
Prem Sichanugrist
2aaeac9a0a Isolated PostgreSQL test into PostgreSQL folder 2011-05-31 20:56:07 -04:00
Andrew White
cf3364a03c Raise NameError instead of ArgumentError in ActiveSupport::Dependencies 
ActiveSupport::Dependencies now raises NameError if it finds an existing
constant in load_missing_constant. This better reflects the nature of
the error which is usually caused by calling constantize on a nested constant.

Closes #1423
 2011-06-01 01:16:20 +01:00
Josh Kalderimis
eb7ef2ccd6 added an alias for new to build to the AR collection proxy, this corrects an issue where the collection proxies were not consistent 2011-06-01 00:01:35 +01:00
Andrew White
1f34a79373 Make MemCacheStore work with Ruby 1.9 and -Ku 2011-05-31 23:31:35 +01:00
José Valim
87762245e9 Merge pull request #1434 from dmathieu/mass_assignment 
Mass assignment
 2011-05-31 14:52:20 -07:00
Jon Leighton
4067d88df5 Revert "[activerecord][postgresql] verify if table has a schema(not public)". This caused a test breakage. See #1410 for details. 
This reverts commit c44418ea4e.
 2011-05-31 22:46:13 +01:00
Damien Mathieu
70381cf507 no need for .rb 2011-05-31 23:38:51 +02:00
Damien Mathieu
bb828990bd string inflections are needed for running tests in isolation 2011-05-31 23:38:39 +02:00
Xavier Noria
576f712380 standarize documentation (and indirectly code) to use American English as discussed in 4f234bf 
Please do not perform monster patches for this until 3.1 is out.
Also, no existing API should be affected by this. New code, local
variables, etc. would follow this guideline to have a consistent
project tree in this regard.
 2011-05-31 22:56:31 +02:00
Xavier Noria
5888507d6c revises commit from pull request 1408 2011-05-31 22:45:32 +02:00
Xavier Noria
daf4a4f747 revises commit from pull request 1409 2011-05-31 22:45:31 +02:00
Noel Gomez
7b4cd4bb5b Modified generated text to explain where .js and .coffee files can be located and that there shouldn't be blank lines in manifest per this issue http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/effb868290c2c0b8 2011-05-31 22:45:31 +02:00
Noel Gomez
2183f05864 changed text to be more explicit about where stylesheets can be located 2011-05-31 22:45:31 +02:00
Jon Leighton
fbe012e92d Ensure that calculations properly override the select value even if it's set in the default scope. Fixes #1395. 2011-05-31 21:12:20 +01:00
Erik Fonselius
a5806fa409 Failing test for aggregating on default_scope with select 2011-05-31 20:47:30 +01:00
Jon Leighton
dfaad4f5a7 Only save the record once when calling create! on a collection association. Fixes #1360. 2011-05-31 20:32:09 +01:00
Farley Knight
aa316e27b7 Tests for issue #1360 2011-05-31 19:47:34 +01:00
Jon Leighton
60cb96abea Implementing @dmathieu's cleaner fix from #1425. Unfortunately he deleted the branch so I cannot just merge it. 2011-05-31 18:34:27 +01:00
Jon Leighton
0bb8429e71 Reduce test noise 2011-05-31 18:18:14 +01:00
Aaron Patterson
021e4f16b7 Merge pull request #1417 from arunagw/nested_attributes_fix 
Fix nested attribute for memory record.
 2011-05-31 08:46:27 -07:00
José Valim
12786518f1 Update CHANGELOG. 2011-05-31 12:26:32 +02:00
José Valim
139a9f7011 Transform the symbol into a constant lookup. 2011-05-31 12:24:30 +02:00
José Valim
1638435152 Merge pull request #1403 from bogdan/config 
ActiveModel::MassAssignmentSecurity.mass_assignment_sanitizer method
 2011-05-31 03:09:23 -07:00
Arun Agrawal
e04f2c1d42 Opening class CascadedEagerLoadingTest at once. 2011-05-31 12:35:37 +05:30