Commit Graph

15629 Commits

Author SHA1 Message Date
Rizwan Reza
de2b0147d0 Reapply Rizwan's patch, but memoize Bundler.load.specs in an ivar. [#3697 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 17:42:53 -07:00
Paco Guzman
878a9e02f6 html_tag option to wrap error_message_on text [#4283 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 17:27:10 -07:00
Andrew White
26bc5c542e Add ActionDispatch to RDoc task [#4287 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 17:09:37 -07:00
wycats
1b9777e84f Why are we not updating bundler? 2010-03-28 15:46:45 -07:00
Vladimir Andrijevik
edaf92f5ab Drop expires argument from call to @data in MemCacheStore so it works with memcache-client and memcached gems, as advertised [#3672 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 13:57:14 -07:00
Matthew Rudy Jacobs
b0967cc5cf defining a named_scope which overwrites an existing method is now allowed we just log a warning.
This was motivated by the fact that :open is defined on all classes
as such the named_scope "open" can never be used, without hacking
ActiveRecord with an "undef_method" [#4083 state:resolved]

Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 13:53:20 -07:00
wycats
77a2a3d9b3 Request#content_type exists in Rack::Request, and other parts of Rack::Request expect
it to return a String. Split the Rails API so that Request#content_type returns
a String, and Request#content_mime_type returns a Mime::Type object.
2010-03-28 13:40:38 -07:00
Andrew White
e1a70faea6 Add constraints to resources in new routing DSL
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
2010-03-28 23:31:13 +04:30
Jeremy Kemper
5c058295d1 Bump mail dep to 2.1.5.1 2010-03-28 11:44:46 -07:00
Jeremy Kemper
154f9ce5fd Merge remote branch 'mikel/master' 2010-03-28 11:34:30 -07:00
Jeremy Kemper
7e3b4c1f2f Merge branch 'master' of github.com:rails/rails 2010-03-28 11:34:16 -07:00
Jeremy Kemper
d1f3437cac Cosmetics: mismatch indentation 2010-03-28 11:34:09 -07:00
wycats
c99194c7be Merge remote branch 'rizwan/restrict' 2010-03-28 11:06:46 -07:00
Rizwan Reza
f1e5a9ff98 Add :dependent = to has_one and has_many [#3075 state:resolved] 2010-03-28 18:47:46 +04:30
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Xavier Noria
105f9b8154 adds missing requires for Object#duplicable? 2010-03-28 13:26:13 +02:00
Xavier Noria
3b1c69d2dd adds a few requires in active_model/dirty.rb
[#4284 state:committed]
2010-03-28 12:43:20 +02:00
Rizwan Reza
835f5d0269 Rails 3 application can run performance tests now. [#4171 state:resolved] 2010-03-28 15:03:25 +04:30
Rizwan Reza
66d57d7ba8 Oops, a docfix. 2010-03-28 11:10:35 +04:30
Rizwan Reza
6c2a0675f1 When creating database with rake, create schemas in schema_search_path if it doesn't exist. 2010-03-28 11:01:15 +04:30
Mikel Lindsaar
53bcd4af09 Updating mail version requirement to 2.1.5 2010-03-28 17:03:49 +11:00
Mikel Lindsaar
4e0d1cfad7 Fixing up attachment encoding specs to work with latest mail - and be correct 2010-03-28 17:03:33 +11:00
Mikel Lindsaar
b91c57d16c Mail now correctly bundles up the charset into the content type field 2010-03-28 16:24:54 +11:00
Mikel Lindsaar
a41d1b1fb1 Updating test, should be calling :decoded, not :encoded, is a problem now that Mail is fixed 2010-03-28 16:22:37 +11:00
Mikel Lindsaar
63002ba36b Fixing test, ; is a delimiter, not a termination character, ref RFC 2045 2010-03-28 15:24:35 +11:00
Mikel Lindsaar
2bcc2ebf44 Merge branch 'master' of git://github.com/rails/rails 2010-03-28 14:44:34 +11:00
José Valim
8398f21880 Time zone tests were right all along. 2010-03-28 05:38:32 +02:00
watsonian
edd59b7bb9 Fixes typo in environments/production.rb template. 2010-03-27 19:02:05 -07:00
José Valim
a09e99259c Ensure details are frozen after @details_keys lookup. The implementation waits to freeze until the last required moment, to avoid duping hashes. 2010-03-27 20:52:11 +01:00
wycats
fdebc7f55b Missing require 2010-03-27 12:39:28 -07:00
wycats
4b9f167231 Actually check the value of the ivar 2010-03-27 12:17:17 -07:00
Jeremy Kemper
4384a95b51 Bust gem prelude to ensure bundler's in the load path. Not sure what's broken here. 2010-03-27 12:06:27 -07:00
Jeremy Kemper
a98db7c6ef Use Array.wrap uniformly 2010-03-27 11:50:11 -07:00
Jeremy Kemper
c3cea9b594 Fix unstated dep on HWIA 2010-03-27 11:03:36 -07:00
Santiago Pastorino
38bb133881 Ruby's marshaling of Time instances doesn't respect the zone [#4282 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-27 16:44:20 +01:00
Santiago Pastorino
820e3a8491 LINE on class_eval need + 1, also removed comments [#4281 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-27 16:42:52 +01:00
Santiago Pastorino
edbb9526d3 flatten not needed here
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-27 16:42:51 +01:00
José Valim
ff522cf4bc Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app.
To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]

This reverts commit faeca694b3.
2010-03-27 14:39:43 +01:00
José Valim
46b7704b74 Do not need to load ActionPack::VERSION 2010-03-27 12:38:55 +01:00
wycats
26e714d26e Remove stray instance variable to resolve serialization problem [#3769 state:resolved] (ht: Joe Rafaniello) 2010-03-27 04:32:08 -07:00
wycats
bc4cdae3d9 Don't write to /dev/null on mingw. [#3921 state:resolved] (ht: Patrick Daryll Glandien) 2010-03-27 04:15:41 -07:00
wycats
c428fbdb1d Use the new RAILS_VERSION in rake install (ht: ZhangJinzhu) [#4116 state:resolved] 2010-03-27 04:10:40 -07:00
Rizwan Reza
faeca694b3 primary_key now supports :limit for MySQL
Signed-off-by: wycats <wycats@gmail.com>
2010-03-27 03:49:53 -07:00
wycats
0a352056a4 Fixes a bug where error_messages_for was returning an empty div [#4048 state:resolved] (ht: Geoff Garside) 2010-03-27 03:10:05 -07:00
José Valim
418e5fc279 Merge branch 'master' of gitproxy:rails/rails 2010-03-27 11:07:07 +01:00
José Valim
0cb3311d06 Revert "primary_key now supports :limit. [#876 state:resolved]" since it broke AR test suite.
This reverts commit 41e5c7ed44.
2010-03-27 11:05:37 +01:00
José Valim
f1da7174cc Fix tests added in previous commit. 2010-03-27 11:04:21 +01:00
wycats
a24a888afe Limit Array#extract_options! to directl instances of Hash and HWIA. Add extractable_options? to Hash so that subclasses of Hash can opt-into extractable behavior. This fixes an issue where respond_with wasn't working with subclasses of Hash that were provided by other libraries (such as CouchDB or Mashie) [#4145 state:resolved] 2010-03-27 02:59:10 -07:00
Jacob Atzen
a5d637d86c ActiveModel::Dirty#changes should return a HashWithIndifferentAccess [#4157 state:resolved]
Keep the Rails style of inject

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-27 10:48:32 +01:00
José Valim
140cc9caf6 Do not check for a valid const name in Rails 3.0 applications. [#4200 state:resolved] 2010-03-27 10:46:17 +01:00