github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
15,629 Commits 34 Branches 105 Tags
de2b0147d04d5460e576cc21afbb062eb012ea7e
Commit Graph

2976 Commits

Author SHA1 Message Date
Matthew Rudy Jacobs
b0967cc5cf defining a named_scope which overwrites an existing method is now allowed we just log a warning. 
This was motivated by the fact that :open is defined on all classes
as such the named_scope "open" can never be used, without hacking
ActiveRecord with an "undef_method" [#4083 state:resolved]

Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 13:53:20 -07:00
Rizwan Reza
f1e5a9ff98 Add :dependent = to has_one and has_many [#3075 state:resolved] 2010-03-28 18:47:46 +04:30
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Xavier Noria
105f9b8154 adds missing requires for Object#duplicable? 2010-03-28 13:26:13 +02:00
Rizwan Reza
66d57d7ba8 Oops, a docfix. 2010-03-28 11:10:35 +04:30
Rizwan Reza
6c2a0675f1 When creating database with rake, create schemas in schema_search_path if it doesn't exist. 2010-03-28 11:01:15 +04:30
José Valim
ff522cf4bc Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app. 
To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]

This reverts commit faeca694b3.
 2010-03-27 14:39:43 +01:00
Rizwan Reza
faeca694b3 primary_key now supports :limit for MySQL 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 03:49:53 -07:00
José Valim
0cb3311d06 Revert "primary_key now supports :limit. [#876 state:resolved]" since it broke AR test suite. 
This reverts commit 41e5c7ed44.
 2010-03-27 11:05:37 +01:00
Aaron Patterson
3172db12e4 avoiding a few closure references by evaling. [#4223 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 01:41:44 -07:00
Rizwan Reza
41e5c7ed44 primary_key now supports :limit. [#876 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 01:33:42 -07:00
Pratik Naik
68ade93cde Revert "Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved]" 
This reverts commit 3a875e6184.
 2010-03-27 08:22:32 +00:00
Nathaniel Bibler
3a875e6184 Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 00:35:39 -07:00
Kris Selden
afb786ad8a In PostgreSQLAdapter, switch tables query to use current_schemas function [#918 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-26 17:18:33 -07:00
wycats
197904341f Merge branch 'master' into docrails 2010-03-26 15:10:24 -07:00
José Valim
395d6648ce Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object. 2010-03-26 18:47:55 +01:00
Rizwan Reza
5176b28852 Better MySQL Error message. [#3775 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-26 13:25:53 +01:00
chrisfinne
76d2c455c0 Add debugging documentation for _callback_chain to ActiveRecord::Callback 
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
 2010-03-26 14:01:21 +04:30
Jeremy Roman
ffb22bd2be fix habtm documentation to correct typo 
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
 2010-03-26 13:35:56 +04:30
Emilio Tagua
d06a754fdd Remove unused attributes_with_quotes method. 2010-03-25 15:47:16 -03:00
Emilio Tagua
fc2e25734a Move methods from association to relation finder methods. 2010-03-25 15:47:06 -03:00
Emilio Tagua
90a4709601 Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects. 2010-03-25 13:03:30 -03:00
Emilio Tagua
e3a2fae05d Add add_limit_offset! to adapters. 2010-03-25 12:37:38 -03:00
Aaron Patterson
ed21f0c502 expand migration paths before requiring them. [#4240 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-23 18:22:46 -07:00
Sebastian Martinez
10825be40b rake tasks should use the new app generator path [#4257 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-23 14:26:27 +01:00
José Valim
b61f6f5980 Load generators from both lib/rails/generators and lib/generators. Using the former since it's less obstrusive. 2010-03-23 13:40:41 +01:00
Emilio Tagua
d289e15af9 From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that. 
[#4253 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-22 11:48:39 -07:00
Aaron Patterson
541194f641 switching migrations to use require cleans up many warnings [#4234 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-19 09:56:22 -07:00
Aaron Patterson
587f468282 kill where / having method redefine warnings. [#4225 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 13:30:59 -07:00
Aaron Patterson
3911a7c197 squelching more warnings in the AR tests. [#4218 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 10:24:16 -07:00
Aaron Patterson
b652aa8121 cleaning up a bunch of method already defined warnings [#4209 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-17 13:56:33 -07:00
Jeremy Kemper
067b350301 Move require closer to home 2010-03-17 10:11:38 -07:00
Aaron Patterson
843255a763 fixing activerecord tests [#4205 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-17 10:09:14 -07:00
Aaron Patterson
df735cf5b7 fisting uninitialized ivar warnings. [#4198 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-16 15:11:00 -07:00
Aaron Patterson
8c3e46c093 clean up more warnings, remove unnecessary methods, fix eval line numbers. [#4193 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-16 11:48:34 -07:00
Aaron Patterson
5de3698e2b cleaning up many more warnings in activerecord [#4180 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-15 08:57:41 -07:00
Aaron Patterson
95bd56e3cc speeding up clone_attributes, changing readonly to be initialized in def initialize 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-14 17:29:25 -06:00
Aaron Patterson
115230e619 cleaning up some test warnings 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-14 17:28:27 -06:00
Xavier Noria
fe43bbd8c7 keep AssociationProxy#to_a to avoid warning in Array(post.author), and delegate it to @target in association collections 
[#4165 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-12 11:53:22 -08:00
Emilio Tagua
e08c153a08 Arel now fallback to using Arel::Attribute if the table/column doesn't exists. 
[#4142 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-10 13:49:11 -08:00
Aaron Patterson
aad432a9e9 removing spawn from SpawnMethods 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-10 13:29:00 -08:00
Pratik Naik
181c414baa Fix scope loading issue when the table doesn't exist 2010-03-10 11:28:04 +00:00
Carlos Antonio da Silva
47d252f992 Fix associations to call :destroy or :delete based on the right :dependent option 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-09 00:11:34 +01:00
wycats
39d6f9e112 Make many parts of Rails lazy. In order to facilitate this, 
add lazy_load_hooks.rb, which allows us to declare code that
should be run at some later time. For instance, this allows
us to defer requiring ActiveRecord::Base at boot time purely
to apply configuration. Instead, we register a hook that should
apply configuration once ActiveRecord::Base is loaded.

With these changes, brings down total boot time of a
new app to 300ms in production and 400ms in dev.

TODO: rename base_hook
 2010-03-07 06:24:30 -08:00
Aaron Patterson
a424f199a9 drying up more code in associations.rb 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:41:13 -08:00
Aaron Patterson
939291e8f2 deleting repeated code 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:33:29 -08:00
Aaron Patterson
3789539916 converting inject to each and map 
[#4119 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-06 20:31:50 -08:00
Aaron Patterson
45c36ea096 refactoring build_where 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 13:25:12 -08:00
Bryan Helmkamp
a4111bbca0 Update versions of all components to normalize them to new format 2010-03-02 00:32:48 -05:00
José Valim
f3839b2b99 ActiveRecord should raise an error on invalid migration types. 2010-02-28 11:53:48 +01:00