github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,910 Commits 34 Branches 105 Tags
df300a754bf64d0c350fdc8c69408c5bd04b80a3
Commit Graph

25910 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Santiago Pastorino
df300a754b Allow to use ruby-debug in 1.9.3 2011-11-12 15:16:53 -02:00
Jon Leighton
8f20d59e6e Merge pull request #3618 from amatsuda/ad_headers_unmemoizable 
Unneeded require 'active_support/memoizable'
 2011-11-12 06:49:47 -08:00
Akira Matsuda
b74aedff3c Unneeded require memoizable 2011-11-12 23:15:54 +09:00
Xavier Noria
c3035e1800 Merge pull request #3613 from mitio/fix-actionpack-responder-docs 
Fix wording and minor typos in the Responder RDoc
 2011-11-11 10:03:29 -08:00
Dimitar Dimitrov
a766d834a7 Fix wording and minor typos in the Responder RDoc 2011-11-11 19:52:38 +02:00
José Valim
b7052a0c22 Merge pull request #3611 from bogdan/compile_options 
AS::Callbacks::Callback#_compile_option refactored
 2011-11-11 08:03:02 -08:00
Bogdan Gusiev
8483c7c0a6 AS::Callbacks::Callback#_compile_option refactored 2011-11-11 14:27:40 +02:00
Aaron Patterson
1c6d6b637e Merge pull request #3609 from noefroidevaux/issue_3595 
Prevent multiple SHOW TABLES calls when a table don't exists in database...
 2011-11-11 03:38:49 -08:00
Noé Froidevaux
27c5800c9c Prevent multiple SHOW TABLES calls when a table don't exists in database. 2011-11-11 12:09:51 +01:00
José Valim
7352efa6f8 Merge pull request #3607 from bogdan/callbacks 
AS::Callbacks.__run_keyed_callback: remove unused cache
 2011-11-11 02:02:59 -08:00
Vijay Dev
2e5c4717ba change_table bulk test case should check if the connection supports bulk alter 2011-11-11 12:47:03 +05:30
José Valim
81fad6a270 Merge pull request #3603 from vijaydev/change_table_without_block_arg 
Modify change_table to remove the need for the block argument
 2011-11-10 14:39:00 -08:00
Vijay Dev
6e112e4217 Modify change_table to remove the need for the block argument. 2011-11-11 02:47:27 +05:30
José Valim
23101de283 Merge pull request #3600 from vijaydev/migration_arity 
Checking the arity of the block passed to create_table
 2011-11-10 09:37:58 -08:00
Vijay Dev
b805c71655 Checking the arity of the block passed to create_table 
A recent change made to create_table does away with the
need for the block argument. Checking the arity will prevent the
mixing up of the two syntaxes.
 2011-11-10 22:55:13 +05:30
Vijay Dev
74233d48e6 Fixes deprecation warning about passing a template handler 
in the template name while generating guide related pages
like index, layout and credits
 2011-11-10 22:36:20 +05:30
Bogdan Gusiev
08cc49b919 AS::Callbacks.__run_keyed_callback: remove unused cache 2011-11-10 16:42:27 +02:00
José Valim
80f96ebcf5 self.class.name -> self.name (we are already inside a class). 2011-11-10 08:57:09 -02:00
José Valim
bdd76fb5e3 Merge pull request #3592 from avakhov/av-highlight-regexp 
Fix and simplify highlight regexp
 2011-11-10 02:53:43 -08:00
José Valim
909e5cc32d Merge pull request #3591 from tylercoville/fix-plugin-new 
Fixed error with 'rails generate new plugin' where the .gitignore was not
 2011-11-10 02:53:19 -08:00
José Valim
c778f4e84b Merge pull request #3593 from bogdan/callbacks 
AS::Callbacks._define_runner better abstraction
 2011-11-10 02:50:46 -08:00
José Valim
d2cfa982fd Merge pull request #3581 from amatsuda/metal_response_body_19 
AC::Metal#response_body= stores different value in Ruby 1.8 and 1.9
 2011-11-10 00:49:14 -08:00
Bogdan Gusiev
bf6e29e007 AS::Callbacks#_define_runner refactored 
Incapsulate the logic of keyed callback method definition and execution
in the separated method.
 2011-11-10 10:25:27 +02:00
Alexey Vakhov
b5c3987294 Fix and simplify highlight regexp 2011-11-10 11:26:42 +04:00
Tyler Coville
49349089ad Fixed error with 'rails generate new plugin' where the .gitignore was not properly generated if --dummy-path was used and added test case 2011-11-09 23:22:26 -08:00
Akira Matsuda
be7ab83b64 A test case to ensure that AC::Metal#response_body= always wraps the given value in an Array in both Ruby 1.8 and 1.9 (refs #3581) 2011-11-10 10:54:56 +09:00
José Valim
a625523e75 Don't marshal dump twice when using encryptor. 2011-11-09 20:21:52 -02:00
José Valim
71e84a3b51 Deprecated ActiveSupport::MessageEncryptor#encrypt and decrypt. 2011-11-09 20:04:42 -02:00
José Valim
4c59170bb3 Merge pull request #3589 from amatsuda/console_extend_command_bundle_fix 
Extend IRB right before starting IRB to remove dependency on IRB from Rails::Application
 2011-11-09 14:04:04 -08:00
Akira Matsuda
a658fd2ffa Extend IRB right before starting IRB to remove dependency on IRB from Rails::Application 2011-11-10 06:59:55 +09:00
José Valim
f686d9429f Use head :no_content on the guides as well. 2011-11-09 19:06:02 -02:00
José Valim
4857339aab Merge pull request #3509 from amatsuda/console_extend_command_bundle 
move Rails console top level methods to IRB context
 2011-11-09 02:14:50 -08:00
Akira Matsuda
6d09f275c6 Modulize Rails console methods so that other console libraries such as Pry can include these methods 2011-11-09 15:42:19 +09:00
Vijay Dev
fba28ece7e Merge pull request #3579 from arunagw/missing_md_in_changelog 
CHANGELOG => CHANGELOG.md
 2011-11-08 22:26:31 -08:00
Arun Agrawal
f642724f27 CHANGELOG => CHANGELOG.md 
I missed these in previous commit
 2011-11-09 11:54:07 +05:30
Vijay Dev
2843d3b277 Merge pull request #3574 from arunagw/refactor_testing_uncommitted_task 
Refactor test:uncommitted task.
 2011-11-08 22:15:29 -08:00
Arun Agrawal
5f826ea26f Refactor test:uncommitted task. 
Thanks to @sobrinho (Gabriel Sobrinho)
 2011-11-09 09:46:51 +05:30
Aaron Patterson
6e87281b5f Merge pull request #3572 from amatsuda/ar_exists_uniq_order 
exclude ORDER BY clause when querying Relation#exists?
 2011-11-08 12:39:50 -08:00
Akira Matsuda
74c6e80cab exclude ORDER BY clause when querying Relation#exists? 2011-11-09 04:51:11 +09:00
Vijay Dev
5b21bfa848 Merge pull request #3562 from rahul100885/rahul100885_work 
Updated Rakefile as CHANGELOG has been renamed to CHANGELOG.md
 2011-11-08 10:04:41 -08:00
Rahul Chaudhari
8e5686658e Updated Rakefile as CHANGELOG has been renamed to CHANGELOG.md 2011-11-08 23:20:38 +05:30
Vijay Dev
cff1d751d0 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	railties/guides/source/active_record_querying.textile
 2011-11-08 21:35:17 +05:30
Joost Baaij
1ffd5ec910 Replace example with SQL placeholder syntax. 
This works just fine, is less code, and reduces the risk of someone implementing a SQL injection vulnerability.
 2011-11-08 16:27:15 +01:00
Alexey Vakhov
979f3f894b Fix small typo in link_to_function doc 2011-11-08 18:01:19 +04:00
José Valim
34f61f8b1d Merge pull request #3568 from bfolkens/master-url_subdomain_with_numeric_host 
Fix trouble using :subdomain in development environment when using numeric addresses.
 2011-11-08 06:00:22 -08:00
Bradford Folkens
bd559b0068 Fix trouble using :subdomain in development environment when using numeric addresses. 
See-also pull request #3561 from 3-1-stable

    Otherwise the following occurs:

    TypeError: can't convert nil into String
        /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:75:in host_or_subdomain_and_domain'
        /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:37:in url_for'
        /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/routing/url_for.rb:147:in test_subdomain_may_be_accepted_with_numeric_host'
        /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in run'
        /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:426:in send'
        /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:81:in run'
 2011-11-08 07:52:35 -06:00
José Valim
1347665d89 Merge pull request #3564 from arunagw/uncommitted_rake_fix 
Should be checking if file exists or not.
 2011-11-08 02:28:41 -08:00
Arun Agrawal
fe67501e62 Should be checking if file exists or not. 
I found this bug when running rake test:uncommitted 
on a newly generated rails app which don't have
test file for application_controller.
Can see detail here #3461
 2011-11-08 15:51:47 +05:30
Xavier Noria
805e39b025 Merge pull request #3565 from arunagw/warning_remove_release_file 
Warnings removed.
 2011-11-08 01:24:58 -08:00
Arun Agrawal
b3175f6cb9 Warnings removed. 2011-11-08 14:28:28 +05:30