Santiago Pastorino
df8a941a43
Revert "connection reader is defined later"
...
This reverts commit f4cce71d96
2010-08-15 08:03:17 -03:00
Santiago Pastorino
6d68cde2c5
connection reader is defined later
2010-08-15 07:21:10 -03:00
Santiago Pastorino
0f1b9bbbf8
Makes topics.written_on null => true back again some tests rely on that
2010-08-15 07:20:58 -03:00
Santiago Pastorino
477a9d4d86
MySQL2 added to CI
2010-08-14 21:56:29 -03:00
Santiago Pastorino
a036999ed1
Should be Boolean there
2010-08-14 19:49:33 -03:00
Santiago Pastorino
707248a629
Add missing model
2010-08-14 18:50:15 -03:00
Santiago Pastorino
ecf59b4776
Both tests are using the same model, move the model to another file and add the missing require
2010-08-14 18:50:07 -03:00
Santiago Pastorino
677564f8f7
object/try should be required after abstract_unit to have AS in the load path
2010-08-14 18:34:15 -03:00
Mark Hayes
f6f7ae4020
in Rendering objects with RecordIdentifier example, locals should reference @account not @buyer
2010-08-14 13:26:03 +02:00
Santiago Pastorino
b3ece73114
deprected -> deprecated
2010-08-14 13:26:03 +02:00
Subba Rao Pasupuleti
76c91a237c
Adding missing required statement
...
[#5056 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-08-14 06:28:54 -03:00
Santiago Pastorino
05ba082c6a
Fixes some ActionMailer tests
2010-08-14 05:59:05 -03:00
Santiago Pastorino
3270c58ebb
Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;)
2010-08-14 04:20:06 -03:00
Santiago Pastorino
ccd4364a13
Makes AR use AMo to_key implementation
...
[#5249 ]
2010-08-13 22:28:26 -03:00
Santiago Pastorino
6373dd466f
This method is actually not used, it's implemented on the concrete adapters
...
[#5331 state:committed]
2010-08-13 21:20:50 -03:00
Aaron Patterson
59e63e76c3
converting to a symbol is not necessary
2010-08-13 16:50:22 -07:00
Prem Sichanugrist
433d7a26fe
Removing most of the symbol to proc usage in Active Record
...
This will hopefully make Active Record run a bit more faster.
2010-08-13 16:22:54 -07:00
Aaron Patterson
79e15f0340
removing a lolinject
2010-08-13 14:45:06 -07:00
Santiago Pastorino
3698da65e5
Moves local_request? to require.local?
...
[#5361 state:committed]
2010-08-13 18:17:26 -03:00
Aaron Patterson
108179b068
avoid direct use of arel constants
2010-08-13 13:32:48 -07:00
Aaron Patterson
bacf78150c
removing references to arel constants
2010-08-13 12:35:58 -07:00
Aaron Patterson
e86b758592
avoiding symbol to proc again
2010-08-13 12:35:58 -07:00
Aaron Patterson
abd973689d
do not use arel constants directly
2010-08-13 12:35:58 -07:00
Aaron Patterson
fb6edb1769
symbol to proc is slow, we should avoid it
2010-08-13 12:35:58 -07:00
Jeremy Kemper
e4283007d6
It's snowing!
2010-08-12 13:32:39 -07:00
Xavier Noria
91ae6e9933
be more precise re :validate and :autosave
2010-08-12 19:32:26 +02:00
Subba Rao Pasupuleti
fe2d65864e
no callbacks should be created for empty array [ #5289 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-12 13:13:41 -03:00
Subba Rao Pasupuleti
9df227983f
tidy up validations length code [ #5297 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-12 13:13:37 -03:00
Greg Campbell
d03a1249a0
Add missing ActiveModel::Validations require
...
[#5311 state: resolved]
ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport. (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-12 13:13:33 -03:00
Neeraj Singh
9528aa9f86
Ensure we can nest include calls [ #5285 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-12 13:13:26 -03:00
Xavier Noria
4dcce5d06e
revises some autosave docs, style and content
2010-08-12 17:40:32 +02:00
Paco Guzman
ab68d4b52e
applied guidelines to "# =>"
2010-08-12 17:40:20 +02:00
Xavier Noria
1e6e868d8c
commit review: applies guidelines to "# =>"
2010-08-12 17:40:10 +02:00
Neeraj Singh
198bffe3be
updating documentation for named_scope and default_scope
2010-08-12 17:39:52 +02:00
Neeraj Singh
06af291346
adding more documentation for autosave option
2010-08-12 17:39:05 +02:00
José Valim
30ea923040
Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation.
2010-08-12 12:06:57 -03:00
Mark Turner
7325dd21b3
fixed indentation in test cases
...
Signed-off-by: wycats <wycats@gmail.com >
2010-08-11 23:56:11 -07:00
wycats
f2d22ecbb3
Replace snowman with utf8=✓
2010-08-11 18:37:06 -07:00
Paul Hieromnimon
1c970b8394
Raising exception if fixture file can't be found
2010-08-11 15:45:29 -07:00
Aaron Patterson
c8509d5303
subtracting blank strings is slightly faster than blank?
2010-08-11 15:44:54 -07:00
Xavier Noria
36cb62eb9d
AS guide: some revisions
2010-08-12 00:15:43 +02:00
Xavier Noria
bfd728182c
no need to assign if we are gonna return
2010-08-12 00:15:43 +02:00
Aaron Patterson
ff760dd6ce
avoid multiple hash lookups
2010-08-11 14:59:47 -07:00
Aaron Patterson
5352a89d50
dry up the hash dup and avoid sending nil values
2010-08-11 14:45:07 -07:00
Aaron Patterson
a56ee4c9a2
avoiding tap saves us time
2010-08-11 11:43:27 -07:00
Aaron Patterson
dac2b37b03
unless Array#empty? is faster than if Array#present?
2010-08-11 11:28:13 -07:00
Aaron Patterson
8464ee0650
stop using private methods
2010-08-11 11:24:59 -07:00
José Valim
e1b85c3bda
Ensure @config is not a reserved instance variable in controllers. [ #5342 state:resolved]
2010-08-11 10:27:11 -03:00
José Valim & Carlos Antonio da Silva
1fbcd5f5fc
layout_for works again with objects as specified in the documentation and Rails 2.3 [ #5357 state:resolved]
2010-08-11 10:27:11 -03:00
Nick Sieger
43b8722f4b
Missed one spot for --skip-active-record, which means that new Gemfile isn't set up right
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-08-11 00:43:49 -03:00
