github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-03 18:55:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,438 Commits 34 Branches 105 Tags
e32149ad600796efcf7191eff0946ca9616c4d65
Commit Graph

6438 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Koziarski
e32149ad60 Correct typo in before_type_cast code. Closes #11165 [amishyn] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-19 21:01:10 +00:00
Jeremy Kemper
ec98a720ec Remove mysql option from a test that applies to all databases. References #11154. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8897 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-19 06:01:54 +00:00
Jeremy Kemper
331d9c0491 Don't assume all records from nested include are of same class. Closes #11154 [acechase] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-19 02:56:05 +00:00
Michael Koziarski
21c75e545a Ensure nested preloading works when associations return nil. Closes #11145 [GMFlash] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-18 04:49:56 +00:00
Michael Koziarski
cae1d960d2 Check the host string contains %d before using String#%, this avoids warnings. Closes #10809 [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-18 01:02:29 +00:00
Michael Koziarski
db4f421b0b Add :trailing_slash option to UrlWriter. Closes #9117 [juanjo.bazan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-18 00:42:06 +00:00
Michael Koziarski
8bbabd43a9 Add user and password configuration options to ActiveResource::Base, not all credentials can be specified inline. Closes #11112 [ernesto.jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-18 00:21:18 +00:00
Michael Koziarski
f2546164d6 Make dynamic finders respect the :include on HasManyThrough associations. Closes #10998. [cpytel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8890 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-18 00:14:54 +00:00
Jeremy Kemper
23e58a0552 Fix observed_class. References #11099. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-17 22:52:55 +00:00
Jeremy Kemper
5457770a36 Pass array of addresses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-17 20:07:40 +00:00
Michael Koziarski
1a59aa5196 Update generated comments to reflect the fact that config.frameworks works fine with gems now. Closes #11135 [fxn] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-17 09:11:31 +00:00
Geoff Buesing
4a643f686a Adding TimeWithZone#between? 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-17 00:35:49 +00:00
Geoff Buesing
25e139e545 Time.=== returns true for TimeWithZone instances 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 23:39:40 +00:00
Geoff Buesing
e7ebd656b3 TimeWithZone #+ and #- behave consistently with numeric arguments regardless of whether wrapped time is a Time or DateTime; consistenty answers false to #acts_like?(:date) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 23:15:59 +00:00
Geoff Buesing
3025ff28cc Tests for distance_of_time_in_words with TimeWithZone instances. Closes #10914 [ernesto.jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 21:16:03 +00:00
Geoff Buesing
2920bd22df ActiveRecord::Base#instantiate_time_object only uses Time.zone when Base.time_zone_aware_attributes is true; leverages Time#time_with_datetime_fallback for readability 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 20:47:01 +00:00
Geoff Buesing
4e3ecec9c7 Refactor ActiveRecord::ConnectionAdapters::Column.new_time: leverage DateTime failover behavior of Time#time_with_datetime_fallback 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 20:13:38 +00:00
Michael Koziarski
1d5ea1857f Sort files to test to make load order platform independent. Fix the clash this exposes. Closees #11081 [tpope] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 03:08:05 +00:00
Michael Koziarski
86cb0a61fb Ensure that :confirm doesn't need extra quotes when using drop_receiving_element. Closes #8299 [thechrisoshow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 00:07:52 +00:00
Michael Koziarski
4ff26f51f6 Add String#squish and String#squish! to remove consecutive chunks of whitespace. Closes #11123 [jordi, Henrik N] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-16 00:02:30 +00:00
Michael Koziarski
191ffc9456 Serialize BigDecimals as Floats when using to_yaml. Closes #8746 [ernesto.jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-15 23:33:43 +00:00
Michael Koziarski
3028ca5955 Clear active connections before trying to drop the database. Allows db:drop to work with posgresql. Closes #10559 [jqr] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-15 23:16:01 +00:00
Michael Koziarski
f3fd2b18b7 Add test for Observer#observer_class and change the implementation slightly. Closes #11099 [ernesto.jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-15 23:09:51 +00:00
Jeremy Kemper
c55120c8e6 Revert [8865], broke AP record identifier. Reopens #11109. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-15 21:47:27 +00:00
Jeremy Kemper
6f0b0125d0 Fix typo in migration test. Closes #11105 [h-lame] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-15 20:12:45 +00:00
Michael Koziarski
c75abf058e Avoid repeated calls to Base#connection. Closes #11111 [adymo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8871 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-14 20:09:05 +00:00
Michael Koziarski
838b02450a Optimisation for BigDecimal conversion code. Closes #11110 [adymo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-14 20:06:25 +00:00
Michael Koziarski
039f724c7b Minor formatting changes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8869 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-14 20:02:19 +00:00
Rick Olson
de048b1009 Improve associations performance by using symbol callbacks instead of string callbacks. Closes #11108 [adymo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-14 07:53:37 +00:00
Rick Olson
8a2266c020 Improve associations performance by avoiding named block arguments. Closes #11109 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8865 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-14 07:24:09 +00:00
Jeremy Kemper
dfa786631b Introduce the :readonly option to all associations. Records from the association cannot be saved. Closes #11084. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-13 06:32:50 +00:00
Michael Koziarski
08a4c9979d Remove options from the attributes method, tidy up the implementation. Closes #11093 [juanjo.bazan, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8863 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-13 02:19:46 +00:00
Michael Koziarski
46356100d1 Make sure render :update support the options hash. Closes #11088 [ernesto.jimenez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-12 22:42:36 +00:00
Jamis Buck
11787b802a remove support for ampersand-delimited cookie values 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-12 21:45:39 +00:00
Michael Koziarski
8739390134 Avoid cloning in Base#attributes_before_typecast. Closes #11077 [juanjo.bazan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8858 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-11 21:02:17 +00:00
Michael Koziarski
081eed352f Fix the pre-quoted table names in the eager tests. [mislav] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-11 07:24:25 +00:00
Michael Koziarski
d4daf7bba7 Fix eager loading with pre-quoted table names. Closes #11046 [danielmorrison, Koz, Jeremy Kemper] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-11 02:50:58 +00:00
Geoff Buesing
c9402b2277 Multiparameter attributes for time columns fail over to DateTime when out of range of Time 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 22:46:31 +00:00
Geoff Buesing
6608a3ef37 Adding TimeWithZone #to_yaml, #to_datetime, #eql? and method aliases for duck-typing compatibility with Time 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8854 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 22:26:16 +00:00
Geoff Buesing
8ad5a29cef TimeWithZone #in_time_zone returns +self+ if zone argument is the same as #time_zone 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 20:35:47 +00:00
Geoff Buesing
8831180b15 Adding TimeWithZone #to_a, #to_f, #to_i, #httpdate, #rfc2822 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 20:04:14 +00:00
Geoff Buesing
163a4c6f45 Pruning unneeded TimeWithZone#change_time_zone_to_current 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 19:15:32 +00:00
Geoff Buesing
b9be374ddd Time#zone=, #in_time_zone and #change_time_zone accept a Duration 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 19:02:30 +00:00
Geoff Buesing
db4fc6f206 Time#in_time_zone handles Time.local instances correctly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 18:45:55 +00:00
Geoff Buesing
521714a39d Pruning unneeded Time#change_time_zone_to_current. Enhanced docs for #change_time_zone 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 18:20:37 +00:00
Geoff Buesing
94fa9fb745 TimeZone#new renamed #local, so that new TimeWithZone instances can be created via Time.zone.local() 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 17:02:22 +00:00
Michael Koziarski
2c8fb682cb Show RecordInvalid in the documentation. References #10976 [kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-10 02:49:11 +00:00
Michael Koziarski
5396b0f3b0 Use HEAD instead of GET inside exists? Closes #11062 [bscofield] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-09 22:21:55 +00:00
Michael Koziarski
9e13b966f6 Move SecretKeyGenerator comments to the correct place for rdoc. Closes #10940 [FooBarWidget] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-09 22:18:38 +00:00
Michael Koziarski
3df052ac60 Remove misleading / incorrect warning from validation documentation. Closes #8241 [quixoten, pedz, tom] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-09 08:24:35 +00:00