github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
26,252 Commits 34 Branches 105 Tags
e51ecfaaa32fde3ada4583ade4328546fef1e421
Commit Graph

26252 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Leighton
e51ecfaaa3 extract method 2011-11-29 20:13:37 +00:00
Jon Leighton
7af719e81c Deprecate set_sequence_name in favour of self.sequence_name= 2011-11-29 20:13:37 +00:00
Jon Leighton
fd7ca98bb6 Add tests for set_sequence_name etc 2011-11-29 20:13:36 +00:00
Jon Leighton
34609d67b4 Deprecate set_inheritance_column in favour of self.inheritance_column= 2011-11-29 20:13:36 +00:00
Jon Leighton
0b72a04d0c Deprecate set_table_name in favour of self.table_name= or defining your own method. 2011-11-29 20:13:36 +00:00
Aaron Patterson
f73f53455a respond_to? information of AR is not the responsibility of the spec 
resolver.
 2011-11-29 11:48:55 -08:00
Jon Leighton
2169603385 Merge pull request #3636 from joshsusser/master 
association methods are now generated in modules
 2011-11-29 10:09:42 -08:00
Josh Susser
c347b3c06c don't change class definition in test case 2011-11-29 09:14:21 -08:00
Jon Leighton
d534c8fbe2 Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the connection adapter) 2011-11-29 12:47:54 +00:00
Jon Leighton
1defb6adb8 Fix schema_cache_test.rb for sqlite3_mem 2011-11-29 12:29:42 +00:00
Vijay Dev
6e399acaa8 Merge pull request #3797 from HeeL/test 
splited a long line to shorter ones
 2011-11-29 02:23:06 -08:00
Sergey Parizhskiy
69d56cb933 splited a long line to shorter ones 2011-11-29 11:50:02 +02:00
Vijay Dev
42d70d9852 Merge pull request #3790 from masterkain/patch-1 
Fix typo in AS::TaggedLogging
 2011-11-29 00:30:00 -08:00
José Valim
913c42a6a9 Merge pull request #3793 from marcandre/asset_host 
Handle correctly optional parameters for callable asset_host.
 2011-11-28 23:56:42 -08:00
Marc-Andre Lafortune
d3bc12b27f Handle correctly optional parameters for callable asset_host. 2011-11-29 02:01:18 -05:00
Claudio Poli
2a76f33b51 Fix typo in AS::TaggedLogging 2011-11-29 00:26:58 +01:00
Aaron Patterson
52a9884ce4 remove unused instance variable 2011-11-28 15:23:26 -08:00
Aaron Patterson
beff819a4d just check in all connections 2011-11-28 15:23:26 -08:00
Aaron Patterson
884a04007f remove useless class_eval 2011-11-28 15:23:25 -08:00
Aaron Patterson
dde2113867 Move connection resoluion logic to it's own testable class. 2011-11-28 15:23:25 -08:00
Aaron Patterson
30f7c59e90 clean up string => hash conversion for connection pool 2011-11-28 15:23:25 -08:00
Aaron Patterson
ffb218c750 pools are 1:1 with spec now rather than 1:1 with class 2011-11-28 15:23:25 -08:00
Aaron Patterson
2a9a8ad4df break establish_connection to smaller methods 2011-11-28 15:23:24 -08:00
Jakub Kuźma
d1afd98746 added information about callbacks created by autosave association (#3639) 2011-11-28 19:37:00 +01:00
Aaron Patterson
ba0b3eee14 Merge pull request #3768 from janv/master 
Test and fix for Issue 3450
 2011-11-28 09:35:43 -08:00
José Valim
a0c61c81d7 Merge pull request #3785 from lest/backtrace-cleaner-env 
Put backtrace_cleaner to env
 2011-11-28 08:43:14 -08:00
lest
fe7d4f09ef put backtrace_cleaner to env 2011-11-28 19:25:37 +03:00
Vijay Dev
970caea5bc Merge pull request #3783 from HeeL/master 
fixed a typo in a travis message
 2011-11-28 07:18:22 -08:00
Sergey Parizhskiy
cc5f68d56b fixed a typo in a message when there is no failuresin a build 2011-11-28 16:45:40 +02:00
José Valim
f4ce002c0e Merge pull request #3278 from arunagw/rails_rake_task_warning 
Global variable `$rails_rake_task' not initialized Warning removed
 2011-11-28 04:25:55 -08:00
Arun Agrawal
8ef1ec427f global variable `$rails_rake_task' not initialized Warning removed 2011-11-28 17:35:10 +05:30
José Valim
5f75a92c32 Merge pull request #3657 from arunagw/mysql2_bump_master 
Bump Mysql2!
 2011-11-28 03:15:30 -08:00
Vijay Dev
9ca58ba492 Revert "use any? to check for size" 
This reverts commit c4af5f00f6.
 2011-11-28 16:29:55 +05:30
José Valim
89925e817c Revert "Use any instead of length" 
This reverts commit 1756629835.
 2011-11-28 11:18:39 +01:00
Xavier Noria
152bd3c510 Revert "Used any? instead of length call" 
Reason: This is slower, and any? is not equivalent in the
general case.

See discussion in https://github.com/rails/rails/pull/3779

This reverts commit 20cbf8eddc.
 2011-11-28 11:07:01 +01:00
José Valim
ad5c8b0d52 Merge pull request #3776 from nashby/add-namespace-to-form 
add namespace options to form_for
 2011-11-27 23:59:36 -08:00
Vasiliy Ermolovich
2559256963 update CHANGELOG 2011-11-28 10:54:12 +03:00
José Valim
5cf56a4e77 Merge pull request #3779 from rahul100885/rahul100885_work 
Used any? instead of length call
 2011-11-27 23:13:39 -08:00
Rahul P. Chaudhari
20cbf8eddc Used any? instead of length call 2011-11-28 12:07:31 +05:30
Josh Susser
124c97fbe2 avoid warnings 
This change uses Module.redefine_method as defined in ActiveSupport.
Making Module.define_method public would be as clean in the code, and
would also emit warnings when redefining an association. That is pretty
messy given current tests, so I'm leaving it for someone else to decide
what approach is better.
 2011-11-27 14:15:40 -08:00
Josh Susser
10834e975a changelog & docs for GeneratedFeatureMethods 2011-11-27 14:12:46 -08:00
Jan Varwig
cba5a3a367 Test case and fix for rails/rails#3450 
Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true
 2011-11-27 22:29:56 +01:00
Jon Leighton
b00cf122e2 Merge pull request #3748 from samsonasu/has_many_custom_pk_new_record 
New records should load has_many relationships with custom primary keys
 2011-11-27 13:05:19 -08:00
Vasiliy Ermolovich
fb8b555c49 add namespace options to form_for 
You can provide a namespace for your form to ensure uniqueness of id attributes on form elements.
The namespace attribute will be prefixed with underscore on the generate HTML id
 2011-11-27 23:41:23 +03:00
Santiago Pastorino
af3aacaa47 Merge pull request #3773 from rahul100885/rahul100885_work 
Use any instead of length
 2011-11-27 12:11:41 -08:00
José Valim
0b7cd7b570 Merge pull request #3771 from kennyj/fix_rake_test_warnings 
Call a block passed rake_tasks method in the self context
 2011-11-27 11:25:07 -08:00
Josh Susser
61bcc318c8 use GeneratedFeatureMethods module for associations 2011-11-27 11:22:12 -08:00
José Valim
e7e046fa1c Merge pull request #3769 from kennyj/fix_index_html 
avoid url started with "/" for the rails.png in public/index.html
 2011-11-27 07:12:15 -08:00
José Valim
ee8db25e64 Merge pull request #3772 from lest/label-with-block 
fix label with block in erb
 2011-11-27 06:47:32 -08:00
Rahul P. Chaudhari
1756629835 Use any instead of length 2011-11-27 20:02:09 +05:30