github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
10,130 Commits 34 Branches 105 Tags
e61afed6f8d2ef6a580ba00a5beaaaf0bf2ddb9a
Commit Graph

10130 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jarl Friis
e61afed6f8 My suggestion to fix ticket 2401 [#2401 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-02 11:55:24 -07:00
Aaron Patterson
49bdbebca6 wycats forgot a +1, so I added it [#2749 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-02 11:39:06 -07:00
Levin Alexander
ab2d6abb55 make #inspect if zero length duration return '0 seconds' instead of empty string [#2838 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-02 11:22:25 -07:00
Yehuda Katz + Carl Lerche
cf5b2b250f Fixes a number of tests that inexplicably didn't fail when we committed the original patch 2009-07-02 10:50:25 -07:00
Tieg Zaharia
51d7b3070c Adds a video_tag helper for the HTML5 video tag (similar to how the image_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-02 10:36:38 -07:00
J.D. Hollis
9eab435631 Only check for built extensions on gem dependencies that are in vendor/gems. [#2825 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-02 10:27:54 -07:00
Elliot Winkler
8bb510f6c1 Patch FormTagHelper so that when a form tag is created, the div which holds the form authenticity token is set to display:inline [#2846 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-01 17:12:08 -07:00
Yehuda Katz + Carl Lerche
ee7d4c47e7 Fixes bug where Memcached connections get corrupted when an invalid expire is passed in [#2854 state:resolved] 2009-07-01 16:56:43 -07:00
Akira Matsuda
92bff2ebf1 Fix pattern to match various magic comment formats 2009-07-01 16:26:15 -07:00
Jeremy Kemper
49824e8ad6 JSON.escape returns UTF-8 strings 
[#2849 state:resolved]
 2009-07-01 16:22:19 -07:00
Jeremy Kemper
f37a2ea84c uses Hash#except/slice 2009-07-01 16:01:20 -07:00
Yehuda Katz + Carl Lerche
8e3e362aed Forgot to commit the new file. This is slightly embarrassing. 2009-07-01 15:26:14 -07:00
Yehuda Katz + Carl Lerche
1a6f4d424a Apparently stdlib isn't std enough 2009-07-01 15:20:02 -07:00
Yehuda Katz + Carl Lerche
3990c128ef Modify isolation test to require a file not in use anywhere in Rails 2009-07-01 15:06:11 -07:00
Yehuda Katz + Carl Lerche
677f74dd0d Updates CI to use latest mocha 2009-07-01 13:50:05 -07:00
Jeremy Kemper
e7312105c7 Merge branch 'master' of git@github.com:rails/rails 2009-07-01 12:55:19 -07:00
Yehuda Katz + Carl Lerche
1026d7706f Original cache objects should not be immutable [#2860 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-01 12:16:55 -07:00
Yehuda Katz + Carl Lerche
16dc139caa Added AR:B#dup method for duplicationg object without frozen attributes [#2859 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-01 12:16:35 -07:00
Yehuda Katz + Carl Lerche
882dd4e605 ensure Inflector.camelize works with symbols [#2856 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-01 12:14:34 -07:00
Yehuda Katz + Carl Lerche
7583a24ee0 Move mocha down below initial T::U require and bump version to 0.9.7 [#2858 state:resolved] 2009-07-01 11:53:17 -07:00
Yehuda Katz + Carl Lerche
0515256fd3 Accept Symbol for contoller name [#2855 state:resolved] 
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
 2009-07-01 11:16:18 -07:00
Yehuda Katz + Carl Lerche
eea7b5db1d Crazy hacks to get the Isolation testing module to work on non forking environments 2009-06-30 17:39:32 -07:00
Pratik Naik
45e6f19925 Revert "Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [#2118 state:resolved]"" 
This reverts commit 80f1f863cd.

The feature doesn't work on Postgres, so don't test it on Postgres.
Also, Postgres compatibility is irrelevant to the ticket/patch in question.
 2009-07-01 00:02:00 +01:00
Carl Lerche
db3de78a83 Bump up the version to 3.0.pre 2009-06-30 14:37:12 -07:00
Carl Lerche
132e6d0063 Add #concat to Rails::Application::Path 2009-06-30 13:55:11 -07:00
Carl Lerche
f281745056 Test that builtin_directories is only used in development mode 2009-06-30 13:53:03 -07:00
Yehuda Katz + Carl Lerche
575b95ea0b Created AS::Testing::Isolation which runs each test case in a separate process. 
This allows for testing rails bootup (files are required, correct constants are
	set, etc...). Currently, this is implemented via forking only, but we will add 
	support for jruby and windows shortly.
 2009-06-30 12:00:50 -07:00
Carl Lerche
9101941c12 Require core_ext/kernel/requires in test_help to providing #require_library_or_gem 2009-06-30 09:05:53 -07:00
Carl Lerche
f66b5d79c1 Stop the initializer from blowing up when builtin_directories is empty 2009-06-30 09:01:46 -07:00
Carl Lerche
4954379283 Remove stray checks for Rspec in the testing setup. 2009-06-30 08:41:17 -07:00
Justin French
7d548f795d Changed ActiveRecord::Base.human_name to underscore the class name before it humanizes it 
This gives you 'Post comment' rather than 'Postcomment' by default.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2120 state:committed]
 2009-06-30 15:24:04 +12:00
Chris Mear
085db5e128 Make text_area_tag escape contents by default. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2015 state:committed]
 2009-06-27 13:16:52 +12:00
Vicente Mundim
68b02cb00a Make filter_parameters work correctly with array parameters. 2009-06-27 12:43:57 +12:00
Yehuda Katz + Carl Lerche
188a892c5a Starting to replace scattered path configuration settings with the path object 2009-06-26 17:32:05 -07:00
Yehuda Katz + Carl Lerche
4153c6b720 Finished a first stab at the Rails application path object. 2009-06-26 15:37:52 -07:00
Yehuda Katz + Carl Lerche
b0774281ef Update paths to support an explicit root and multiple paths per category 2009-06-26 15:37:52 -07:00
Yehuda Katz + Carl Lerche
728e3b4047 Simple initial Paths impl 2009-06-26 15:37:52 -07:00
Yehuda Katz + Carl Lerche
2865421f5d Checkpoint. Added a bunch of TODOs and some changes after further going through the initializer 2009-06-26 15:37:52 -07:00
Michael Koziarski
b5dfdc714f Make sure the wrapped exceptions also have the original exception available. 
[#2419 state:committed]
 2009-06-26 17:01:21 +12:00
Michael Schuerig
00a5fd3d18 Translate foreign key violations to ActiveRecord::InvalidForeignKey exceptions. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-26 16:52:55 +12:00
Michael Schuerig
53a3eaa860 Translate adapter errors that indicate a violated uniqueness constraint to ActiveRecord::RecordNotUnique exception derived from ActiveReecord::StatementInvalid. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-26 16:52:54 +12:00
Christos Zisopoulos
18a97a6601 Handle missing javascript/stylesheets assets by raising an exception 
An exception will be raised if a local javascript/stylesheet file included
by the stylesheet_link_tag or javascript_include_tag can not be found.

When caching is enabled, we use atomic_write to ensure that the cache file
is not created with zero length.

Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#2738 state:committed]
 2009-06-26 16:47:15 +12:00
Yehuda Katz + Carl Lerche
8ee60660ce Try speeding up rails booting 2009-06-25 14:32:15 -07:00
Yehuda Katz + Carl Lerche
c117e8e848 Run the block passed to #run first when initializing 2009-06-25 14:32:15 -07:00
Joshua Peek
b598baf813 ignore absolute tmp directory 2009-06-25 14:52:58 -05:00
Joshua Peek
7837da41a3 send_data should set Content-Length as a string 2009-06-25 14:47:15 -05:00
Joshua Peek
7aa730440c Remove deprecated implicit ivar assignment 2009-06-25 12:51:21 -05:00
Pratik Naik
97159fad6a Missed file from the previous commit 92b229e125 2009-06-25 17:03:07 +01:00
Pratik Naik
92b229e125 Make performance tests work again 2009-06-25 17:02:04 +01:00
Yehuda Katz + Carl Lerche
3aad4d7fbe Separate Rails module methods, the config object, and the initializer into separate files. 2009-06-23 16:10:43 -07:00