github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
21,254 Commits 34 Branches 105 Tags
e75774e216a4e1ba875511dc7d182133c36719aa
Commit Graph

21254 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rolf Timmermans
e75774e216 Add missing dependency string inflection test. 2011-03-13 17:03:38 +01:00
Rolf Timmermans
36313430fa Missing dependency for duration test. 2011-03-13 17:03:31 +01:00
Andrew White
47871b025e Remove invalid test 
The test fails on PostgreSQL when trying to load the records as
the comments_count field is not included in the GROUP BY clause.
 2011-03-13 08:43:19 +00:00
José Valim
9f5b1e1ed0 Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free." 
This reverts commit 46f6a2e388.

Caused failures on CI. rake test:isolated on activesupport directory show them.
 2011-03-13 08:35:50 +01:00
Santiago Pastorino
157c37f558 Refactor length validation 2011-03-12 21:12:44 -02:00
Andriy Tyurnikov
f48d3d4df6 length validation for fixnums 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-12 21:12:44 -02:00
Chris Oliver
015192560b Fixed a bug when empty? was called on a grouped Relation that wasn't loaded 
[#5829 state:resolved]

Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
 2011-03-12 22:31:21 +00:00
Rolf Timmermans
1a3fe8ce42 Prevent callbacks in child classes from being executed more than once. 2011-03-13 01:35:29 +08:00
Rolf Timmermans
46f6a2e388 It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free. 2011-03-13 01:33:10 +08:00
Mike Gehard
58de03f077 Add additional text to NotImplementedErrors [#6328 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-12 13:43:23 -02:00
Rolf Timmermans
63c8ea9a6a adds a couple of missing AS dependencies 2011-03-12 14:30:09 +01:00
Aaron Patterson
acd4bfb537 Just define methods directly on the class rather than use the module 
indirection.

clever--
 2011-03-11 18:16:47 -08:00
Aaron Patterson
89c5b9aee7 do not automatically add format to routes that end in a slash 2011-03-11 18:06:22 -08:00
José Valim
53794cf7b5 Add missing require 'thread' to BufferedLogger. 2011-03-11 13:29:39 -08:00
Samuel Kadolph
94031ef422 Add require 'date' to use Date.today in plugin template MIT-LICENSE 2011-03-12 03:27:42 +08:00
Prem Sichanugrist & Xavier Noria
68802d0fbe Filter sensitive query string parameters in the log [#6244 state:committed] 
This provides more safety to applications that put secret information in the query string, such as API keys or SSO tokens.

Signed-off-by: Xavier Noria <fxn@hashref.com>
 2011-03-11 00:16:18 +01:00
Santiago Pastorino
51a269b228 Fix typo 2011-03-09 20:17:30 -02:00
Diego Carrion
8e73e589a8 publicise ActionMailer::MailHelper.format_paragraph 
[#6550 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-09 18:36:39 -02:00
Xavier Noria
ebe4fa5fbe move the conditional definition of Float#round down 
Rails 3 cherry-picks as little as possible from Active Support. In particular
the framework requires the files where extensions are exactly defined, rather
than convenience entry points like float.rb and friends. Because of that, it
is better to define conditionally rather than require conditionally.
 2011-03-09 18:51:54 +01:00
Xavier Noria
32b5c4b77a copy-edits 532b770 2011-03-09 18:43:55 +01:00
Andrei Kulakov
532b77077f Use Rubys own Float#round method in versions 1.9 and above 2011-03-10 01:30:51 +08:00
Andrew White
03cbd9672c Filter params that return nil for to_param and allow through false values 2011-03-09 14:44:25 +00:00
Xavier Noria
f41dd99be7 revises links to the API websites of individual components (no longer maintained), and rewrites the section about after and around filters in the controller guide 2011-03-09 07:43:18 +01:00
Diego Carrion
c7cfdd01c1 refactored Engine.#find by giving an explicit name to a variable and reducing calls 
[#6529 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-09 00:28:03 -02:00
Aaron Patterson
0c777bace2 stop being clever and just call methods on the Route object 2011-03-08 16:18:27 -08:00
Aaron Patterson
f975626dc1 test/unit in ruby trunk adds a new instance variable. YAY! 2011-03-08 14:09:44 -08:00
Mat Brown
fb34f8577c Rename conflicting ActionMailer::MailHelper#simple_format method 
This was conflicting with ActionView::Helpers::TextHelper#simple_format
from within email templates.
 2011-03-09 05:49:01 +08:00
Chris Kalafarski
092538045e The root route example was the only using double quotes; switched it to single quotes for consistency 2011-03-08 09:55:57 -05:00
Aaron Pfeifer
9798ee2619 Add better test scenario for around callback return results 2011-03-08 15:01:06 +08:00
Aaron Pfeifer
df615f127e Allow access to a callback event's return result from around callbacks 2011-03-08 15:01:05 +08:00
Aaron Patterson
1408b942d9 removing stubs. 1.9.3 implements Date.today in C so mocking the return value of Time.now does nothing 2011-03-07 15:44:39 -08:00
Aaron Patterson
33f222b9e1 fixing some tests on ruby 1.9.3 2011-03-07 14:01:51 -08:00
Xavier Noria
a0d7247d15 reorganizes the RDoc of Hash#to_param 2011-03-07 22:20:24 +01:00
Xavier Noria
89ecc0a5dc Merge branch 'master' of git://github.com/lifo/docrails 2011-03-07 22:11:47 +01:00
Vijay Dev
f99db5a6a8 formatting changes 2011-03-07 23:56:16 +05:30
Aaron Patterson
5968d7a658 do not test explicit equality of predicate methods, they should be allowed to return truthy or falsey objects 2011-03-07 09:36:07 -08:00
Aaron Patterson
a032212e7c refactor calls to to_param in expand_key method 2011-03-07 09:33:19 -08:00
Jon Leighton
532f915037 Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries. 2011-03-07 08:51:17 -08:00
Aaron Patterson
9cee693213 Merge branch 'master' of github.com:rails/rails 
* 'master' of github.com:rails/rails: (44 commits)
  Fixed indentation in actionmailer base_test [#6538 state:committed]
  remove unused assigned variable
  removes merge conflicts
  removes Examples headers introduced in 9b96de6
  Revert "Fixed identation in actionmailer base_test"
  Report the correct value of nil.id in the exception message as different ruby implementations may have different values, for example Rubinius returns 53 for nil.id.
  Improve testing of cookies in functional tests: - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear
  more style changes
  Some style changes
  style changes
  Revert "style changes"
  Raise ArgumentError if route name is invalid [#6517 state:resolved]
  style changes
  Allow model to be inherited from Hash [#6487 state:resolved]
  styles applied for usage
  added failing test for fields_for with a record object that inherits from Hash
  Fixed identation in actionmailer base_test
  wrong SQL statement
  commas to set off expressions that interrupt sentence flow
  typo changes
  ...
 2011-03-07 08:50:50 -08:00
Xavier Noria
2159e9eb64 Merge branch 'active_model_unused_variable' of https://github.com/pacoguzman/rails into pacoguzman-active_model_unused_variable 2011-03-07 00:44:57 +01:00
Dalibor Nasevic
c528297d17 Fixed indentation in actionmailer base_test [#6538 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2011-03-07 00:37:45 +01:00
Dalibor Nasevic
55d2a211d3 Improved docs for Hash#to_param method 2011-03-06 23:54:18 +01:00
Paco Guzman
8e0affbd86 Configuration options are symbols 2011-03-06 22:35:26 +01:00
Paco Guzman
14c254aba3 Remove Example headers. Code just flows with the text. 6ce844a3 2011-03-06 22:34:01 +01:00
Paco Guzman
7e9d45cc7f remove unused assigned variable 2011-03-06 22:24:22 +01:00
Akira Matsuda
071ddb8281 more "SSL everywhere" for GitHub URLs 
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
 2011-03-07 06:18:32 +09:00
Akira Matsuda
5bed37779a "SSL everywhere" for GitHub URLs 
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
 2011-03-07 05:56:02 +09:00
Akira Matsuda
112c802579 s/a/an/ 2011-03-07 05:52:47 +09:00
Akira Matsuda
d91be36598 fix typos 2011-03-07 05:21:25 +09:00
Xavier Noria
3a621e7be4 removes merge conflicts 2011-03-06 20:34:56 +01:00